From 76cec3940c24a9f92bda55cdcc943667b808a5d8 Mon Sep 17 00:00:00 2001 From: Frederik Nordahl Jul Sabroe Date: Fri, 14 Jul 2017 13:24:03 +0200 Subject: [PATCH] Fix for the instructions about using KOPS_FEATURE_FLAGS for drain and validate. --- cmd/kops/rollingupdatecluster.go | 3 ++- docs/cli/kops_rolling-update.md | 2 +- docs/cli/kops_rolling-update_cluster.md | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/kops/rollingupdatecluster.go b/cmd/kops/rollingupdatecluster.go index 73cc2df2d1..d4c4003b28 100644 --- a/cmd/kops/rollingupdatecluster.go +++ b/cmd/kops/rollingupdatecluster.go @@ -33,6 +33,7 @@ import ( api "k8s.io/kops/pkg/apis/kops" "k8s.io/kops/pkg/featureflag" "k8s.io/kops/pkg/instancegroups" + "k8s.io/kops/pkg/pretty" "k8s.io/kops/upup/pkg/fi/cloudup" "k8s.io/kops/upup/pkg/kutil" "k8s.io/kops/util/pkg/tables" @@ -49,7 +50,7 @@ var ( Note: terraform users will need run the following commands all from the same directory "kops update cluster --target=terraform" then "terraform plan" then "terraform apply" prior to running "kops rolling-update cluster" - Use export KOPS_FEATURE_FLAGS="+DrainAndValidateRollingUpdate" to use beta code that drains the nodes + Use ` + pretty.Bash("export KOPS_FEATURE_FLAGS=\"+DrainAndValidateRollingUpdate\"") + ` to use beta code that drains the nodes and validates the cluster. New flags for Drain and Validation operations will be shown when the environment variable is set.`)) diff --git a/docs/cli/kops_rolling-update.md b/docs/cli/kops_rolling-update.md index ea44fdec6c..8d8f7fd603 100644 --- a/docs/cli/kops_rolling-update.md +++ b/docs/cli/kops_rolling-update.md @@ -14,7 +14,7 @@ To perform rolling update, you need to update the cloud resources first with "ko Note: terraform users will need run the following commands all from the same directory "kops update cluster --target=terraform" then "terraform plan" then "terraform apply" prior to running "kops rolling-update cluster" -Use export KOPS FEATURE FLAGS="+DrainAndValidateRollingUpdate" to use beta code that drains the nodes and validates the cluster. New flags for Drain and Validation operations will be shown when the environment variable is set. +Use export KOPS_FEATURE_FLAGS="+DrainAndValidateRollingUpdate"to use beta code that drains the nodes and validates the cluster. New flags for Drain and Validation operations will be shown when the environment variable is set. ### Examples diff --git a/docs/cli/kops_rolling-update_cluster.md b/docs/cli/kops_rolling-update_cluster.md index c7e059f2f4..c5682ef30b 100644 --- a/docs/cli/kops_rolling-update_cluster.md +++ b/docs/cli/kops_rolling-update_cluster.md @@ -14,7 +14,7 @@ To perform rolling update, you need to update the cloud resources first with "ko Note: terraform users will need run the following commands all from the same directory "kops update cluster --target=terraform" then "terraform plan" then "terraform apply" prior to running "kops rolling-update cluster" -Use export KOPS FEATURE FLAGS="+DrainAndValidateRollingUpdate" to use beta code that drains the nodes and validates the cluster. New flags for Drain and Validation operations will be shown when the environment variable is set. +Use export KOPS_FEATURE_FLAGS="+DrainAndValidateRollingUpdate"to use beta code that drains the nodes and validates the cluster. New flags for Drain and Validation operations will be shown when the environment variable is set. ``` kops rolling-update cluster