From 789b7c9f28451eb0bdadf55a88c5edf61e3fa28f Mon Sep 17 00:00:00 2001 From: Justin Santa Barbara Date: Tue, 2 Oct 2018 12:46:55 -0700 Subject: [PATCH] Remove duplicate security-group overrides --- pkg/model/firewall.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pkg/model/firewall.go b/pkg/model/firewall.go index 8995dfcecf..41e23f7917 100644 --- a/pkg/model/firewall.go +++ b/pkg/model/firewall.go @@ -461,6 +461,8 @@ func (b *KopsModelContext) GetSecurityGroups(role kops.InstanceGroupRole) ([]Sec var groups []SecurityGroupInfo + done := make(map[string]bool) + // Build groups that specify a SecurityGroupOverride allOverrides := true for _, ig := range b.InstanceGroups { @@ -474,6 +476,13 @@ func (b *KopsModelContext) GetSecurityGroups(role kops.InstanceGroupRole) ([]Sec } name := fi.StringValue(ig.Spec.SecurityGroupOverride) + + // De-duplicate security groups + if done[name] { + continue + } + done[name] = true + t := &awstasks.SecurityGroup{ Name: ig.Spec.SecurityGroupOverride, ID: ig.Spec.SecurityGroupOverride,