kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix diff formatting of bools 

We weren't correctly checking for bool differences,
so we would print things like `field: false -> false`
This commit is contained in:
justinsb 2025-04-27 14:27:55 -04:00
parent 78d4757c18
commit 833d81f4a6
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
upup/pkg/fi/dryrun_target.go
View File

@ -345,9 +345,19 @@ func buildChangeList[T SubContext](a, e, changes Task[T]) ([]change, error) {
case reflect.String: case reflect.String:
changed = fieldValC.Convert(reflect.TypeOf("")).Interface() != "" changed = fieldValC.Convert(reflect.TypeOf("")).Interface() != ""
case reflect.Int: case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
changed = fieldValA.Int() != fieldValE.Int() changed = fieldValA.Int() != fieldValE.Int()
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
changed = fieldValA.Uint() != fieldValE.Uint()
case reflect.Bool:
changed = fieldValA.Bool() != fieldValE.Bool()
default:
klog.Warningf("unhandled type in diff construction: %v", fieldValC.Kind())
} }
if !changed { if !changed {
continue continue
} }