Merge pull request #11673 from johngmyers/simplify-lifecycle

Make Lifecycle field non-pointer

pkg/model/alimodel/api_loadbalancer.go

@@ -34,7 +34,7 @@ const (
 // APILoadBalancerModelBuilder builds a LoadBalancer for accessing the API
 type APILoadBalancerModelBuilder struct {
 	*ALIModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &APILoadBalancerModelBuilder{}

pkg/model/alimodel/external_access.go

@@ -34,7 +34,7 @@ const (
 // (SSHAccess, KubernetesAPIAccess)
 type ExternalAccessModelBuilder struct {
 	*ALIModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &FirewallModelBuilder{}

pkg/model/alimodel/firewall.go

@@ -27,7 +27,7 @@ const IpProtocolAll = "all"
 // FirewallModelBuilder configures firewall network objects
 type FirewallModelBuilder struct {
 	*ALIModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &FirewallModelBuilder{}

pkg/model/alimodel/network.go

@@ -25,7 +25,7 @@ import (
 // NetworkModelBuilder configures VPC network objects
 type NetworkModelBuilder struct {
 	*ALIModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &NetworkModelBuilder{}

pkg/model/alimodel/ram.go

@@ -31,7 +31,7 @@ const PolicyType = string(ram.Custom)
 type RAMModelBuilder struct {
 	*ALIModelContext
 
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 type AssumeRolePolicyDocument struct {

pkg/model/alimodel/scalinggroup.go

@@ -34,8 +34,8 @@ type ScalingGroupModelBuilder struct {
 	*ALIModelContext
 
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
-	SecurityLifecycle      *fi.Lifecycle
+	SecurityLifecycle      fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &ScalingGroupModelBuilder{}

pkg/model/alimodel/sshkey.go

@@ -24,7 +24,7 @@ import (
 // SSHKeyModelBuilder configures SSH objects
 type SSHKeyModelBuilder struct {
 	*ALIModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &SSHKeyModelBuilder{}

pkg/model/awsmodel/api_loadbalancer.go

@@ -37,8 +37,8 @@ const LoadBalancerDefaultIdleTimeout = 5 * time.Minute
 type APILoadBalancerBuilder struct {
 	*AWSModelContext
 
-	Lifecycle         *fi.Lifecycle
+	Lifecycle         fi.Lifecycle
-	SecurityLifecycle *fi.Lifecycle
+	SecurityLifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &APILoadBalancerBuilder{}

pkg/model/awsmodel/autoscalinggroup.go

@@ -53,8 +53,8 @@ type AutoscalingGroupModelBuilder struct {
 	*AWSModelContext
 
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
-	SecurityLifecycle      *fi.Lifecycle
+	SecurityLifecycle      fi.Lifecycle
 	Cluster                *kops.Cluster
 }
 

pkg/model/awsmodel/bastion.go

@@ -39,8 +39,8 @@ const (
 
 type BastionModelBuilder struct {
 	*AWSModelContext
-	Lifecycle         *fi.Lifecycle
+	Lifecycle         fi.Lifecycle
-	SecurityLifecycle *fi.Lifecycle
+	SecurityLifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &BastionModelBuilder{}

pkg/model/awsmodel/dns.go

@@ -29,7 +29,7 @@ import (
 // DNSModelBuilder builds DNS related model objects
 type DNSModelBuilder struct {
 	*AWSModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &DNSModelBuilder{}

pkg/model/awsmodel/external_access.go

@@ -30,7 +30,7 @@ import (
 // (SSHAccess, KubernetesAPIAccess)
 type ExternalAccessModelBuilder struct {
 	*AWSModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &ExternalAccessModelBuilder{}

pkg/model/awsmodel/firewall.go

@@ -36,7 +36,7 @@ const (
 // FirewallModelBuilder configures firewall network objects
 type FirewallModelBuilder struct {
 	*AWSModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &FirewallModelBuilder{}

pkg/model/awsmodel/iam.go

@@ -38,7 +38,7 @@ import (
 // IAMModelBuilder configures IAM objects
 type IAMModelBuilder struct {
 	*AWSModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 	Cluster   *kops.Cluster
 }
 

pkg/model/awsmodel/network.go

@@ -31,7 +31,7 @@ import (
 // NetworkModelBuilder configures network objects
 type NetworkModelBuilder struct {
 	*AWSModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &NetworkModelBuilder{}

pkg/model/awsmodel/nodeterminationhandler.go

@@ -70,7 +70,7 @@ var (
 type NodeTerminationHandlerBuilder struct {
 	*AWSModelContext
 
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 func (b *NodeTerminationHandlerBuilder) Build(c *fi.ModelBuilderContext) error {

pkg/model/awsmodel/oidc_provider.go

@@ -26,7 +26,7 @@ import (
 type OIDCProviderBuilder struct {
 	*AWSModelContext
 	KeyStore  fi.CAStore
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &OIDCProviderBuilder{}

pkg/model/awsmodel/spotinst.go

@@ -128,8 +128,8 @@ const (
 type SpotInstanceGroupModelBuilder struct {
 	*AWSModelContext
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
-	SecurityLifecycle      *fi.Lifecycle
+	SecurityLifecycle      fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &SpotInstanceGroupModelBuilder{}

pkg/model/awsmodel/sshkey.go

@@ -24,7 +24,7 @@ import (
 // SSHKeyModelBuilder configures SSH objects
 type SSHKeyModelBuilder struct {
 	*AWSModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &SSHKeyModelBuilder{}

pkg/model/azuremodel/api_loadbalancer.go

@@ -30,8 +30,8 @@ import (
 type APILoadBalancerModelBuilder struct {
 	*AzureModelContext
 
-	Lifecycle         *fi.Lifecycle
+	Lifecycle         fi.Lifecycle
-	SecurityLifecycle *fi.Lifecycle
+	SecurityLifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &APILoadBalancerModelBuilder{}

pkg/model/azuremodel/network.go

@@ -24,7 +24,7 @@ import (
 // NetworkModelBuilder configures a Virtual Network and subnets.
 type NetworkModelBuilder struct {
 	*AzureModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &NetworkModelBuilder{}

pkg/model/azuremodel/resourcegroup.go

@@ -24,7 +24,7 @@ import (
 // ResourceGroupModelBuilder configures a Resource Group.
 type ResourceGroupModelBuilder struct {
 	*AzureModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &ResourceGroupModelBuilder{}

pkg/model/azuremodel/vmscaleset.go

@@ -33,7 +33,7 @@ import (
 type VMScaleSetModelBuilder struct {
 	*AzureModelContext
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &VMScaleSetModelBuilder{}

pkg/model/components/etcdmanager/model.go

@@ -48,7 +48,7 @@ import (
 // EtcdManagerBuilder builds the manifest for the etcd-manager
 type EtcdManagerBuilder struct {
 	*model.KopsModelContext
-	Lifecycle    *fi.Lifecycle
+	Lifecycle    fi.Lifecycle
 	AssetBuilder *assets.AssetBuilder
 }
 

pkg/model/components/etcdmanager/tests/minimal/tasks.yaml

@@ -1,4 +1,4 @@
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-clients-ca
 Signer: null
 alternateNames: null
@@ -6,7 +6,7 @@ oldFormat: false
 subject: cn=etcd-clients-ca
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-events
 Signer: null
 alternateNames: null
@@ -14,7 +14,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-main
 Signer: null
 alternateNames: null
@@ -22,7 +22,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-main
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-events
 Signer: null
 alternateNames: null
@@ -30,7 +30,7 @@ oldFormat: false
 subject: cn=etcd-peers-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-main
 Signer: null
 alternateNames: null
@@ -43,7 +43,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-events
 Public: null
@@ -53,7 +53,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-main
 Public: null
@@ -124,7 +124,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/events.yaml
 Name: manifests-etcdmanager-events
 Public: null
@@ -195,7 +195,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/main.yaml
 Name: manifests-etcdmanager-main
 Public: null

pkg/model/components/etcdmanager/tests/overwrite_settings/tasks.yaml

@@ -1,4 +1,4 @@
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-clients-ca
 Signer: null
 alternateNames: null
@@ -6,7 +6,7 @@ oldFormat: false
 subject: cn=etcd-clients-ca
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-events
 Signer: null
 alternateNames: null
@@ -14,7 +14,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-main
 Signer: null
 alternateNames: null
@@ -22,7 +22,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-main
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-events
 Signer: null
 alternateNames: null
@@ -30,7 +30,7 @@ oldFormat: false
 subject: cn=etcd-peers-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-main
 Signer: null
 alternateNames: null
@@ -43,7 +43,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-events
 Public: null
@@ -53,7 +53,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-main
 Public: null
@@ -127,7 +127,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/events.yaml
 Name: manifests-etcdmanager-events
 Public: null
@@ -201,7 +201,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/main.yaml
 Name: manifests-etcdmanager-main
 Public: null

pkg/model/components/etcdmanager/tests/pollinterval/tasks.yaml

@@ -1,4 +1,4 @@
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-clients-ca
 Signer: null
 alternateNames: null
@@ -6,7 +6,7 @@ oldFormat: false
 subject: cn=etcd-clients-ca
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-events
 Signer: null
 alternateNames: null
@@ -14,7 +14,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-main
 Signer: null
 alternateNames: null
@@ -22,7 +22,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-main
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-events
 Signer: null
 alternateNames: null
@@ -30,7 +30,7 @@ oldFormat: false
 subject: cn=etcd-peers-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-main
 Signer: null
 alternateNames: null
@@ -43,7 +43,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-events
 Public: null
@@ -53,7 +53,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-main
 Public: null
@@ -124,7 +124,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/events.yaml
 Name: manifests-etcdmanager-events
 Public: null
@@ -195,7 +195,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/main.yaml
 Name: manifests-etcdmanager-main
 Public: null

pkg/model/components/etcdmanager/tests/proxy/tasks.yaml

@@ -1,4 +1,4 @@
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-clients-ca
 Signer: null
 alternateNames: null
@@ -6,7 +6,7 @@ oldFormat: false
 subject: cn=etcd-clients-ca
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-events
 Signer: null
 alternateNames: null
@@ -14,7 +14,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-manager-ca-main
 Signer: null
 alternateNames: null
@@ -22,7 +22,7 @@ oldFormat: false
 subject: cn=etcd-manager-ca-main
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-events
 Signer: null
 alternateNames: null
@@ -30,7 +30,7 @@ oldFormat: false
 subject: cn=etcd-peers-ca-events
 type: ca
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: etcd-peers-ca-main
 Signer: null
 alternateNames: null
@@ -43,7 +43,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-events
 Public: null
@@ -53,7 +53,7 @@ Contents: |-
   {
     "memberCount": 1
   }
-Lifecycle: null
+Lifecycle: ""
 Location: /control/etcd-cluster-spec
 Name: etcd-cluster-spec-main
 Public: null
@@ -133,7 +133,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/events.yaml
 Name: manifests-etcdmanager-events
 Public: null
@@ -213,7 +213,7 @@ Contents: |
         type: FileOrCreate
       name: varlogetcd
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/etcd/main.yaml
 Name: manifests-etcdmanager-main
 Public: null

pkg/model/components/kubeapiserver/model.go

@@ -32,7 +32,7 @@ import (
 // KubeApiserverBuilder builds the static manifest for kube-apiserver-healthcheck sidecar
 type KubeApiserverBuilder struct {
 	*model.KopsModelContext
-	Lifecycle    *fi.Lifecycle
+	Lifecycle    fi.Lifecycle
 	AssetBuilder *assets.AssetBuilder
 }
 

pkg/model/components/kubeapiserver/tests/minimal/tasks.yaml

@@ -32,7 +32,7 @@ Contents: |
         type: Directory
       name: healthcheck-secrets
   status: {}
-Lifecycle: null
+Lifecycle: ""
 Location: manifests/static/kube-apiserver-healthcheck.yaml
 Name: manifests-static-kube-apiserver-healthcheck
 Public: null

pkg/model/domodel/api_loadbalancer.go

@@ -30,7 +30,7 @@ import (
 // APILoadBalancerModelBuilder builds a LoadBalancer for accessing the API
 type APILoadBalancerModelBuilder struct {
 	*DOModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &APILoadBalancerModelBuilder{}

pkg/model/domodel/droplets.go

@@ -31,7 +31,7 @@ type DropletBuilder struct {
 	*DOModelContext
 
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &DropletBuilder{}

pkg/model/gcemodel/api_loadbalancer.go

@@ -27,7 +27,7 @@ import (
 // APILoadBalancerBuilder builds a LoadBalancer for accessing the API
 type APILoadBalancerBuilder struct {
 	*GCEModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &APILoadBalancerBuilder{}

pkg/model/gcemodel/autoscalinggroup.go

@@ -41,7 +41,7 @@ type AutoscalingGroupModelBuilder struct {
 	*GCEModelContext
 
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &AutoscalingGroupModelBuilder{}

pkg/model/gcemodel/external_access.go

@@ -27,7 +27,7 @@ import (
 // (SSHAccess, KubernetesAPIAccess)
 type ExternalAccessModelBuilder struct {
 	*GCEModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &ExternalAccessModelBuilder{}

pkg/model/gcemodel/firewall.go

@@ -26,7 +26,7 @@ import (
 // FirewallModelBuilder configures firewall network objects
 type FirewallModelBuilder struct {
 	*GCEModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &FirewallModelBuilder{}

pkg/model/gcemodel/network.go

@@ -28,7 +28,7 @@ import (
 // NetworkModelBuilder configures network objects
 type NetworkModelBuilder struct {
 	*GCEModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &NetworkModelBuilder{}

pkg/model/gcemodel/storageacl.go

@@ -34,7 +34,7 @@ import (
 type StorageAclBuilder struct {
 	*GCEModelContext
 	Cloud     gce.GCECloud
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &NetworkModelBuilder{}

pkg/model/issuerdiscovery.go

@@ -37,7 +37,7 @@ import (
 type IssuerDiscoveryModelBuilder struct {
 	*KopsModelContext
 
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 	Cluster   *kops.Cluster
 }
 

pkg/model/master_volumes.go

@@ -52,7 +52,7 @@ const (
 // MasterVolumeBuilder builds master EBS volumes
 type MasterVolumeBuilder struct {
 	*KopsModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &MasterVolumeBuilder{}

pkg/model/openstackmodel/firewall.go

@@ -41,7 +41,7 @@ const (
 // FirewallModelBuilder configures firewall network objects
 type FirewallModelBuilder struct {
 	*OpenstackModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 	Rules     map[string]*openstacktasks.SecurityGroupRule
 }
 

pkg/model/openstackmodel/network.go

@@ -26,7 +26,7 @@ import (
 // NetworkModelBuilder configures network objects
 type NetworkModelBuilder struct {
 	*OpenstackModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &NetworkModelBuilder{}

pkg/model/openstackmodel/servergroup.go

@@ -35,7 +35,7 @@ import (
 type ServerGroupModelBuilder struct {
 	*OpenstackModelContext
 	BootstrapScriptBuilder *model.BootstrapScriptBuilder
-	Lifecycle              *fi.Lifecycle
+	Lifecycle              fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &ServerGroupModelBuilder{}

pkg/model/openstackmodel/servergroup_test.go

@@ -1005,7 +1005,7 @@ func createBuilderForCluster(cluster *kops.Cluster, instanceGroups []*kops.Insta
 	return &ServerGroupModelBuilder{
 		OpenstackModelContext:  openstackModelContext,
 		BootstrapScriptBuilder: bootstrapScriptBuilder,
-		Lifecycle:              &clusterLifecycle,
+		Lifecycle:              clusterLifecycle,
 	}
 }
 

pkg/model/openstackmodel/sshkey.go

@@ -24,7 +24,7 @@ import (
 // SSHKeyModelBuilder configures SSH objects
 type SSHKeyModelBuilder struct {
 	*OpenstackModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &SSHKeyModelBuilder{}

pkg/model/openstackmodel/tests/servergroup/adds-additional-security-groups.yaml

@@ -31,13 +31,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -45,7 +45,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -68,7 +68,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -84,13 +84,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -98,7 +98,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/adds-cloud-labels-from-ClusterSpec.yaml

@@ -31,13 +31,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -45,7 +45,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -67,7 +67,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -82,13 +82,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -96,7 +96,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/adds-cloud-labels-from-InstanceGroupSpec.yaml

@@ -31,13 +31,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -45,7 +45,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -67,7 +67,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -82,13 +82,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -96,7 +96,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/configures-server-group-affinity-with-annotations.yaml

@@ -30,13 +30,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -44,7 +44,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -66,7 +66,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -81,13 +81,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -95,7 +95,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/multizone-setup-3-masters-3-nodes-without-bastion-auto-zone-distribution.yaml

@@ -83,19 +83,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -103,7 +103,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -164,19 +164,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -184,7 +184,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -245,19 +245,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -265,7 +265,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -323,13 +323,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -337,7 +337,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -395,13 +395,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -409,7 +409,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -467,13 +467,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -481,7 +481,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -503,7 +503,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -518,19 +518,19 @@ Name: port-master-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -538,7 +538,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -551,19 +551,19 @@ Name: port-master-2-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -571,7 +571,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -584,19 +584,19 @@ Name: port-master-3-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -604,7 +604,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null
@@ -617,13 +617,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -631,7 +631,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -644,13 +644,13 @@ Name: port-node-2-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -658,7 +658,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -671,13 +671,13 @@ Name: port-node-3-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -685,7 +685,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/multizone-setup-3-masters-3-nodes-without-bastion-with-API-loadbalancer.yaml

@@ -21,7 +21,7 @@ LB:
   SecurityGroup:
     Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -84,13 +84,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -98,7 +98,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -153,13 +153,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -167,7 +167,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -222,13 +222,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -236,7 +236,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -294,13 +294,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -308,7 +308,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -366,13 +366,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -380,7 +380,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -438,13 +438,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -452,7 +452,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -474,7 +474,7 @@ UserData:
   task:
     Name: node-c
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -489,7 +489,7 @@ PortID: null
 SecurityGroup:
   Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -511,7 +511,7 @@ Pool:
     SecurityGroup:
       Description: null
       ID: null
-      Lifecycle: null
+      Lifecycle: ""
       Name: master-public-name
       RemoveExtraRules: null
       RemoveGroup: false
@@ -529,7 +529,7 @@ Loadbalancer:
   SecurityGroup:
     Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -552,7 +552,7 @@ Pool:
     SecurityGroup:
       Description: null
       ID: null
-      Lifecycle: null
+      Lifecycle: ""
       Name: master-public-name
       RemoveExtraRules: null
       RemoveGroup: false
@@ -585,7 +585,7 @@ Pool:
     SecurityGroup:
       Description: null
       ID: null
-      Lifecycle: null
+      Lifecycle: ""
       Name: master-public-name
       RemoveExtraRules: null
       RemoveGroup: false
@@ -618,7 +618,7 @@ Pool:
     SecurityGroup:
       Description: null
       ID: null
-      Lifecycle: null
+      Lifecycle: ""
       Name: master-public-name
       RemoveExtraRules: null
       RemoveGroup: false
@@ -643,13 +643,13 @@ Name: port-master-a-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -657,7 +657,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -670,13 +670,13 @@ Name: port-master-b-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -684,7 +684,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -697,13 +697,13 @@ Name: port-master-c-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -711,7 +711,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null
@@ -724,13 +724,13 @@ Name: port-node-a-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -738,7 +738,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -751,13 +751,13 @@ Name: port-node-b-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -765,7 +765,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -778,13 +778,13 @@ Name: port-node-c-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -792,7 +792,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/multizone-setup-3-masters-3-nodes-without-bastion.yaml

@@ -91,19 +91,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -111,7 +111,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -172,19 +172,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -192,7 +192,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -253,19 +253,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -273,7 +273,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -331,13 +331,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -345,7 +345,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -403,13 +403,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -417,7 +417,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -475,13 +475,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -489,7 +489,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -511,7 +511,7 @@ UserData:
   task:
     Name: node-c
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -526,19 +526,19 @@ Name: port-master-a-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -546,7 +546,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -559,19 +559,19 @@ Name: port-master-b-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -579,7 +579,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -592,19 +592,19 @@ Name: port-master-c-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -612,7 +612,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null
@@ -625,13 +625,13 @@ Name: port-node-a-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -639,7 +639,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -652,13 +652,13 @@ Name: port-node-b-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -666,7 +666,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -679,13 +679,13 @@ Name: port-node-c-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -693,7 +693,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/multizone-setup-3-masters-3-nodes-without-external-router.yaml

@@ -43,19 +43,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -63,7 +63,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -118,19 +118,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -138,7 +138,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -193,19 +193,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -213,7 +213,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -265,13 +265,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -279,7 +279,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-a.cluster
     Network: null
     Tag: null
@@ -331,13 +331,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -345,7 +345,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-b.cluster
     Network: null
     Tag: null
@@ -397,13 +397,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -411,7 +411,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet-c.cluster
     Network: null
     Tag: null
@@ -433,7 +433,7 @@ UserData:
   task:
     Name: node-c
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -448,19 +448,19 @@ Name: port-master-a-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -468,7 +468,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -481,19 +481,19 @@ Name: port-master-b-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -501,7 +501,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -514,19 +514,19 @@ Name: port-master-c-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -534,7 +534,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null
@@ -547,13 +547,13 @@ Name: port-node-a-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -561,7 +561,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-a.cluster
   Network: null
   Tag: null
@@ -574,13 +574,13 @@ Name: port-node-b-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -588,7 +588,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-b.cluster
   Network: null
   Tag: null
@@ -601,13 +601,13 @@ Name: port-node-c-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -615,7 +615,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet-c.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/one-master-one-node-one-bastion-2.yaml

@@ -33,13 +33,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: bastion.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -47,7 +47,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: utility-subnet.cluster
     Network: null
     Tag: null
@@ -102,19 +102,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -122,7 +122,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -174,13 +174,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -188,7 +188,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -210,7 +210,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -225,13 +225,13 @@ Name: port-bastion-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: bastion.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -239,7 +239,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: utility-subnet.cluster
   Network: null
   Tag: null
@@ -252,19 +252,19 @@ Name: port-master-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -272,7 +272,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null
@@ -285,13 +285,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -299,7 +299,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/one-master-one-node-one-bastion.yaml

@@ -53,13 +53,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: bastion.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -67,7 +67,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: utility-subnet.cluster
     Network: null
     Tag: null
@@ -128,19 +128,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -148,7 +148,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -200,13 +200,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -214,7 +214,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -236,7 +236,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -251,13 +251,13 @@ Name: port-bastion-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: bastion.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -265,7 +265,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: utility-subnet.cluster
   Network: null
   Tag: null
@@ -278,19 +278,19 @@ Name: port-master-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -298,7 +298,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null
@@ -311,13 +311,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -325,7 +325,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/one-master-one-node-without-bastion-no-public-ip-association.yaml

@@ -35,19 +35,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -55,7 +55,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -107,13 +107,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -121,7 +121,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -143,7 +143,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -158,19 +158,19 @@ Name: port-master-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -178,7 +178,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null
@@ -191,13 +191,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -205,7 +205,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/one-master-one-node.yaml

@@ -55,19 +55,19 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: masters.cluster
     RemoveExtraRules: null
     RemoveGroup: false
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: master-public-name
     RemoveExtraRules: null
     RemoveGroup: false
@@ -75,7 +75,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -133,13 +133,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -147,7 +147,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -169,7 +169,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -184,19 +184,19 @@ Name: port-master-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: masters.cluster
   RemoveExtraRules: null
   RemoveGroup: false
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: master-public-name
   RemoveExtraRules: null
   RemoveGroup: false
@@ -204,7 +204,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null
@@ -217,13 +217,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -231,7 +231,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/uses-instance-group-subnet-as-availability-zones-fallback.yaml

@@ -31,13 +31,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -45,7 +45,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -68,7 +68,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -84,13 +84,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -98,7 +98,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/openstackmodel/tests/servergroup/uses-instance-group-zones-as-availability-zones.yaml

@@ -31,13 +31,13 @@ Port:
   Network:
     AvailabilityZoneHints: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: cluster
     Tag: null
   SecurityGroups:
   - Description: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: nodes.cluster
     RemoveExtraRules: null
     RemoveGroup: false
@@ -45,7 +45,7 @@ Port:
   - CIDR: null
     DNSServers: null
     ID: null
-    Lifecycle: null
+    Lifecycle: ""
     Name: subnet.cluster
     Network: null
     Tag: null
@@ -68,7 +68,7 @@ UserData:
   task:
     Name: node
 ---
-Lifecycle: null
+Lifecycle: ""
 Name: ca
 Signer: null
 alternateNames: null
@@ -84,13 +84,13 @@ Name: port-node-1-cluster
 Network:
   AvailabilityZoneHints: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: cluster
   Tag: null
 SecurityGroups:
 - Description: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: nodes.cluster
   RemoveExtraRules: null
   RemoveGroup: false
@@ -98,7 +98,7 @@ Subnets:
 - CIDR: null
   DNSServers: null
   ID: null
-  Lifecycle: null
+  Lifecycle: ""
   Name: subnet.cluster
   Network: null
   Tag: null

pkg/model/pki.go

@@ -30,7 +30,7 @@ import (
 // PKIModelBuilder configures PKI keypairs, as well as tokens
 type PKIModelBuilder struct {
 	*KopsModelContext
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 }
 
 var _ fi.ModelBuilder = &PKIModelBuilder{}

upup/pkg/fi/assettasks/copyfile.go

@@ -38,7 +38,7 @@ type CopyFile struct {
 	SourceFile *string
 	TargetFile *string
 	SHA        *string
-	Lifecycle  *fi.Lifecycle
+	Lifecycle  fi.Lifecycle
 }
 
 var _ fi.CompareWithID = &CopyFile{}

upup/pkg/fi/assettasks/copyfile_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &CopyFile{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *CopyFile) GetLifecycle() *fi.Lifecycle {
+func (o *CopyFile) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *CopyFile) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &CopyFile{}

upup/pkg/fi/assettasks/copyimage.go

@@ -30,7 +30,7 @@ type CopyImage struct {
 	Name        *string
 	SourceImage *string
 	TargetImage *string
-	Lifecycle   *fi.Lifecycle
+	Lifecycle   fi.Lifecycle
 }
 
 var _ fi.CompareWithID = &CopyImage{}

upup/pkg/fi/assettasks/copyimage_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &CopyImage{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *CopyImage) GetLifecycle() *fi.Lifecycle {
+func (o *CopyImage) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *CopyImage) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &CopyImage{}

upup/pkg/fi/cloudup/alitasks/disk.go

@@ -36,7 +36,7 @@ const (
 // Disk represents an ALI Cloud Disk.
 // +kops:fitask
 type Disk struct {
-	Lifecycle    *fi.Lifecycle
+	Lifecycle    fi.Lifecycle
 	Name         *string
 	DiskId       *string
 	ZoneId       *string

upup/pkg/fi/cloudup/alitasks/disk_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &Disk{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *Disk) GetLifecycle() *fi.Lifecycle {
+func (o *Disk) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *Disk) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &Disk{}

upup/pkg/fi/cloudup/alitasks/eip_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &EIP{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *EIP) GetLifecycle() *fi.Lifecycle {
+func (o *EIP) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *EIP) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &EIP{}

upup/pkg/fi/cloudup/alitasks/eip_natgateway_association.go

@@ -35,7 +35,7 @@ const (
 // +kops:fitask
 type EIP struct {
 	Name      *string
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 
 	Region     *string
 	ID         *string

upup/pkg/fi/cloudup/alitasks/launchconfiguration.go

@@ -54,7 +54,7 @@ func RetainLaunchConfigurationCount() int {
 // LaunchConfiguration is the specification for a launch configuration
 // +kops:fitask
 type LaunchConfiguration struct {
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 	ID        *string
 	Name      *string
 

upup/pkg/fi/cloudup/alitasks/launchconfiguration_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &LaunchConfiguration{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *LaunchConfiguration) GetLifecycle() *fi.Lifecycle {
+func (o *LaunchConfiguration) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *LaunchConfiguration) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &LaunchConfiguration{}

upup/pkg/fi/cloudup/alitasks/loadbalancer.go

@@ -38,7 +38,7 @@ type LoadBalancer struct {
 	AddressType         *string
 	VSwitchId           *string
 	LoadBalancerAddress *string
-	Lifecycle           *fi.Lifecycle
+	Lifecycle           fi.Lifecycle
 	Tags                map[string]string
 	ForAPIServer        bool
 }

upup/pkg/fi/cloudup/alitasks/loadbalancer_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &LoadBalancer{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *LoadBalancer) GetLifecycle() *fi.Lifecycle {
+func (o *LoadBalancer) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *LoadBalancer) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &LoadBalancer{}

upup/pkg/fi/cloudup/alitasks/loadbalanceracl.go

@@ -37,7 +37,7 @@ type LoadBalancerACL struct {
 	LoadBalancer         *LoadBalancer
 	LoadBalancerListener *LoadBalancerListener
 	SourceItems          []*string
-	Lifecycle            *fi.Lifecycle
+	Lifecycle            fi.Lifecycle
 }
 
 type AclEntry struct {

upup/pkg/fi/cloudup/alitasks/loadbalanceracl_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &LoadBalancerACL{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *LoadBalancerACL) GetLifecycle() *fi.Lifecycle {
+func (o *LoadBalancerACL) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *LoadBalancerACL) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &LoadBalancerACL{}

upup/pkg/fi/cloudup/alitasks/loadbalancerlistener.go

@@ -37,7 +37,7 @@ type LoadBalancerListener struct {
 	Name              *string
 	ListenerPort      *int
 	BackendServerPort *int
-	Lifecycle         *fi.Lifecycle
+	Lifecycle         fi.Lifecycle
 	ListenerStatus    *string
 	Bandwidth         *int
 }

upup/pkg/fi/cloudup/alitasks/loadbalancerlistener_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &LoadBalancerListener{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *LoadBalancerListener) GetLifecycle() *fi.Lifecycle {
+func (o *LoadBalancerListener) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *LoadBalancerListener) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &LoadBalancerListener{}

upup/pkg/fi/cloudup/alitasks/natgateway.go

@@ -31,7 +31,7 @@ import (
 // +kops:fitask
 type NatGateway struct {
 	Name      *string
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 
 	VPC    *VPC
 	Region *string

upup/pkg/fi/cloudup/alitasks/natgateway_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &NatGateway{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *NatGateway) GetLifecycle() *fi.Lifecycle {
+func (o *NatGateway) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *NatGateway) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &NatGateway{}

upup/pkg/fi/cloudup/alitasks/rampolicy.go

@@ -32,7 +32,7 @@ import (
 
 // +kops:fitask
 type RAMPolicy struct {
-	Lifecycle      *fi.Lifecycle
+	Lifecycle      fi.Lifecycle
 	Name           *string
 	RamRole        *RAMRole
 	PolicyType     *string

upup/pkg/fi/cloudup/alitasks/rampolicy_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &RAMPolicy{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *RAMPolicy) GetLifecycle() *fi.Lifecycle {
+func (o *RAMPolicy) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *RAMPolicy) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &RAMPolicy{}

upup/pkg/fi/cloudup/alitasks/ramrole.go

@@ -33,7 +33,7 @@ import (
 // +kops:fitask
 type RAMRole struct {
 	ID                       *string
-	Lifecycle                *fi.Lifecycle
+	Lifecycle                fi.Lifecycle
 	Name                     *string
 	AssumeRolePolicyDocument *string
 }

upup/pkg/fi/cloudup/alitasks/ramrole_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &RAMRole{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *RAMRole) GetLifecycle() *fi.Lifecycle {
+func (o *RAMRole) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *RAMRole) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &RAMRole{}

upup/pkg/fi/cloudup/alitasks/scalinggroup.go

@@ -34,7 +34,7 @@ import (
 // +kops:fitask
 type ScalingGroup struct {
 	Name           *string
-	Lifecycle      *fi.Lifecycle
+	Lifecycle      fi.Lifecycle
 	ScalingGroupId *string
 	LoadBalancer   *LoadBalancer
 	VSwitchs       []*VSwitch

upup/pkg/fi/cloudup/alitasks/scalinggroup_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &ScalingGroup{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *ScalingGroup) GetLifecycle() *fi.Lifecycle {
+func (o *ScalingGroup) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *ScalingGroup) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &ScalingGroup{}

upup/pkg/fi/cloudup/alitasks/securitygroup.go

@@ -36,7 +36,7 @@ const SecurityResource = "securitygroup"
 type SecurityGroup struct {
 	Name            *string
 	SecurityGroupId *string
-	Lifecycle       *fi.Lifecycle
+	Lifecycle       fi.Lifecycle
 	VPC             *VPC
 	Tags            map[string]string
 }

upup/pkg/fi/cloudup/alitasks/securitygroup_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &SecurityGroup{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *SecurityGroup) GetLifecycle() *fi.Lifecycle {
+func (o *SecurityGroup) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *SecurityGroup) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &SecurityGroup{}

upup/pkg/fi/cloudup/alitasks/securitygrouprule.go

@@ -37,7 +37,7 @@ type SecurityGroupRule struct {
 	SourceCidrIp  *string
 	SecurityGroup *SecurityGroup
 	SourceGroup   *SecurityGroup
-	Lifecycle     *fi.Lifecycle
+	Lifecycle     fi.Lifecycle
 	PortRange     *string
 	In            *bool
 }

upup/pkg/fi/cloudup/alitasks/securitygrouprule_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &SecurityGroupRule{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *SecurityGroupRule) GetLifecycle() *fi.Lifecycle {
+func (o *SecurityGroupRule) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *SecurityGroupRule) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &SecurityGroupRule{}

upup/pkg/fi/cloudup/alitasks/sshkey.go

@@ -34,7 +34,7 @@ import (
 // +kops:fitask
 type SSHKey struct {
 	Name               *string
-	Lifecycle          *fi.Lifecycle
+	Lifecycle          fi.Lifecycle
 	PublicKey          fi.Resource
 	KeyPairFingerPrint *string
 }

upup/pkg/fi/cloudup/alitasks/sshkey_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &SSHKey{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *SSHKey) GetLifecycle() *fi.Lifecycle {
+func (o *SSHKey) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *SSHKey) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &SSHKey{}

upup/pkg/fi/cloudup/alitasks/vpc.go

@@ -31,7 +31,7 @@ import (
 // +kops:fitask
 type VPC struct {
 	Name      *string
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 
 	ID     *string
 	Region *string

upup/pkg/fi/cloudup/alitasks/vpc_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &VPC{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *VPC) GetLifecycle() *fi.Lifecycle {
+func (o *VPC) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *VPC) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &VPC{}

upup/pkg/fi/cloudup/alitasks/vswitch.go

@@ -34,7 +34,7 @@ type VSwitch struct {
 	Name      *string
 	VSwitchId *string
 
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 	ZoneId    *string
 
 	CidrBlock *string

upup/pkg/fi/cloudup/alitasks/vswitchSNAT.go

@@ -32,7 +32,7 @@ import (
 // +kops:fitask
 type VSwitchSNAT struct {
 	Name      *string
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 	ID        *string
 
 	VSwitch     *VSwitch

upup/pkg/fi/cloudup/alitasks/vswitch_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &VSwitch{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *VSwitch) GetLifecycle() *fi.Lifecycle {
+func (o *VSwitch) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *VSwitch) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &VSwitch{}

upup/pkg/fi/cloudup/alitasks/vswitchsnat_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &VSwitchSNAT{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *VSwitchSNAT) GetLifecycle() *fi.Lifecycle {
+func (o *VSwitchSNAT) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *VSwitchSNAT) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &VSwitchSNAT{}

upup/pkg/fi/cloudup/apply_cluster.go

@@ -516,7 +516,7 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 
 		bcb := bootstrapchannelbuilder.NewBootstrapChannelBuilder(
 			modelContext,
-			&clusterLifecycle,
+			clusterLifecycle,
 			assetBuilder,
 			templates,
 			addons,
@@ -527,24 +527,24 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 			bcb,
 			&model.PKIModelBuilder{
 				KopsModelContext: modelContext,
-				Lifecycle:        &clusterLifecycle,
+				Lifecycle:        clusterLifecycle,
 			},
 			&model.IssuerDiscoveryModelBuilder{
 				KopsModelContext: modelContext,
-				Lifecycle:        &clusterLifecycle,
+				Lifecycle:        clusterLifecycle,
 				Cluster:          cluster,
 			},
 			&kubeapiserver.KubeApiserverBuilder{
 				AssetBuilder:     assetBuilder,
 				KopsModelContext: modelContext,
-				Lifecycle:        &clusterLifecycle,
+				Lifecycle:        clusterLifecycle,
 			},
 			&etcdmanager.EtcdManagerBuilder{
 				AssetBuilder:     assetBuilder,
 				KopsModelContext: modelContext,
-				Lifecycle:        &clusterLifecycle,
+				Lifecycle:        clusterLifecycle,
 			},
-			&model.MasterVolumeBuilder{KopsModelContext: modelContext, Lifecycle: &clusterLifecycle},
+			&model.MasterVolumeBuilder{KopsModelContext: modelContext, Lifecycle: clusterLifecycle},
 		)
 
 		switch kops.CloudProviderID(cluster.Spec.CloudProvider) {
@@ -554,22 +554,22 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 			}
 
 			l.Builders = append(l.Builders,
-				&awsmodel.APILoadBalancerBuilder{AWSModelContext: awsModelContext, Lifecycle: &clusterLifecycle, SecurityLifecycle: &securityLifecycle},
+				&awsmodel.APILoadBalancerBuilder{AWSModelContext: awsModelContext, Lifecycle: clusterLifecycle, SecurityLifecycle: securityLifecycle},
-				&awsmodel.BastionModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &clusterLifecycle, SecurityLifecycle: &securityLifecycle},
+				&awsmodel.BastionModelBuilder{AWSModelContext: awsModelContext, Lifecycle: clusterLifecycle, SecurityLifecycle: securityLifecycle},
-				&awsmodel.DNSModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &clusterLifecycle},
+				&awsmodel.DNSModelBuilder{AWSModelContext: awsModelContext, Lifecycle: clusterLifecycle},
-				&awsmodel.ExternalAccessModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &securityLifecycle},
+				&awsmodel.ExternalAccessModelBuilder{AWSModelContext: awsModelContext, Lifecycle: securityLifecycle},
-				&awsmodel.FirewallModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &securityLifecycle},
+				&awsmodel.FirewallModelBuilder{AWSModelContext: awsModelContext, Lifecycle: securityLifecycle},
-				&awsmodel.SSHKeyModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &securityLifecycle},
+				&awsmodel.SSHKeyModelBuilder{AWSModelContext: awsModelContext, Lifecycle: securityLifecycle},
-				&awsmodel.NetworkModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &networkLifecycle},
+				&awsmodel.NetworkModelBuilder{AWSModelContext: awsModelContext, Lifecycle: networkLifecycle},
-				&awsmodel.IAMModelBuilder{AWSModelContext: awsModelContext, Lifecycle: &securityLifecycle, Cluster: cluster},
+				&awsmodel.IAMModelBuilder{AWSModelContext: awsModelContext, Lifecycle: securityLifecycle, Cluster: cluster},
-				&awsmodel.OIDCProviderBuilder{AWSModelContext: awsModelContext, Lifecycle: &securityLifecycle, KeyStore: keyStore},
+				&awsmodel.OIDCProviderBuilder{AWSModelContext: awsModelContext, Lifecycle: securityLifecycle, KeyStore: keyStore},
 			)
 
 			awsModelBuilder := &awsmodel.AutoscalingGroupModelBuilder{
 				AWSModelContext:        awsModelContext,
 				BootstrapScriptBuilder: bootstrapScriptBuilder,
-				Lifecycle:              &clusterLifecycle,
+				Lifecycle:              clusterLifecycle,
-				SecurityLifecycle:      &securityLifecycle,
+				SecurityLifecycle:      securityLifecycle,
 				Cluster:                cluster,
 			}
 
@@ -577,8 +577,8 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 				l.Builders = append(l.Builders, &awsmodel.SpotInstanceGroupModelBuilder{
 					AWSModelContext:        awsModelContext,
 					BootstrapScriptBuilder: bootstrapScriptBuilder,
-					Lifecycle:              &clusterLifecycle,
+					Lifecycle:              clusterLifecycle,
-					SecurityLifecycle:      &securityLifecycle,
+					SecurityLifecycle:      securityLifecycle,
 				})
 
 				if featureflag.SpotinstHybrid.Enabled() {
@@ -592,7 +592,7 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 			if nth != nil && fi.BoolValue(nth.Enabled) && fi.BoolValue(nth.EnableSQSTerminationDraining) {
 				l.Builders = append(l.Builders, &awsmodel.NodeTerminationHandlerBuilder{
 					AWSModelContext: awsModelContext,
-					Lifecycle:       &clusterLifecycle,
+					Lifecycle:       clusterLifecycle,
 				})
 			}
 
@@ -601,8 +601,8 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 				KopsModelContext: modelContext,
 			}
 			l.Builders = append(l.Builders,
-				&domodel.APILoadBalancerModelBuilder{DOModelContext: doModelContext, Lifecycle: &securityLifecycle},
+				&domodel.APILoadBalancerModelBuilder{DOModelContext: doModelContext, Lifecycle: securityLifecycle},
-				&domodel.DropletBuilder{DOModelContext: doModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: &clusterLifecycle},
+				&domodel.DropletBuilder{DOModelContext: doModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: clusterLifecycle},
 			)
 		case kops.CloudProviderGCE:
 			gceModelContext := &gcemodel.GCEModelContext{
@@ -617,25 +617,25 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 
 			l.Builders = append(l.Builders,
 
-				&gcemodel.APILoadBalancerBuilder{GCEModelContext: gceModelContext, Lifecycle: &securityLifecycle},
+				&gcemodel.APILoadBalancerBuilder{GCEModelContext: gceModelContext, Lifecycle: securityLifecycle},
-				&gcemodel.ExternalAccessModelBuilder{GCEModelContext: gceModelContext, Lifecycle: &securityLifecycle},
+				&gcemodel.ExternalAccessModelBuilder{GCEModelContext: gceModelContext, Lifecycle: securityLifecycle},
-				&gcemodel.FirewallModelBuilder{GCEModelContext: gceModelContext, Lifecycle: &securityLifecycle},
+				&gcemodel.FirewallModelBuilder{GCEModelContext: gceModelContext, Lifecycle: securityLifecycle},
-				&gcemodel.NetworkModelBuilder{GCEModelContext: gceModelContext, Lifecycle: &networkLifecycle},
+				&gcemodel.NetworkModelBuilder{GCEModelContext: gceModelContext, Lifecycle: networkLifecycle},
-				&gcemodel.StorageAclBuilder{GCEModelContext: gceModelContext, Cloud: cloud.(gce.GCECloud), Lifecycle: &storageACLLifecycle},
+				&gcemodel.StorageAclBuilder{GCEModelContext: gceModelContext, Cloud: cloud.(gce.GCECloud), Lifecycle: storageACLLifecycle},
-				&gcemodel.AutoscalingGroupModelBuilder{GCEModelContext: gceModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: &clusterLifecycle},
+				&gcemodel.AutoscalingGroupModelBuilder{GCEModelContext: gceModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: clusterLifecycle},
 			)
 		case kops.CloudProviderALI:
 			aliModelContext := &alimodel.ALIModelContext{
 				KopsModelContext: modelContext,
 			}
 			l.Builders = append(l.Builders,
-				&alimodel.APILoadBalancerModelBuilder{ALIModelContext: aliModelContext, Lifecycle: &clusterLifecycle},
+				&alimodel.APILoadBalancerModelBuilder{ALIModelContext: aliModelContext, Lifecycle: clusterLifecycle},
-				&alimodel.NetworkModelBuilder{ALIModelContext: aliModelContext, Lifecycle: &clusterLifecycle},
+				&alimodel.NetworkModelBuilder{ALIModelContext: aliModelContext, Lifecycle: clusterLifecycle},
-				&alimodel.RAMModelBuilder{ALIModelContext: aliModelContext, Lifecycle: &clusterLifecycle},
+				&alimodel.RAMModelBuilder{ALIModelContext: aliModelContext, Lifecycle: clusterLifecycle},
-				&alimodel.SSHKeyModelBuilder{ALIModelContext: aliModelContext, Lifecycle: &clusterLifecycle},
+				&alimodel.SSHKeyModelBuilder{ALIModelContext: aliModelContext, Lifecycle: clusterLifecycle},
-				&alimodel.FirewallModelBuilder{ALIModelContext: aliModelContext, Lifecycle: &clusterLifecycle},
+				&alimodel.FirewallModelBuilder{ALIModelContext: aliModelContext, Lifecycle: clusterLifecycle},
-				&alimodel.ExternalAccessModelBuilder{ALIModelContext: aliModelContext, Lifecycle: &clusterLifecycle},
+				&alimodel.ExternalAccessModelBuilder{ALIModelContext: aliModelContext, Lifecycle: clusterLifecycle},
-				&alimodel.ScalingGroupModelBuilder{ALIModelContext: aliModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: &clusterLifecycle},
+				&alimodel.ScalingGroupModelBuilder{ALIModelContext: aliModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: clusterLifecycle},
 			)
 
 		case kops.CloudProviderAzure:
@@ -643,11 +643,11 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 				KopsModelContext: modelContext,
 			}
 			l.Builders = append(l.Builders,
-				&azuremodel.APILoadBalancerModelBuilder{AzureModelContext: azureModelContext, Lifecycle: &clusterLifecycle},
+				&azuremodel.APILoadBalancerModelBuilder{AzureModelContext: azureModelContext, Lifecycle: clusterLifecycle},
-				&azuremodel.NetworkModelBuilder{AzureModelContext: azureModelContext, Lifecycle: &clusterLifecycle},
+				&azuremodel.NetworkModelBuilder{AzureModelContext: azureModelContext, Lifecycle: clusterLifecycle},
-				&azuremodel.ResourceGroupModelBuilder{AzureModelContext: azureModelContext, Lifecycle: &clusterLifecycle},
+				&azuremodel.ResourceGroupModelBuilder{AzureModelContext: azureModelContext, Lifecycle: clusterLifecycle},
 
-				&azuremodel.VMScaleSetModelBuilder{AzureModelContext: azureModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: &clusterLifecycle},
+				&azuremodel.VMScaleSetModelBuilder{AzureModelContext: azureModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: clusterLifecycle},
 			)
 		case kops.CloudProviderOpenstack:
 			openstackModelContext := &openstackmodel.OpenstackModelContext{
@@ -655,17 +655,17 @@ func (c *ApplyClusterCmd) Run(ctx context.Context) error {
 			}
 
 			l.Builders = append(l.Builders,
-				&openstackmodel.NetworkModelBuilder{OpenstackModelContext: openstackModelContext, Lifecycle: &networkLifecycle},
+				&openstackmodel.NetworkModelBuilder{OpenstackModelContext: openstackModelContext, Lifecycle: networkLifecycle},
-				&openstackmodel.SSHKeyModelBuilder{OpenstackModelContext: openstackModelContext, Lifecycle: &securityLifecycle},
+				&openstackmodel.SSHKeyModelBuilder{OpenstackModelContext: openstackModelContext, Lifecycle: securityLifecycle},
-				&openstackmodel.FirewallModelBuilder{OpenstackModelContext: openstackModelContext, Lifecycle: &securityLifecycle},
+				&openstackmodel.FirewallModelBuilder{OpenstackModelContext: openstackModelContext, Lifecycle: securityLifecycle},
-				&openstackmodel.ServerGroupModelBuilder{OpenstackModelContext: openstackModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: &clusterLifecycle},
+				&openstackmodel.ServerGroupModelBuilder{OpenstackModelContext: openstackModelContext, BootstrapScriptBuilder: bootstrapScriptBuilder, Lifecycle: clusterLifecycle},
 			)
 
 		default:
 			return fmt.Errorf("unknown cloudprovider %q", cluster.Spec.CloudProvider)
 		}
 	}
-	c.TaskMap, err = l.BuildTasks(assetBuilder, &stageAssetsLifecycle, c.LifecycleOverrides)
+	c.TaskMap, err = l.BuildTasks(assetBuilder, stageAssetsLifecycle, c.LifecycleOverrides)
 	if err != nil {
 		return fmt.Errorf("error building tasks: %v", err)
 	}

upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go

@@ -42,7 +42,7 @@ type AutoscalingGroup struct {
 	// Name is the name of the ASG
 	Name *string
 	// Lifecycle is the resource lifecycle
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 
 	// Granularity specifys the granularity of the metrics
 	Granularity *string

upup/pkg/fi/cloudup/awstasks/autoscalinggroup_fitask.go

@@ -29,13 +29,13 @@ import (
 var _ fi.HasLifecycle = &AutoscalingGroup{}
 
 // GetLifecycle returns the Lifecycle of the object, implementing fi.HasLifecycle
-func (o *AutoscalingGroup) GetLifecycle() *fi.Lifecycle {
+func (o *AutoscalingGroup) GetLifecycle() fi.Lifecycle {
 	return o.Lifecycle
 }
 
 // SetLifecycle sets the Lifecycle of the object, implementing fi.SetLifecycle
 func (o *AutoscalingGroup) SetLifecycle(lifecycle fi.Lifecycle) {
-	o.Lifecycle = &lifecycle
+	o.Lifecycle = lifecycle
 }
 
 var _ fi.HasName = &AutoscalingGroup{}

upup/pkg/fi/cloudup/awstasks/autoscalinglifecyclehook.go

@@ -32,7 +32,7 @@ import (
 type AutoscalingLifecycleHook struct {
 	ID        *string
 	Name      *string
-	Lifecycle *fi.Lifecycle
+	Lifecycle fi.Lifecycle
 
 	// HookName is the name of the lifecycle hook.
 	// It needs to be unique within the autoscaling group.