kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use dns=none for newly created clusters including for AWS and GCE

This commit is contained in:
Ciprian Hacman 2024-01-19 06:12:08 +02:00
parent a581c1f49c
commit 8af20ba79f
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
upup/pkg/fi/cloudup/new_cluster.go
View File

@ -1418,13 +1418,12 @@ func setupDNSTopology(opt *NewClusterOptions, cluster *api.Cluster) error {
if opt.DNSZone != "" { if opt.DNSZone != "" {
// Use dns=public if zone is specified // Use dns=public if zone is specified
cluster.Spec.Networking.Topology.DNS = api.DNSTypePublic cluster.Spec.Networking.Topology.DNS = api.DNSTypePublic
} else if cluster.UsesLegacyGossip() {
// Use dns=none if .k8s.local is specified instead of Gossip
klog.Warningf("Gossip is deprecated, using None DNS instead")
cluster.Spec.Networking.Topology.DNS = api.DNSTypeNone
} else if cluster.Spec.GetCloudProvider() == api.CloudProviderAWS || cluster.Spec.GetCloudProvider() == api.CloudProviderGCE {
cluster.Spec.Networking.Topology.DNS = api.DNSTypePublic
} else { } else {
if cluster.UsesLegacyGossip() {
// Warn about using dns=none instead of Gossip
klog.Warningf("Gossip is deprecated, using None DNS instead")
}
// Default to dns=none instead of dns=public for all cloud providers
cluster.Spec.Networking.Topology.DNS = api.DNSTypeNone cluster.Spec.Networking.Topology.DNS = api.DNSTypeNone
} }
case "public": case "public":