kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert to 21fafbbd95

This commit is contained in:
Kris Nova 2017-02-21 13:56:18 -07:00
parent 52ba8e82c1
commit 965dd3f987
4 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -140,4 +140,4 @@ We also use the issue tracker to track features. If you have an idea for a featu
- Remember users might be searching for your issue in the future, so please give it a meaningful title to helps others.
- Clearly define the use case, using concrete examples. EG: I type `this` and kops does `that`.
- Some of our larger features will require some design. If you would like to include a technical design for your feature please include it in the issue.
- After the new feature is well understood, and the design agreed upon we can start coding the feature. We would love for you to code it. So please open up a **WIP** *(work in progress)* pull request, and happy coding.
- After the new feature is well understood, and the design agreed upon we can start coding the feature. We would love for you to code it. So please open up a **WIP** *(work in progress)* pull request, and happy coding.

1
cmd/kops/create_cluster.go
View File

@ -158,7 +158,6 @@ func NewCmdCreateCluster(f *util.Factory, out io.Writer) *cobra.Command {
cmd.Flags().StringSliceVar(&options.AdminAccess, "admin-access", options.AdminAccess, "Restrict access to admin endpoints (SSH, HTTPS) to this CIDR. If not set, access will not be restricted by IP.")
// TODO: Can we deprecate this flag - it is awkward?
// @kris-nova: Yes. Yes.
cmd.Flags().BoolVar(&associatePublicIP, "associate-public-ip", false, "Specify --associate-public-ip=[true|false] to enable/disable association of public IP for master ASG and nodes. Default is 'true'.")
cmd.Flags().StringSliceVar(&options.NodeSecurityGroups, "node-security-groups", options.NodeSecurityGroups, "Add precreated additional security groups to nodes.")

1
cmd/kops/integration_test.go
View File

@ -293,7 +293,6 @@ func runTestCloudformation(t *testing.T, clusterName string, srcDir string, vers
if err != nil {
t.Fatalf("unexpected error reading actual cloudformation output: %v", err)
}
expectedCF, err := ioutil.ReadFile(path.Join(srcDir, expectedCfPath))
if err != nil {
t.Fatalf("unexpected error reading expected cloudformation output: %v", err)

2
upup/pkg/fi/README.md
View File

@ -27,4 +27,4 @@ After the resources to the cloud have been deployed, we will now need to provisi
Nodeup runs as a binary **on VMs in the cloud** and will handle bringing up a kubernetes cluster.
The core bits of `nodeup` infrastructure can be found here.
The core bits of `nodeup` infrastructure can be found here.