From 982463683d9c02a5551f7c6baf73b5d98a30fece Mon Sep 17 00:00:00 2001 From: Ole Markus With Date: Fri, 18 Feb 2022 22:21:29 +0100 Subject: [PATCH] Remove checks that doesn't work when we do not delete the node object --- pkg/instancegroups/rollingupdate_test.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/pkg/instancegroups/rollingupdate_test.go b/pkg/instancegroups/rollingupdate_test.go index 6240def010..fe74530385 100644 --- a/pkg/instancegroups/rollingupdate_test.go +++ b/pkg/instancegroups/rollingupdate_test.go @@ -222,17 +222,14 @@ func TestRollingUpdateAllNeedUpdate(t *testing.T) { case testingclient.PatchAction: if string(a.GetPatch()) == cordonPatch { assertCordon(t, a) - assert.Equal(t, "", cordoned, "at most one node cordoned at a time") assert.True(t, tainted[a.GetName()], "node", a.GetName(), "tainted") cordoned = a.GetName() } else if string(a.GetPatch()) == excludeLBPatch { assertExclude(t, a) - assert.Equal(t, "", excluded, "at most one node excluded at a time") assert.True(t, tainted[a.GetName()], "node", a.GetName(), "tainted") excluded = a.GetName() } else { assertTaint(t, a) - assert.Equal(t, "", cordoned, "not tainting while node cordoned") assert.False(t, tainted[a.GetName()], "node", a.GetName(), "already tainted") tainted[a.GetName()] = true } @@ -811,11 +808,9 @@ func TestRollingUpdateTaintAllButOneNeedUpdate(t *testing.T) { case testingclient.PatchAction: if string(a.GetPatch()) == cordonPatch { assertCordon(t, a) - assert.Equal(t, "", cordoned, "at most one node cordoned at a time") cordoned = a.GetName() } else if string(a.GetPatch()) == excludeLBPatch { assertExclude(t, a) - assert.Equal(t, "", excluded, "at most one node excluded at a time") excluded = a.GetName() } else { assertTaint(t, a) @@ -863,12 +858,10 @@ func TestRollingUpdateMaxSurgeIgnoredForMaster(t *testing.T) { case testingclient.PatchAction: if string(a.GetPatch()) == cordonPatch { assertCordon(t, a) - assert.Equal(t, "", cordoned, "at most one node cordoned at a time") assert.True(t, tainted[a.GetName()], "node", a.GetName(), "tainted") cordoned = a.GetName() } else if string(a.GetPatch()) == excludeLBPatch { assertExclude(t, a) - assert.Equal(t, "", excluded, "at most one node excluded at a time") assert.True(t, tainted[a.GetName()], "node", a.GetName(), "tainted") excluded = a.GetName() } else {