From 99192542055bb08a900e9ca1c7738f14e0e87ba2 Mon Sep 17 00:00:00 2001 From: Justin Santa Barbara Date: Thu, 25 Jan 2018 08:34:12 -0500 Subject: [PATCH] AWS LaunchConfiguration error handling fix We would loop forever on an unexpected error. --- upup/pkg/fi/cloudup/awstasks/launchconfiguration.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/upup/pkg/fi/cloudup/awstasks/launchconfiguration.go b/upup/pkg/fi/cloudup/awstasks/launchconfiguration.go index 2a43407e01..f41dd83104 100644 --- a/upup/pkg/fi/cloudup/awstasks/launchconfiguration.go +++ b/upup/pkg/fi/cloudup/awstasks/launchconfiguration.go @@ -317,8 +317,9 @@ func (_ *LaunchConfiguration) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *La maxAttempts := 10 for { attempt++ - _, err = t.Cloud.Autoscaling().CreateLaunchConfiguration(request) + glog.V(8).Infof("AWS CreateLaunchConfiguration %s", aws.StringValue(request.LaunchConfigurationName)) + _, err = t.Cloud.Autoscaling().CreateLaunchConfiguration(request) if err == nil { break } @@ -335,8 +336,9 @@ func (_ *LaunchConfiguration) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *La continue } glog.V(4).Infof("ErrorCode=%q, Message=%q", awsup.AWSErrorCode(err), awsup.AWSErrorMessage(err)) - return fmt.Errorf("error creating AutoscalingLaunchConfiguration: %v", err) } + + return fmt.Errorf("error creating AutoscalingLaunchConfiguration: %v", err) } e.ID = fi.String(launchConfigurationName)