kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Log detailed reasons when we can't match an instance type

This commit is contained in:
justinsb 2023-03-28 09:18:01 -04:00
parent 73a7144d50
commit 9964bb8d01
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
upup/pkg/fi/cloudup/awsup/aws_cloud.go
View File

@ -2317,13 +2317,16 @@ func (c *awsCloudImplementation) DefaultInstanceType(cluster *kops.Cluster, ig *
igZonesSet := sets.NewString(igZones...) igZonesSet := sets.NewString(igZones...)
// TODO: Validate that instance type exists in all AZs, but skip AZs that don't support any VPC stuff // TODO: Validate that instance type exists in all AZs, but skip AZs that don't support any VPC stuff
var reasons []string
for _, instanceType := range candidates { for _, instanceType := range candidates {
if strings.HasPrefix(instanceType, "t4g") { if strings.HasPrefix(instanceType, "t4g") {
if imageArch != "arm64" { if imageArch != "arm64" {
reasons = append(reasons, fmt.Sprintf("instance type %q does not match image architecture %q", instanceType, imageArch))
continue continue
} }
} else { } else {
if imageArch == "arm64" { if imageArch == "arm64" {
reasons = append(reasons, fmt.Sprintf("instance type %q does not match image architecture %q", instanceType, imageArch))
continue continue
} }
} }
@ -2335,10 +2338,16 @@ func (c *awsCloudImplementation) DefaultInstanceType(cluster *kops.Cluster, ig *
if zones.IsSuperset(igZonesSet) { if zones.IsSuperset(igZonesSet) {
return instanceType, nil return instanceType, nil
} else { } else {
reasons = append(reasons, fmt.Sprintf("instance type %q is not available in all zones (available in zones %v, need %v)", instanceType, zones, igZones))
klog.V(2).Infof("can't use instance type %q, available in zones %v but need %v", instanceType, zones, igZones) klog.V(2).Infof("can't use instance type %q, available in zones %v but need %v", instanceType, zones, igZones)
} }
} }
// Log the detailed reasons why we can't find an instance type
klog.Warning("cannot find suitable instance type")
for _, reason := range reasons {
klog.Warning(" * " + reason)
}
return "", fmt.Errorf("could not find a suitable supported instance type for the instance group %q (type %q) in region %q", ig.Name, ig.Spec.Role, c.region) return "", fmt.Errorf("could not find a suitable supported instance type for the instance group %q (type %q) in region %q", ig.Name, ig.Spec.Role, c.region)
} }