From 9982efd8e3768d3f761658f16223ec6d3a9b55fb Mon Sep 17 00:00:00 2001 From: John Gardiner Myers Date: Sun, 11 Dec 2022 16:53:37 -0800 Subject: [PATCH] hack/update-expected.sh --- ...mple.com-RebalanceRecommendation_event_pattern | 1 - .../many-addons-ccm-irsa/kubernetes.tf | 15 --------------- ...mple.com-RebalanceRecommendation_event_pattern | 1 - .../many-addons-ccm-irsa23/kubernetes.tf | 15 --------------- ...mple.com-RebalanceRecommendation_event_pattern | 1 - .../many-addons-ccm-irsa24/kubernetes.tf | 15 --------------- ...mple.com-RebalanceRecommendation_event_pattern | 1 - .../many-addons-ccm-irsa25/kubernetes.tf | 15 --------------- ...mple.com-RebalanceRecommendation_event_pattern | 1 - .../many-addons-ccm-irsa26/kubernetes.tf | 15 --------------- .../aws_s3_object_cluster-completed.spec_content | 2 +- ...t_minimal.example.com-addons-bootstrap_content | 2 +- ...-node-termination-handler.aws-k8s-1.11_content | 2 +- ...mple.com-RebalanceRecommendation_event_pattern | 1 - .../update_cluster/many-addons/kubernetes.tf | 15 --------------- 15 files changed, 3 insertions(+), 99 deletions(-) delete mode 100644 tests/integration/update_cluster/many-addons-ccm-irsa/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern delete mode 100644 tests/integration/update_cluster/many-addons-ccm-irsa23/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern delete mode 100644 tests/integration/update_cluster/many-addons-ccm-irsa24/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern delete mode 100644 tests/integration/update_cluster/many-addons-ccm-irsa25/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern delete mode 100644 tests/integration/update_cluster/many-addons-ccm-irsa26/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern delete mode 100644 tests/integration/update_cluster/many-addons/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern b/tests/integration/update_cluster/many-addons-ccm-irsa/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern deleted file mode 100644 index 226b0ac52d..0000000000 --- a/tests/integration/update_cluster/many-addons-ccm-irsa/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern +++ /dev/null @@ -1 +0,0 @@ -{"source": ["aws.ec2"],"detail-type": ["EC2 Instance Rebalance Recommendation"]} diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa/kubernetes.tf b/tests/integration/update_cluster/many-addons-ccm-irsa/kubernetes.tf index c882c8904d..d3ffaebb99 100644 --- a/tests/integration/update_cluster/many-addons-ccm-irsa/kubernetes.tf +++ b/tests/integration/update_cluster/many-addons-ccm-irsa/kubernetes.tf @@ -341,16 +341,6 @@ resource "aws_cloudwatch_event_rule" "minimal-example-com-InstanceStateChange" { } } -resource "aws_cloudwatch_event_rule" "minimal-example-com-RebalanceRecommendation" { - event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern") - name = "minimal.example.com-RebalanceRecommendation" - tags = { - "KubernetesCluster" = "minimal.example.com" - "Name" = "minimal.example.com-RebalanceRecommendation" - "kubernetes.io/cluster/minimal.example.com" = "owned" - } -} - resource "aws_cloudwatch_event_rule" "minimal-example-com-SpotInterruption" { event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-SpotInterruption_event_pattern") name = "minimal.example.com-SpotInterruption" @@ -376,11 +366,6 @@ resource "aws_cloudwatch_event_target" "minimal-example-com-InstanceStateChange- rule = aws_cloudwatch_event_rule.minimal-example-com-InstanceStateChange.id } -resource "aws_cloudwatch_event_target" "minimal-example-com-RebalanceRecommendation-Target" { - arn = aws_sqs_queue.minimal-example-com-nth.arn - rule = aws_cloudwatch_event_rule.minimal-example-com-RebalanceRecommendation.id -} - resource "aws_cloudwatch_event_target" "minimal-example-com-SpotInterruption-Target" { arn = aws_sqs_queue.minimal-example-com-nth.arn rule = aws_cloudwatch_event_rule.minimal-example-com-SpotInterruption.id diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa23/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern b/tests/integration/update_cluster/many-addons-ccm-irsa23/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern deleted file mode 100644 index 226b0ac52d..0000000000 --- a/tests/integration/update_cluster/many-addons-ccm-irsa23/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern +++ /dev/null @@ -1 +0,0 @@ -{"source": ["aws.ec2"],"detail-type": ["EC2 Instance Rebalance Recommendation"]} diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa23/kubernetes.tf b/tests/integration/update_cluster/many-addons-ccm-irsa23/kubernetes.tf index 3fc6f46802..afcf721bd8 100644 --- a/tests/integration/update_cluster/many-addons-ccm-irsa23/kubernetes.tf +++ b/tests/integration/update_cluster/many-addons-ccm-irsa23/kubernetes.tf @@ -341,16 +341,6 @@ resource "aws_cloudwatch_event_rule" "minimal-example-com-InstanceStateChange" { } } -resource "aws_cloudwatch_event_rule" "minimal-example-com-RebalanceRecommendation" { - event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern") - name = "minimal.example.com-RebalanceRecommendation" - tags = { - "KubernetesCluster" = "minimal.example.com" - "Name" = "minimal.example.com-RebalanceRecommendation" - "kubernetes.io/cluster/minimal.example.com" = "owned" - } -} - resource "aws_cloudwatch_event_rule" "minimal-example-com-SpotInterruption" { event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-SpotInterruption_event_pattern") name = "minimal.example.com-SpotInterruption" @@ -376,11 +366,6 @@ resource "aws_cloudwatch_event_target" "minimal-example-com-InstanceStateChange- rule = aws_cloudwatch_event_rule.minimal-example-com-InstanceStateChange.id } -resource "aws_cloudwatch_event_target" "minimal-example-com-RebalanceRecommendation-Target" { - arn = aws_sqs_queue.minimal-example-com-nth.arn - rule = aws_cloudwatch_event_rule.minimal-example-com-RebalanceRecommendation.id -} - resource "aws_cloudwatch_event_target" "minimal-example-com-SpotInterruption-Target" { arn = aws_sqs_queue.minimal-example-com-nth.arn rule = aws_cloudwatch_event_rule.minimal-example-com-SpotInterruption.id diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa24/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern b/tests/integration/update_cluster/many-addons-ccm-irsa24/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern deleted file mode 100644 index 226b0ac52d..0000000000 --- a/tests/integration/update_cluster/many-addons-ccm-irsa24/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern +++ /dev/null @@ -1 +0,0 @@ -{"source": ["aws.ec2"],"detail-type": ["EC2 Instance Rebalance Recommendation"]} diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa24/kubernetes.tf b/tests/integration/update_cluster/many-addons-ccm-irsa24/kubernetes.tf index 2c89ac12f1..7c7d3de77f 100644 --- a/tests/integration/update_cluster/many-addons-ccm-irsa24/kubernetes.tf +++ b/tests/integration/update_cluster/many-addons-ccm-irsa24/kubernetes.tf @@ -326,16 +326,6 @@ resource "aws_cloudwatch_event_rule" "minimal-example-com-InstanceStateChange" { } } -resource "aws_cloudwatch_event_rule" "minimal-example-com-RebalanceRecommendation" { - event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern") - name = "minimal.example.com-RebalanceRecommendation" - tags = { - "KubernetesCluster" = "minimal.example.com" - "Name" = "minimal.example.com-RebalanceRecommendation" - "kubernetes.io/cluster/minimal.example.com" = "owned" - } -} - resource "aws_cloudwatch_event_rule" "minimal-example-com-SpotInterruption" { event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-SpotInterruption_event_pattern") name = "minimal.example.com-SpotInterruption" @@ -361,11 +351,6 @@ resource "aws_cloudwatch_event_target" "minimal-example-com-InstanceStateChange- rule = aws_cloudwatch_event_rule.minimal-example-com-InstanceStateChange.id } -resource "aws_cloudwatch_event_target" "minimal-example-com-RebalanceRecommendation-Target" { - arn = aws_sqs_queue.minimal-example-com-nth.arn - rule = aws_cloudwatch_event_rule.minimal-example-com-RebalanceRecommendation.id -} - resource "aws_cloudwatch_event_target" "minimal-example-com-SpotInterruption-Target" { arn = aws_sqs_queue.minimal-example-com-nth.arn rule = aws_cloudwatch_event_rule.minimal-example-com-SpotInterruption.id diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa25/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern b/tests/integration/update_cluster/many-addons-ccm-irsa25/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern deleted file mode 100644 index 226b0ac52d..0000000000 --- a/tests/integration/update_cluster/many-addons-ccm-irsa25/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern +++ /dev/null @@ -1 +0,0 @@ -{"source": ["aws.ec2"],"detail-type": ["EC2 Instance Rebalance Recommendation"]} diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa25/kubernetes.tf b/tests/integration/update_cluster/many-addons-ccm-irsa25/kubernetes.tf index 2c89ac12f1..7c7d3de77f 100644 --- a/tests/integration/update_cluster/many-addons-ccm-irsa25/kubernetes.tf +++ b/tests/integration/update_cluster/many-addons-ccm-irsa25/kubernetes.tf @@ -326,16 +326,6 @@ resource "aws_cloudwatch_event_rule" "minimal-example-com-InstanceStateChange" { } } -resource "aws_cloudwatch_event_rule" "minimal-example-com-RebalanceRecommendation" { - event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern") - name = "minimal.example.com-RebalanceRecommendation" - tags = { - "KubernetesCluster" = "minimal.example.com" - "Name" = "minimal.example.com-RebalanceRecommendation" - "kubernetes.io/cluster/minimal.example.com" = "owned" - } -} - resource "aws_cloudwatch_event_rule" "minimal-example-com-SpotInterruption" { event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-SpotInterruption_event_pattern") name = "minimal.example.com-SpotInterruption" @@ -361,11 +351,6 @@ resource "aws_cloudwatch_event_target" "minimal-example-com-InstanceStateChange- rule = aws_cloudwatch_event_rule.minimal-example-com-InstanceStateChange.id } -resource "aws_cloudwatch_event_target" "minimal-example-com-RebalanceRecommendation-Target" { - arn = aws_sqs_queue.minimal-example-com-nth.arn - rule = aws_cloudwatch_event_rule.minimal-example-com-RebalanceRecommendation.id -} - resource "aws_cloudwatch_event_target" "minimal-example-com-SpotInterruption-Target" { arn = aws_sqs_queue.minimal-example-com-nth.arn rule = aws_cloudwatch_event_rule.minimal-example-com-SpotInterruption.id diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa26/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern b/tests/integration/update_cluster/many-addons-ccm-irsa26/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern deleted file mode 100644 index 226b0ac52d..0000000000 --- a/tests/integration/update_cluster/many-addons-ccm-irsa26/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern +++ /dev/null @@ -1 +0,0 @@ -{"source": ["aws.ec2"],"detail-type": ["EC2 Instance Rebalance Recommendation"]} diff --git a/tests/integration/update_cluster/many-addons-ccm-irsa26/kubernetes.tf b/tests/integration/update_cluster/many-addons-ccm-irsa26/kubernetes.tf index 2299556d7f..a0812f3d81 100644 --- a/tests/integration/update_cluster/many-addons-ccm-irsa26/kubernetes.tf +++ b/tests/integration/update_cluster/many-addons-ccm-irsa26/kubernetes.tf @@ -326,16 +326,6 @@ resource "aws_cloudwatch_event_rule" "minimal-example-com-InstanceStateChange" { } } -resource "aws_cloudwatch_event_rule" "minimal-example-com-RebalanceRecommendation" { - event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern") - name = "minimal.example.com-RebalanceRecommendation" - tags = { - "KubernetesCluster" = "minimal.example.com" - "Name" = "minimal.example.com-RebalanceRecommendation" - "kubernetes.io/cluster/minimal.example.com" = "owned" - } -} - resource "aws_cloudwatch_event_rule" "minimal-example-com-SpotInterruption" { event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-SpotInterruption_event_pattern") name = "minimal.example.com-SpotInterruption" @@ -361,11 +351,6 @@ resource "aws_cloudwatch_event_target" "minimal-example-com-InstanceStateChange- rule = aws_cloudwatch_event_rule.minimal-example-com-InstanceStateChange.id } -resource "aws_cloudwatch_event_target" "minimal-example-com-RebalanceRecommendation-Target" { - arn = aws_sqs_queue.minimal-example-com-nth.arn - rule = aws_cloudwatch_event_rule.minimal-example-com-RebalanceRecommendation.id -} - resource "aws_cloudwatch_event_target" "minimal-example-com-SpotInterruption-Target" { arn = aws_sqs_queue.minimal-example-com-nth.arn rule = aws_cloudwatch_event_rule.minimal-example-com-SpotInterruption.id diff --git a/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_cluster-completed.spec_content b/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_cluster-completed.spec_content index 0eb3b3f7f3..cb78e2705a 100644 --- a/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_cluster-completed.spec_content +++ b/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_cluster-completed.spec_content @@ -210,7 +210,7 @@ spec: amazonvpc: {} nodeTerminationHandler: cpuRequest: 50m - enableRebalanceDraining: false + enableRebalanceDraining: true enableRebalanceMonitoring: false enableScheduledEventDraining: true enableSpotInterruptionDraining: true diff --git a/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-bootstrap_content b/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-bootstrap_content index aadec008fa..8f2bdf5160 100644 --- a/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-bootstrap_content +++ b/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-bootstrap_content @@ -62,7 +62,7 @@ spec: version: 9.99.0 - id: k8s-1.11 manifest: node-termination-handler.aws/k8s-1.11.yaml - manifestHash: 031dd270cecb6247a363cebba3efb61ebb940315373f929a9ba2aee8e249ddfd + manifestHash: 7cd05c5a73220c7db013f0c2e6322b23c989affed13804a221e98b82c11a60c6 name: node-termination-handler.aws prune: kinds: diff --git a/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-node-termination-handler.aws-k8s-1.11_content b/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-node-termination-handler.aws-k8s-1.11_content index 060d1c6928..79d0a6adae 100644 --- a/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-node-termination-handler.aws-k8s-1.11_content +++ b/tests/integration/update_cluster/many-addons-ccm/data/aws_s3_object_minimal.example.com-addons-node-termination-handler.aws-k8s-1.11_content @@ -206,7 +206,7 @@ spec: - name: ENABLE_REBALANCE_MONITORING value: "false" - name: ENABLE_REBALANCE_DRAINING - value: "false" + value: "true" - name: ENABLE_SQS_TERMINATION_DRAINING value: "true" - name: QUEUE_URL diff --git a/tests/integration/update_cluster/many-addons/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern b/tests/integration/update_cluster/many-addons/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern deleted file mode 100644 index 226b0ac52d..0000000000 --- a/tests/integration/update_cluster/many-addons/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern +++ /dev/null @@ -1 +0,0 @@ -{"source": ["aws.ec2"],"detail-type": ["EC2 Instance Rebalance Recommendation"]} diff --git a/tests/integration/update_cluster/many-addons/kubernetes.tf b/tests/integration/update_cluster/many-addons/kubernetes.tf index d21bedc13b..d61ce0673d 100644 --- a/tests/integration/update_cluster/many-addons/kubernetes.tf +++ b/tests/integration/update_cluster/many-addons/kubernetes.tf @@ -271,16 +271,6 @@ resource "aws_cloudwatch_event_rule" "minimal-example-com-InstanceStateChange" { } } -resource "aws_cloudwatch_event_rule" "minimal-example-com-RebalanceRecommendation" { - event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-RebalanceRecommendation_event_pattern") - name = "minimal.example.com-RebalanceRecommendation" - tags = { - "KubernetesCluster" = "minimal.example.com" - "Name" = "minimal.example.com-RebalanceRecommendation" - "kubernetes.io/cluster/minimal.example.com" = "owned" - } -} - resource "aws_cloudwatch_event_rule" "minimal-example-com-SpotInterruption" { event_pattern = file("${path.module}/data/aws_cloudwatch_event_rule_minimal.example.com-SpotInterruption_event_pattern") name = "minimal.example.com-SpotInterruption" @@ -306,11 +296,6 @@ resource "aws_cloudwatch_event_target" "minimal-example-com-InstanceStateChange- rule = aws_cloudwatch_event_rule.minimal-example-com-InstanceStateChange.id } -resource "aws_cloudwatch_event_target" "minimal-example-com-RebalanceRecommendation-Target" { - arn = aws_sqs_queue.minimal-example-com-nth.arn - rule = aws_cloudwatch_event_rule.minimal-example-com-RebalanceRecommendation.id -} - resource "aws_cloudwatch_event_target" "minimal-example-com-SpotInterruption-Target" { arn = aws_sqs_queue.minimal-example-com-nth.arn rule = aws_cloudwatch_event_rule.minimal-example-com-SpotInterruption.id