From 99d9f94ceb5a32fa27297bb92846a5860a48c043 Mon Sep 17 00:00:00 2001 From: Danil Zhigalin Date: Fri, 13 May 2022 10:05:52 +0200 Subject: [PATCH] Fix code block in manageStorageClasses docs When posting the initial PR I didn't build the docs and didn't realise that code block was not closed. Fixing it now. --- docs/cluster_spec.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/cluster_spec.md b/docs/cluster_spec.md index 4a40997836..e57573ef2d 100644 --- a/docs/cluster_spec.md +++ b/docs/cluster_spec.md @@ -1132,7 +1132,7 @@ spec: {{ kops_feature_table(kops_added_default='1.20') }} -By default kops will create `StorageClass` resources with some opinionated settings specific to cloud provider on which the cluster is installed. One of those storage classes will be defined as default applying the annotation `storageclass.kubernetes.io/is-default-class: "true"`. This may not always be a desirable behaviour and some cluster admins rather prefer to have more control of storage classes and manage them outside of kops. When set to `false`, kOps will no longer create any `StorageClass` objects. Any such objects that kOps created in the past are left as is, and kOps and will no longer reconcile them against future changes. +By default kops will create `StorageClass` resources with some opinionated settings specific to cloud provider on which the cluster is installed. One of those storage classes will be defined as default applying the annotation `storageclass.kubernetes.io/is-default-class: "true"`. This may not always be a desirable behaviour and some cluster admins rather prefer to have more control of storage classes and manage them outside of kops. When set to `false`, kOps will no longer create any `StorageClass` objects. Any such objects that kOps created in the past are left as is, and kOps will no longer reconcile them against future changes. The existing `spec.cloudConfig.openstack.blockStorage.createStorageClass` field remains in place. However, if both that and the new `spec.cloudConfig.manageStorageClasses` field are populated, they must agree: It is invalid both to disable management of `StorageClass` objects globally but to enable them for OpenStack and, conversely, to enable management globally but disable it for OpenStack. @@ -1140,6 +1140,7 @@ The existing `spec.cloudConfig.openstack.blockStorage.createStorageClass` field spec: cloudConfig: manageStorageClasses: false +``` ## containerRuntime {{ kops_feature_table(kops_added_default='1.18', k8s_min='1.11') }}