kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
This commit is contained in:
Ole Markus With 2021-08-27 06:36:02 +02:00 committed by Ole Markus With
parent 67b1ace14f
commit b3982e1033
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/apis/kops/validation/validation.go
View File

@ -1480,7 +1480,7 @@ func validateExternalDNS(cluster *kops.Cluster, spec *kops.ExternalDNSConfig, fl
if spec.Provider == kops.ExternalDNSProviderExternalDNS {
if dns.IsGossipHostname(cluster.Spec.MasterInternalName) {
allErrs = append(allErrs, field.Forbidden(fldPath.Child("provider"), "external-dns does not supprot gossip clusters"))
allErrs = append(allErrs, field.Forbidden(fldPath.Child("provider"), "external-dns does not support gossip clusters"))
}
}

1
pkg/model/components/addonmanifests/BUILD.bazel generated
View File

@ -15,6 +15,7 @@ go_library(
"//pkg/model/components/addonmanifests/awsloadbalancercontroller:go_default_library",
"//pkg/model/components/addonmanifests/clusterautoscaler:go_default_library",
"//pkg/model/components/addonmanifests/dnscontroller:go_default_library",
"//pkg/model/components/addonmanifests/externaldns:go_default_library",
"//pkg/model/components/addonmanifests/nodeterminationhandler:go_default_library",
"//pkg/model/iam:go_default_library",
"//upup/pkg/fi:go_default_library",

3
pkg/model/components/addonmanifests/remap.go
View File

@ -32,6 +32,7 @@ import (
"k8s.io/kops/pkg/model/components/addonmanifests/awsloadbalancercontroller"
"k8s.io/kops/pkg/model/components/addonmanifests/clusterautoscaler"
"k8s.io/kops/pkg/model/components/addonmanifests/dnscontroller"
"k8s.io/kops/pkg/model/components/addonmanifests/externaldns"
"k8s.io/kops/pkg/model/components/addonmanifests/nodeterminationhandler"
"k8s.io/kops/pkg/model/iam"
"k8s.io/kops/upup/pkg/fi"
@ -126,7 +127,7 @@ func getWellknownServiceAccount(name string) iam.Subject {
case "aws-cloud-controller-manager":
return &awscloudcontrollermanager.ServiceAccount{}
case "external-dns":
return &awsebscsidriver.ServiceAccount{}
return &externaldns.ServiceAccount{}
default:
return nil
}