From b3982e1033d37f59fb6997ec522d304ab22c1650 Mon Sep 17 00:00:00 2001 From: Ole Markus With Date: Fri, 27 Aug 2021 06:36:02 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Peter Rifel --- pkg/apis/kops/validation/validation.go | 2 +- pkg/model/components/addonmanifests/BUILD.bazel | 1 + pkg/model/components/addonmanifests/remap.go | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/apis/kops/validation/validation.go b/pkg/apis/kops/validation/validation.go index 16c7f3b878..129003dadb 100644 --- a/pkg/apis/kops/validation/validation.go +++ b/pkg/apis/kops/validation/validation.go @@ -1480,7 +1480,7 @@ func validateExternalDNS(cluster *kops.Cluster, spec *kops.ExternalDNSConfig, fl if spec.Provider == kops.ExternalDNSProviderExternalDNS { if dns.IsGossipHostname(cluster.Spec.MasterInternalName) { - allErrs = append(allErrs, field.Forbidden(fldPath.Child("provider"), "external-dns does not supprot gossip clusters")) + allErrs = append(allErrs, field.Forbidden(fldPath.Child("provider"), "external-dns does not support gossip clusters")) } } diff --git a/pkg/model/components/addonmanifests/BUILD.bazel b/pkg/model/components/addonmanifests/BUILD.bazel index eb6effff92..0cb15d50b9 100644 --- a/pkg/model/components/addonmanifests/BUILD.bazel +++ b/pkg/model/components/addonmanifests/BUILD.bazel @@ -15,6 +15,7 @@ go_library( "//pkg/model/components/addonmanifests/awsloadbalancercontroller:go_default_library", "//pkg/model/components/addonmanifests/clusterautoscaler:go_default_library", "//pkg/model/components/addonmanifests/dnscontroller:go_default_library", + "//pkg/model/components/addonmanifests/externaldns:go_default_library", "//pkg/model/components/addonmanifests/nodeterminationhandler:go_default_library", "//pkg/model/iam:go_default_library", "//upup/pkg/fi:go_default_library", diff --git a/pkg/model/components/addonmanifests/remap.go b/pkg/model/components/addonmanifests/remap.go index 6efbf9ff5b..b69382083a 100644 --- a/pkg/model/components/addonmanifests/remap.go +++ b/pkg/model/components/addonmanifests/remap.go @@ -32,6 +32,7 @@ import ( "k8s.io/kops/pkg/model/components/addonmanifests/awsloadbalancercontroller" "k8s.io/kops/pkg/model/components/addonmanifests/clusterautoscaler" "k8s.io/kops/pkg/model/components/addonmanifests/dnscontroller" + "k8s.io/kops/pkg/model/components/addonmanifests/externaldns" "k8s.io/kops/pkg/model/components/addonmanifests/nodeterminationhandler" "k8s.io/kops/pkg/model/iam" "k8s.io/kops/upup/pkg/fi" @@ -126,7 +127,7 @@ func getWellknownServiceAccount(name string) iam.Subject { case "aws-cloud-controller-manager": return &awscloudcontrollermanager.ServiceAccount{} case "external-dns": - return &awsebscsidriver.ServiceAccount{} + return &externaldns.ServiceAccount{} default: return nil }