kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16902 from justinsb/fix_method_matching_render 

chore: fix method-matching on Render method
This commit is contained in:
Kubernetes Prow Robot 2024-10-13 19:44:20 +01:00 committed by GitHub
parent 3e49cc6217 ef219c3c35
commit b44e9ab488
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
upup/pkg/fi/context.go
View File

@ -209,14 +209,14 @@ func (c *Context[T]) Render(a, e, changes Task[T]) error {
var args []reflect.Value var args []reflect.Value
for j := 0; j < method.Type.NumIn(); j++ { for j := 0; j < method.Type.NumIn(); j++ {
arg := method.Type.In(j) arg := method.Type.In(j)
if arg.ConvertibleTo(vType) { if vType.ConvertibleTo(arg) {
continue continue
} }
if arg.ConvertibleTo(typeContextPtr) { if typeContextPtr.ConvertibleTo(arg) {
args = append(args, reflect.ValueOf(c)) args = append(args, reflect.ValueOf(c))
continue continue
} }
if arg.ConvertibleTo(targetType) { if targetType.ConvertibleTo(arg) {
args = append(args, reflect.ValueOf(c.Target)) args = append(args, reflect.ValueOf(c.Target))
continue continue
} }