From a39e3f9043c34ff5ce4a11c1f6b2f89448b62f0d Mon Sep 17 00:00:00 2001 From: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com> Date: Sat, 18 Nov 2023 15:48:35 +0530 Subject: [PATCH 1/2] Improve kops edit cluster Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com> --- cmd/kops/edit_cluster.go | 3 +++ docs/cli/kops_edit_cluster.md | 3 +++ 2 files changed, 6 insertions(+) diff --git a/cmd/kops/edit_cluster.go b/cmd/kops/edit_cluster.go index 09f1518ea0..2def488614 100644 --- a/cmd/kops/edit_cluster.go +++ b/cmd/kops/edit_cluster.go @@ -66,6 +66,9 @@ var ( editClusterExample = templates.Examples(i18n.T(` # Edit a cluster configuration in AWS. kops edit cluster k8s.cluster.site --state=s3://my-state-store + + # Set Values in the spec. + kops edit cluster testcluster.k8s.local --set spec.kubernetesVersion=1.28.4 `)) ) diff --git a/docs/cli/kops_edit_cluster.md b/docs/cli/kops_edit_cluster.md index d62c71865f..1db5498b35 100644 --- a/docs/cli/kops_edit_cluster.md +++ b/docs/cli/kops_edit_cluster.md @@ -25,6 +25,9 @@ kops edit cluster [CLUSTER] [flags] ``` # Edit a cluster configuration in AWS. kops edit cluster k8s.cluster.site --state=s3://my-state-store + + # Set Values in the spec. + kops edit cluster testcluster.k8s.local --set spec.kubernetesVersion=1.28.4 ``` ### Options From 464975c53d6adc932b585fac0562fa1d686edab2 Mon Sep 17 00:00:00 2001 From: Ciprian Hacman Date: Thu, 23 Nov 2023 19:18:10 +0200 Subject: [PATCH 2/2] Apply suggestions from code review --- cmd/kops/edit_cluster.go | 2 +- docs/cli/kops_edit_cluster.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/kops/edit_cluster.go b/cmd/kops/edit_cluster.go index 2def488614..f3d906bd4c 100644 --- a/cmd/kops/edit_cluster.go +++ b/cmd/kops/edit_cluster.go @@ -67,7 +67,7 @@ var ( # Edit a cluster configuration in AWS. kops edit cluster k8s.cluster.site --state=s3://my-state-store - # Set Values in the spec. + # Set cluster spec values. kops edit cluster testcluster.k8s.local --set spec.kubernetesVersion=1.28.4 `)) ) diff --git a/docs/cli/kops_edit_cluster.md b/docs/cli/kops_edit_cluster.md index 1db5498b35..06f5e25289 100644 --- a/docs/cli/kops_edit_cluster.md +++ b/docs/cli/kops_edit_cluster.md @@ -26,7 +26,7 @@ kops edit cluster [CLUSTER] [flags] # Edit a cluster configuration in AWS. kops edit cluster k8s.cluster.site --state=s3://my-state-store - # Set Values in the spec. + # Set cluster spec values. kops edit cluster testcluster.k8s.local --set spec.kubernetesVersion=1.28.4 ```