Only apply dns changes if records were removed

This commit is contained in:
andrewsykim 2017-03-28 17:02:14 -04:00
parent 91cde08513
commit b68815e930
1 changed files with 4 additions and 1 deletions

View File

@ -787,7 +787,6 @@ func (d *clusterDiscoveryGCE) deleteDNSZone(cloud fi.Cloud, r *ResourceTracker)
}
changeset := rrs.StartChangeset()
for _, record := range records {
if record.Type() != "A" {
continue
@ -812,6 +811,10 @@ func (d *clusterDiscoveryGCE) deleteDNSZone(cloud fi.Cloud, r *ResourceTracker)
changeset.Remove(record)
}
if changeset.IsEmpty() {
return nil
}
err = changeset.Apply()
if err != nil {
return fmt.Errorf("Error deleting cloud dns records: %v", err)