kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only apply dns changes if records were removed

This commit is contained in:
andrewsykim 2017-03-28 17:02:14 -04:00
parent 91cde08513
commit b68815e930
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
upup/pkg/kutil/delete_cluster_gce.go
View File

@ -787,7 +787,6 @@ func (d *clusterDiscoveryGCE) deleteDNSZone(cloud fi.Cloud, r *ResourceTracker)
} }
changeset := rrs.StartChangeset() changeset := rrs.StartChangeset()
for _, record := range records { for _, record := range records {
if record.Type() != "A" { if record.Type() != "A" {
continue continue
@ -812,6 +811,10 @@ func (d *clusterDiscoveryGCE) deleteDNSZone(cloud fi.Cloud, r *ResourceTracker)
changeset.Remove(record) changeset.Remove(record)
} }
if changeset.IsEmpty() {
return nil
}
err = changeset.Apply() err = changeset.Apply()
if err != nil { if err != nil {
return fmt.Errorf("Error deleting cloud dns records: %v", err) return fmt.Errorf("Error deleting cloud dns records: %v", err)