From c6eca9db817b69a3e3111b920f8c129b72d0fcea Mon Sep 17 00:00:00 2001 From: Alexander Block Date: Wed, 10 Feb 2021 08:21:22 +0100 Subject: [PATCH] Fix check for empty privateIPv4Address --- pkg/model/awsmodel/api_loadbalancer.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/model/awsmodel/api_loadbalancer.go b/pkg/model/awsmodel/api_loadbalancer.go index 61c672b085..7d86fd30c3 100644 --- a/pkg/model/awsmodel/api_loadbalancer.go +++ b/pkg/model/awsmodel/api_loadbalancer.go @@ -78,8 +78,8 @@ func (b *APILoadBalancerBuilder) Build(c *fi.ModelBuilderContext) error { Subnet: elbSubnet, }) if subnet.PrivateIPv4Address != nil { - if subnet.PrivateIPv4Address == nil { - return fmt.Errorf("privateIPv4Address can't be nil") + if *subnet.PrivateIPv4Address == "" { + return fmt.Errorf("privateIPv4Address can't be empty") } if lbSpec.Class != kops.LoadBalancerClassNetwork || lbSpec.Type != kops.LoadBalancerTypeInternal { return fmt.Errorf("privateIPv4Address only allowed for internal NLBs")