mirror of https://github.com/kubernetes/kops.git
test: use `T.TempDir` to create temporary test directory
The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
parent
7714964963
commit
deede3ecd4
|
@ -112,16 +112,7 @@ func TestRecoversFromBadNesting(t *testing.T) {
|
||||||
}
|
}
|
||||||
|
|
||||||
func runTest(t *testing.T, in string, expected string) {
|
func runTest(t *testing.T, in string, expected string) {
|
||||||
dir, err := os.MkdirTemp("", "")
|
dir := t.TempDir()
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("error creating temp dir: %v", err)
|
|
||||||
}
|
|
||||||
defer func() {
|
|
||||||
err := os.RemoveAll(dir)
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("failed to remove temp dir %q: %v", dir, err)
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
|
|
||||||
p := filepath.Join(dir, "hosts")
|
p := filepath.Join(dir, "hosts")
|
||||||
namesToAddresses := map[string][]string{
|
namesToAddresses := map[string][]string{
|
||||||
|
|
|
@ -35,17 +35,7 @@ type renderTest struct {
|
||||||
}
|
}
|
||||||
|
|
||||||
func doRenderTests(t *testing.T, method string, cases []*renderTest) {
|
func doRenderTests(t *testing.T, method string, cases []*renderTest) {
|
||||||
outdir, err := os.MkdirTemp("", "kops-render-")
|
outdir := t.TempDir()
|
||||||
if err != nil {
|
|
||||||
t.Errorf("failed to create local render directory: %s", err)
|
|
||||||
t.FailNow()
|
|
||||||
}
|
|
||||||
defer func() {
|
|
||||||
err := os.RemoveAll(outdir)
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("failed to remove temp dir %q: %v", outdir, err)
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
|
|
||||||
for i, c := range cases {
|
for i, c := range cases {
|
||||||
var filename string
|
var filename string
|
||||||
|
|
|
@ -31,16 +31,7 @@ func TestWriteFile(t *testing.T) {
|
||||||
// Clear the umask so an unusual umask doesn't break our test (for directory mode)
|
// Clear the umask so an unusual umask doesn't break our test (for directory mode)
|
||||||
syscall.Umask(0)
|
syscall.Umask(0)
|
||||||
|
|
||||||
tempDir, err := os.MkdirTemp("", "fitest")
|
tempDir := t.TempDir()
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("error creating temp dir: %v", err)
|
|
||||||
}
|
|
||||||
defer func() {
|
|
||||||
err := os.RemoveAll(tempDir)
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("failed to remove temp dir %q: %v", tempDir, err)
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
path string
|
path string
|
||||||
|
|
|
@ -24,16 +24,7 @@ import (
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestCreateFile(t *testing.T) {
|
func TestCreateFile(t *testing.T) {
|
||||||
TempDir, err := os.MkdirTemp("", "test")
|
TempDir := t.TempDir()
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("error creating temp dir: %v", err)
|
|
||||||
}
|
|
||||||
defer func() {
|
|
||||||
err := os.RemoveAll(TempDir)
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("failed to remove temp dir %q: %v", TempDir, err)
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
path string
|
path string
|
||||||
|
@ -70,16 +61,7 @@ func TestCreateFile(t *testing.T) {
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestWriteTo(t *testing.T) {
|
func TestWriteTo(t *testing.T) {
|
||||||
TempDir, err := os.MkdirTemp("", "test")
|
TempDir := t.TempDir()
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("error creating temp dir: %v", err)
|
|
||||||
}
|
|
||||||
defer func() {
|
|
||||||
err := os.RemoveAll(TempDir)
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("failed to remove temp dir %q: %v", TempDir, err)
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
path string
|
path string
|
||||||
|
|
Loading…
Reference in New Issue