kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix cloudformation lint job 

The dockerfile we were using in the cfn-python-lint repo wasn't actually pinned to the version associated with the git tag, it always installs the latest version.
A recent release consolidated error rules regarding invalid values.
We use an invalid "us-test-1" region and zones in much of our testing.
We used to be able to ignore this "invalid AZ" error, but now we would need to ignore all invalid values for all resource properties.
This pins cfn-python-lint to an older version but we'll have to figure out how we want to handle this longer term.
This commit is contained in:
Peter Rifel 2020-11-17 19:05:35 -06:00
parent 20cb30828b
commit df1e30182f
No known key found for this signature in database
GPG Key ID: BC6469E5B16DB2B6
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hack/cfn-lint.Dockerfile Normal file
View File

@ -0,0 +1,4 @@
FROM python:3.8-alpine
ARG CFNLINT_VERSION
RUN pip install "cfn-lint==${CFNLINT_VERSION}" pydot
ENTRYPOINT ["cfn-lint"]

7
hack/verify-cloudformation.sh
View File

@ -27,12 +27,7 @@ IMAGE="cfn-python-lint:${TAG}"
# https://github.com/aws-cloudformation/cfn-python-lint/issues/1025 # https://github.com/aws-cloudformation/cfn-python-lint/issues/1025
function docker_build() { function docker_build() {
echo "Building cfn-python-lint image" echo "Building cfn-python-lint image"
TMP=$(mktemp -d) docker build --build-arg "CFNLINT_VERSION=${TAG}" --tag "${IMAGE}" - < "${KOPS_ROOT}/hack/cfn-lint.Dockerfile"
git clone -q -b "${TAG}" https://github.com/aws-cloudformation/cfn-python-lint "${TMP}"
pushd "${TMP}"
docker build --tag "${IMAGE}" .
popd
rm -rf "${TMP}"
} }
docker image inspect "${IMAGE}" >/dev/null 2>&1 || docker_build docker image inspect "${IMAGE}" >/dev/null 2>&1 || docker_build