kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Continue to log if an error is encountered, separate the exit check

This commit is contained in:
Jack Andersen 2022-12-01 14:16:26 -08:00
parent f5f71f17f9
commit dfd9516a4f
No known key found for this signature in database
GPG Key ID: 3F47FBCA70B709C7
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/instancegroups/rollingupdate.go
View File

@ -188,7 +188,11 @@ func (c *RollingUpdateCluster) RollingUpdate(groups map[string]*cloudinstances.C
for _, k := range sortGroups(apiServerGroups) {
err := c.rollingUpdateInstanceGroup(apiServerGroups[k], c.NodeInterval)
if err != nil && isExitableError(err) {
if err != nil {
klog.Errorf("failed to roll InstanceGroup %q: %v", k, err)
}
if isExitableError(err) {
return err
}
@ -210,7 +214,11 @@ func (c *RollingUpdateCluster) RollingUpdate(groups map[string]*cloudinstances.C
for _, k := range sortGroups(nodeGroups) {
err := c.rollingUpdateInstanceGroup(nodeGroups[k], c.NodeInterval)
if err != nil && isExitableError(err) {
if err != nil {
klog.Errorf("failed to roll InstanceGroup %q: %v", k, err)
}
if isExitableError(err) {
return err
}