Merge pull request #8143 from tanjunchen/fix-shell-sh001

/hack: improve shell script  in hack

hack/go_install_from_commit.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+
 # Copyright 2017 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

hack/pre-commit.sh

@@ -1,3 +1,5 @@
+#!/bin/sh -eu
+
 # Copyright 2017 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -12,5 +14,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-#!/bin/sh -eu
 make ci

hack/update-bazel.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+
 # Copyright 2019 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

hack/update-expected.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+
 # Copyright 2019 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

hack/verify-apimachinery.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+
 # Copyright 2019 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -23,7 +24,7 @@ export API_OPTIONS="--verify-only"
 if make apimachinery-codegen; then
 	echo "apimachinery is up to date"
 else
-	echo "\n FAIL: - the verify-apimachinery.sh test failed, apimachinery is not up to date"
+	echo -e "\n FAIL: - the verify-apimachinery.sh test failed, apimachinery is not up to date"
-	echo "\n FAIL: - please run the command 'make apimachinery'"
+	echo -e "\n FAIL: - please run the command 'make apimachinery'"
 	exit 1
 fi

hack/verify-generate.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+
 # Copyright 2019 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -26,7 +27,7 @@ changed_files=$(git status --porcelain || true)
 if [ -n "${changed_files}" ]; then
    echo "Detected that generation is needed; run 'make crds'"
    echo "changed files:"
-   printf "${changed_files}\n"
+   printf "%s" "${changed_files}\n"
    echo "git diff:"
    git --no-pager diff
    echo "To fix: run 'make crds'"

hack/verify-gomod

@@ -25,7 +25,7 @@ changes=$(git status --porcelain || true)
 if [ -n "${changes}" ]; then
   echo "ERROR: go modules are not up to date; please run: go mod tidy"
   echo "changed files:"
-  printf "${changes}\n"
+  printf "%s" "${changes}\n"
   echo "git diff:"
   git --no-pager diff
   exit 1

hack/verify-spelling.sh

@@ -1,3 +1,5 @@
+#!/usr/bin/env bash
+
 # Copyright 2019 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -12,17 +14,21 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-#!/bin/bash
+set -o errexit
-
+set -o nounset
-set -e
+set -o pipefail
 
 REPO_ROOT=$(git rev-parse --show-toplevel)
 cd "${REPO_ROOT}"
 
 OUTPUT_GOBIN="${REPO_ROOT}/_output/bin"
+
+# Install tools we need, but from vendor/
 GOBIN="${OUTPUT_GOBIN}" go install ./vendor/github.com/client9/misspell/cmd/misspell
 
 mkdir -p .build/docs
+
+# Spell checking
 find . -type f \( -name "*.go*" -o -name "*.md*" \) -a -path "./docs/releases/*" -exec basename {} \; | \
 	xargs -I{} sh -c 'sed -e "/^\* .*github.com\/kubernetes\/kops\/pull/d" docs/releases/{} > .build/docs/$(basename {})'
 find . -type f \( -name "*.go*" -o -name "*.md*" \) -a \( -not -path "./vendor/*" -not -path "./docs/releases/*" \) | \

hack/verify-staticcheck.sh

@@ -31,6 +31,7 @@ kube::util::array_contains() {
   done
   return 1
 }
+
 function kube::util::read-array {
   local i=0
   unset -v "$1"
@@ -39,7 +40,10 @@ function kube::util::read-array {
 }
 
 FOCUS="${1:-}"
-FOCUS="${FOCUS%/}" # Remove the ending "/"
+
+# Remove the ending "/"
+FOCUS="${FOCUS%/}" 
+
 
 # See https://staticcheck.io/docs/checks
 CHECKS=(
@@ -50,7 +54,8 @@ CHECKS=(
 export IFS=','; checks="${CHECKS[*]}"; unset IFS
 
 # Packages to ignore due to bugs in staticcheck
-# NOTE: To ignore issues detected a package, add it to the .staticcheck_failures blacklist
+# NOTE: To ignore issues detected a package,
+# add it to the .staticcheck_failures blacklist
 IGNORE=(
 )
 export IFS='|'; ignore_pattern="^(${IGNORE[*]})\$"; unset IFS