mirror of https://github.com/kubernetes/kops.git
Striking unnecessary and incorrect conversion-gen instruction
This commit is contained in:
parent
6406abae91
commit
e84791a5d2
|
@ -17,7 +17,6 @@ go get k8s.io/kubernetes
|
||||||
cd ${GOPATH}/src/k8s.io/kubernetes
|
cd ${GOPATH}/src/k8s.io/kubernetes
|
||||||
git checkout master
|
git checkout master
|
||||||
git pull
|
git pull
|
||||||
go install ./cmd/libs/go2idl/conversion-gen
|
|
||||||
```
|
```
|
||||||
|
|
||||||
Then you can run `make apimachinery && make` to update the generated API machinery code (conversion functions). Note
|
Then you can run `make apimachinery && make` to update the generated API machinery code (conversion functions). Note
|
||||||
|
@ -36,4 +35,4 @@ it is backwards compatible (you have to make sure that the field is optional).
|
||||||
|
|
||||||
Currently, the apimachinery code we check in is relatively stable. However, when the generated code is large,
|
Currently, the apimachinery code we check in is relatively stable. However, when the generated code is large,
|
||||||
it is often considered good manners to your code reviewer to split a PR into multiple commits: one with the
|
it is often considered good manners to your code reviewer to split a PR into multiple commits: one with the
|
||||||
actual changes, and then a second commit with the autogenerated code.
|
actual changes, and then a second commit with the autogenerated code.
|
||||||
|
|
Loading…
Reference in New Issue