kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify boolean conditionals

This commit is contained in:
Peter Rifel 2025-08-22 20:17:36 -05:00
parent 701f01a26b
commit ec67c4acdc
No known key found for this signature in database
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cloudmock/scaleway/mockdns/api.go
View File

@ -107,7 +107,7 @@ func (f *FakeDomainAPI) UpdateDNSZoneRecords(req *domain.UpdateDNSZoneRecordsReq
break break
} }
} }
if found == false { if !found {
return nil, fmt.Errorf("could not find record %s to delete", *change.Delete.ID) return nil, fmt.Errorf("could not find record %s to delete", *change.Delete.ID)
} }

2
pkg/model/context.go
View File

@ -265,7 +265,7 @@ func (b *KopsModelContext) CloudTags(name string, shared bool) map[string]string
} }
case kops.CloudProviderScaleway: case kops.CloudProviderScaleway:
for k, v := range b.Cluster.Spec.CloudLabels { for k, v := range b.Cluster.Spec.CloudLabels {
if k == scaleway.TagClusterName && shared == true { if k == scaleway.TagClusterName && shared {
klog.V(4).Infof("Skipping %q tag for shared resource", scaleway.TagClusterName) klog.V(4).Infof("Skipping %q tag for shared resource", scaleway.TagClusterName)
continue continue
} }

8
upup/pkg/fi/cloudup/scalewaytasks/instance.go
View File

@ -92,7 +92,7 @@ func (s *Instance) Find(c *fi.CloudupContext) (*Instance, error) {
alreadyTagged = true alreadyTagged = true
} }
} }
if alreadyTagged == true { if alreadyTagged {
continue continue
} }
@ -107,7 +107,7 @@ func (s *Instance) Find(c *fi.CloudupContext) (*Instance, error) {
if err != nil { if err != nil {
return nil, fmt.Errorf("checking image differences in server %s (%s): %w", server.Name, server.ID, err) return nil, fmt.Errorf("checking image differences in server %s (%s): %w", server.Name, server.ID, err)
} }
if diff == true { if diff {
needsUpdate = append(needsUpdate, server.ID) needsUpdate = append(needsUpdate, server.ID)
continue continue
} }
@ -117,7 +117,7 @@ func (s *Instance) Find(c *fi.CloudupContext) (*Instance, error) {
if err != nil { if err != nil {
return nil, fmt.Errorf("checking user-data differences in server %s (%s): %w", server.Name, server.ID, err) return nil, fmt.Errorf("checking user-data differences in server %s (%s): %w", server.Name, server.ID, err)
} }
if diff == true { if diff {
needsUpdate = append(needsUpdate, server.ID) needsUpdate = append(needsUpdate, server.ID)
} }
} }
@ -457,7 +457,7 @@ func findFirstFreeIndex(existing []*instance.Server) int {
break break
} }
} }
if found == false { if !found {
return index return index
} }
} }