mirror of https://github.com/kubernetes/kops.git
				
				
				
			Merge pull request #1561 from justinsb/resolve_by_ip_first
Resolve nodes by IP before trying by name
This commit is contained in:
		
						commit
						ef5e2fdae8
					
				|  | @ -18,9 +18,11 @@ package components | ||||||
| 
 | 
 | ||||||
| import ( | import ( | ||||||
| 	"fmt" | 	"fmt" | ||||||
|  | 	"github.com/blang/semver" | ||||||
| 	"k8s.io/kops/pkg/apis/kops" | 	"k8s.io/kops/pkg/apis/kops" | ||||||
| 	"k8s.io/kops/upup/pkg/fi" | 	"k8s.io/kops/upup/pkg/fi" | ||||||
| 	"k8s.io/kops/upup/pkg/fi/loader" | 	"k8s.io/kops/upup/pkg/fi/loader" | ||||||
|  | 	"k8s.io/kubernetes/pkg/api" | ||||||
| ) | ) | ||||||
| 
 | 
 | ||||||
| // KubeAPIServerOptionsBuilder adds options for the apiserver to the model
 | // KubeAPIServerOptionsBuilder adds options for the apiserver to the model
 | ||||||
|  | @ -49,6 +51,30 @@ func (b *KubeAPIServerOptionsBuilder) BuildOptions(o interface{}) error { | ||||||
| 		options.KubeAPIServer.StorageBackend = fi.String("etcd2") | 		options.KubeAPIServer.StorageBackend = fi.String("etcd2") | ||||||
| 	} | 	} | ||||||
| 
 | 
 | ||||||
|  | 	k8sVersion, err := b.Context.KubernetesVersion() | ||||||
|  | 	if err != nil { | ||||||
|  | 		return err | ||||||
|  | 	} | ||||||
|  | 	if options.KubeAPIServer.KubeletPreferredAddressTypes == nil { | ||||||
|  | 		if k8sVersion.GTE(semver.MustParse("1.5.0")) { | ||||||
|  | 			// Default precedence
 | ||||||
|  | 			//options.KubeAPIServer.KubeletPreferredAddressTypes = []string {
 | ||||||
|  | 			//	string(api.NodeHostName),
 | ||||||
|  | 			//	string(api.NodeInternalIP),
 | ||||||
|  | 			//	string(api.NodeExternalIP),
 | ||||||
|  | 			//	string(api.NodeLegacyHostIP),
 | ||||||
|  | 			//}
 | ||||||
|  | 
 | ||||||
|  | 			// We prioritize the internal IP above the hostname
 | ||||||
|  | 			options.KubeAPIServer.KubeletPreferredAddressTypes = []string{ | ||||||
|  | 				string(api.NodeInternalIP), | ||||||
|  | 				string(api.NodeHostName), | ||||||
|  | 				string(api.NodeExternalIP), | ||||||
|  | 				string(api.NodeLegacyHostIP), | ||||||
|  | 			} | ||||||
|  | 		} | ||||||
|  | 	} | ||||||
|  | 
 | ||||||
| 	return nil | 	return nil | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue