kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve error logging 

We've had reports where something has gone wrong (misconfigured zone?)
but AWS is in a retry loop, and we don't get the full error until
timeout.

Log more details.
This commit is contained in:
Justin Santa Barbara 2017-01-28 14:14:03 -05:00
parent b419f2013d
commit f8984ec223
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
upup/pkg/fi/cloudup/awsup/logging_retryer.go
View File

@ -17,6 +17,7 @@ limitations under the License.
package awsup package awsup
import ( import (
"fmt"
"github.com/aws/aws-sdk-go/aws/client" "github.com/aws/aws-sdk-go/aws/client"
"github.com/aws/aws-sdk-go/aws/request" "github.com/aws/aws-sdk-go/aws/request"
"github.com/golang/glog" "github.com/golang/glog"
@ -47,7 +48,15 @@ func (l LoggingRetryer) RetryRules(r *request.Request) time.Duration {
} }
methodDescription := service + "/" + name methodDescription := service + "/" + name
glog.Infof("Retryable error %d (%s) from %s - will retry after delay of %v", r.HTTPResponse.StatusCode, r.HTTPResponse.Status, methodDescription, duration) var errorDescription string
if r.Error != nil {
// We could check aws error Code & Message, but we expect them to be in the string
errorDescription = fmt.Sprintf("%v", r.Error)
} else {
errorDescription = fmt.Sprintf("%d %s", r.HTTPResponse.StatusCode, r.HTTPResponse.Status)
}
glog.Infof("Retryable error (%s) from %s - will retry after delay of %v", errorDescription, methodDescription, duration)
return duration return duration
} }