Commit Graph

110 Commits

Author SHA1 Message Date
John Gardiner Myers 03eb8246c7 Refactor/simplify rolling update 2020-03-09 11:05:58 -07:00
John Gardiner Myers e104cdb982 Default maxSurge to 1 on AWS 2020-03-04 19:41:51 -08:00
John Gardiner Myers 99100dc4a0 Fix flaky test 2020-03-03 20:54:22 -08:00
John Gardiner Myers ed73726195 Address review comments 2020-02-28 21:05:43 -08:00
John Gardiner Myers 38b7219b14 Remove code made unnecessary by apimachinery validation 2020-01-27 20:45:17 -08:00
John Gardiner Myers ebfcf5d909 Implement recovery from previous failed surge rolling updates 2020-01-27 20:45:16 -08:00
John Gardiner Myers cee662d521 Implement MaxSurge happy path 2020-01-27 20:45:16 -08:00
John Gardiner Myers 4ddc58ca5e Add MaxSurge to resolveSettings 2020-01-27 20:45:16 -08:00
John Gardiner Myers 640f5f5b74 Terminate AWS instances through EC2 instead of Autoscaling 2020-01-27 20:15:10 -08:00
John Gardiner Myers d56ad41334 Address review comments 2020-01-26 14:18:51 -08:00
John Gardiner Myers 5f72d12132 Reduce test flakiness 2020-01-12 21:27:55 -08:00
John Gardiner Myers 10d6416b8e Allow MaxConcurrency for masters and bastions 2020-01-11 18:50:35 -08:00
John Gardiner Myers 0c3651c9c8 Implement MaxUnavailable 2020-01-05 12:09:55 -08:00
John Gardiner Myers 0952374027 Extract maybeValidate 2020-01-05 12:09:55 -08:00
John Gardiner Myers 91f4920537 Extract drainTerminateAndWait() 2020-01-05 12:09:55 -08:00
John Gardiner Myers adaf903b90 Create resolveSettings 2020-01-05 12:09:54 -08:00
Kubernetes Prow Robot 121d9f461f
Merge pull request #7909 from johngmyers/remove-drain-feature-flag
Remove DrainAndValidateRollingUpdate feature flag
2020-01-05 11:15:40 -08:00
Kubernetes Prow Robot a22af4fa80
Merge pull request #8239 from johngmyers/simplify-rolling
Simplify code for rolling updates of nodes
2020-01-04 13:13:40 -08:00
John Gardiner Myers 01dd793604 Specify number of NotReady instances in makeGroup() parameter 2020-01-04 10:47:08 -08:00
John Gardiner Myers 39f849271b Fold setUpCloud() into getGroups() 2020-01-04 09:08:00 -08:00
John Gardiner Myers 612e4ae484 Extract creation of the CloudInstanceGroup 2020-01-04 09:08:00 -08:00
John Gardiner Myers cba59afac4 Change taint key per review comment 2020-01-03 10:07:21 -08:00
John Gardiner Myers cd499f6f09 Remove unused code 2019-12-31 14:33:05 -08:00
John Gardiner Myers 0cbd76ecfb Simplify code for rolling updates of nodes 2019-12-31 10:25:55 -08:00
John Gardiner Myers 97ad2c3b54 Taint nodes needing update 2019-12-30 16:06:00 -08:00
John Gardiner Myers 5189cc1ef6 Add a third instance to each nodes group in rolling update tests 2019-12-30 13:48:37 -08:00
John Gardiner Myers 92581ab4a1 Create nodes for instances in rolling update tests 2019-12-30 13:48:37 -08:00
John Gardiner Myers 77769855af Return groups from getTestSetup() 2019-12-30 13:48:34 -08:00
John Gardiner Myers 1d3d5c1d2f pkg/instancegroups - fix static check 2019-12-22 20:56:27 -08:00
Justin Santa Barbara 84835ce0ba
Update pkg/instancegroups/rollingupdate_test.go
Co-Authored-By: John Gardiner Myers <jgmyers@proofpoint.com>
2019-12-17 21:25:18 -05:00
Peter Rifel a24d9b6455
remove more trailing whitespace 2019-12-17 13:03:16 -06:00
Peter Rifel 85a1d23c18
remove trailing whitespace that was breaking gofmt 2019-12-17 12:49:20 -06:00
Justin Santa Barbara 8373c9fc4d tests: increase timeout in rolling update tests
We never know when e.g. a GC is going to delay us, so we need a lot
more padding on these timeouts.
2019-12-17 09:59:21 -05:00
John Gardiner Myers 2850826a52 Improve logging of cluster revalidation 2019-12-13 13:48:47 -08:00
John Gardiner Myers 19e165759b Add unit test for flapping validation 2019-12-13 13:45:21 -08:00
Jesse Haka 44183aef7f validate cluster twice 2019-12-12 08:48:15 +02:00
John Gardiner Myers 1239c05e71 Validate after updating bastion 2019-12-09 18:45:51 -08:00
John Gardiner Myers 2e36124f77 Expose ValidateTickDuration for use by unit tests 2019-12-09 18:43:20 -08:00
Kashif Saadat fcf6f0098c Canal Typha spec and apimachinery 2019-12-06 15:36:48 +00:00
John Gardiner Myers 4eccd3d53f Remove DrainAndValidateRollingUpdate feature flag 2019-12-05 22:50:04 -08:00
John Gardiner Myers 38b19e53b4 Add a second master to rolling update tests 2019-11-19 16:55:39 -08:00
John Gardiner Myers 8121a84089 Improve rolling update test coverage 2019-11-19 16:55:39 -08:00
John Gardiner Myers cfca6fae10 extract RollingUpdateCluster initialization in rollingupdate tests 2019-11-19 16:55:39 -08:00
John Gardiner Myers d82c834fe3 extract common test setup in rollingupdate tests 2019-11-19 16:55:39 -08:00
John Gardiner Myers 7e8c77a8bf extract CloudInstanceGroup setup in rollingupdate tests 2019-11-19 16:55:36 -08:00
John Gardiner Myers 3d6d6734e5 Make rollingupdate test assertions succinct 2019-11-19 16:45:55 -08:00
Peter Rifel 3dc06afa12 Fix goimports errors
It turns out we werent running verify-goimports in our CI jobs.

While we work to get that enabled, we can at least unblock the releases by doing a one-time fix of the failing goimports
2019-11-19 05:05:02 -08:00
John Gardiner Myers b63cc36f88 Update bazel 2019-11-07 22:59:51 -08:00
Justin Santa Barbara 5a0b199119
Merge branch 'master' into fix-roll-validation 2019-11-07 20:54:10 -05:00
John Gardiner Myers 5b8bed77fa Don't update first node in instancegroup if cluster fails validation 2019-11-04 16:26:39 -08:00