Commit Graph

340 Commits

Author SHA1 Message Date
Justin SB 0cb35638f2
Stop logging to /var/log/kops-controller.log
Writing to a hostPath from a non-root container requires file
ownership changes, which is difficult to roll out today.  See
discussion in #8454

We were primarily using the logfile for e2e diagnostics, so we're
going to look into collecting the information via other means instead.

We also haven't yet shipped this logfile in a released version (though
we have shipped it in beta releases)
2020-02-04 06:41:25 -05:00
Kim Bao Long 3c094cb471 Fix typo in comment
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-31 07:54:37 +07:00
Roberto Rodriguez Alcala b9945594fd Updates based on feedback 2020-01-23 20:31:18 -08:00
Kubernetes Prow Robot 0e1f5ba2aa
Merge pull request #8328 from rifelpet/shellcheck
Add shellcheck verification
2020-01-17 04:46:55 -08:00
tanjunchen 15b4643aee upup/pkg/fi/cloudup/awstasks/ staticcheck 2020-01-14 10:02:16 +08:00
Peter Rifel f6c647230a Add shellcheck verification
Copied from the k/k repo with some of the utility functions inlined, just like verify-staticcheck.sh.
Once merged I'll add another prow job for it.
2020-01-12 18:47:21 -06:00
Kubernetes Prow Robot 179957d09f
Merge pull request #7824 from rifelpet/kops-server-cleanup
Remove traces of kops-server
2020-01-11 23:13:36 -08:00
Justin SB cf5c53c87d
Add tests for manifest normalization
(The tests are split out for easier cherry-picking, should we choose to)
2020-01-11 22:41:18 -05:00
Kubernetes Prow Robot 556175910b
Merge pull request #8193 from Aresforchina/fix-staticheckout-pkg-resource02
upup/pkg/fi-fix staticcheck
2020-01-11 12:15:36 -08:00
Aresforchina f312f7c974 upup/pkg/fi-fix staticcheck 2020-01-07 15:50:30 +08:00
Justin Santa Barbara fc21f4255f Replace kubernetes mount code with utils
This will remove one of the main dependencies on the
kubernetes/kubernetes repo.
2020-01-04 17:34:31 -05:00
Kubernetes Prow Robot 388a3cb23d
Merge pull request #8232 from hakman/staticcheck-simplify
Add code simplifications for staticheck
2019-12-30 10:53:39 -08:00
Ciprian Hacman 4c4400c5f3 Add code simplifications for staticheck 2019-12-30 17:40:24 +02:00
Kubernetes Prow Robot e34c12a8f7
Merge pull request #8223 from johngmyers/openstack-staticcheck
Fix pkg/resources/openstack staticcheck failure
2019-12-29 21:21:39 -08:00
John Gardiner Myers 4ef035faa2 Fix pkg/resources/openstack staticcheck failure 2019-12-29 15:57:14 -08:00
John Gardiner Myers 00abe3af7e Fix node-authorizer/pkg/authorizers/aws staticcheck failure 2019-12-29 15:54:50 -08:00
John Gardiner Myers e4082aaf4c Fix cloudmock/aws/mockelbv2 staticcheck failures 2019-12-28 21:25:29 -08:00
Kubernetes Prow Robot e7ad6a9601
Merge pull request #8143 from tanjunchen/fix-shell-sh001
/hack: improve shell script  in hack
2019-12-27 18:41:39 -08:00
Kubernetes Prow Robot c1f5c7acd6
Merge pull request #8202 from johngmyers/kops-staticcheck
Fix cmd/kops staticcheck failures
2019-12-27 09:30:31 -08:00
Kubernetes Prow Robot 0377b58a08
Merge pull request #8203 from johngmyers/codegen-staticcheck
Fix upup/tools/generators/pkg/codegen staticcheck failures
2019-12-27 08:45:39 -08:00
Peter Rifel 32d1d6cf65 Remove traces of kops-server 2019-12-26 13:20:32 -06:00
ares 1e6675f9e9
Merge branch 'master' into fix-staticcheck-pkg-resources-digitalocean 2019-12-26 13:05:01 +08:00
John Gardiner Myers 3f35e26c9b Fix upup/tools/generators/pkg/codegen staticcheck failures 2019-12-25 16:15:40 -08:00
John Gardiner Myers d127b9b1a1 Fix cmd/kops staticcheck failures 2019-12-25 14:59:27 -08:00
Kubernetes Prow Robot 22ddc3b423
Merge pull request #8191 from Aresforchina/fix-staticcheck-pkg-resources01
fix staticcheck failures in pkg/resources
2019-12-25 12:03:38 -08:00
tanjunchen cc0f7022f0 /hack: improve shell script in hack 2019-12-25 17:16:31 +08:00
Kubernetes Prow Robot 5cb2d3605c
Merge pull request #8149 from hakman/staticcheck-dnsprovider
dnsprovider/pkg/dnsprovider - fix static check
2019-12-24 06:55:29 -08:00
Aresforchina 8ebcea0024 fix staticcheck failures in pkg/resources 2019-12-24 17:12:53 +08:00
Kubernetes Prow Robot dffc8975d6 pkg/resources/aws:simplify code and remove code 2019-12-24 10:56:57 +08:00
Kubernetes Prow Robot 61d556f9e9
Merge pull request #8188 from Aresforchina/fix-pkg-resources-aws
pkg/resources/aws:simplify code and remove code
2019-12-23 16:19:29 -08:00
Kubernetes Prow Robot 6fd4762290
Merge pull request #8186 from johngmyers/instancegroup-staticcheck
pkg/instancegroups - fix static check
2019-12-23 15:25:29 -08:00
Peter Rifel c6dbe9d686 Remove make command from verify-staticcheck.sh
This script should now be called using `make verify-staticcheck` which will handle the go-bindata dependency.
2019-12-23 09:25:42 -06:00
Aresforchina 8f86a1b201 pkg/resources-aws:simplify code and remove code 2019-12-23 19:00:17 +08:00
Kubernetes Prow Robot 5f588f0a50
Merge pull request #8165 from hakman/staticcheck-protokube
protokube/pkg - fix static check
2019-12-23 02:49:32 -08:00
John Gardiner Myers 1d3d5c1d2f pkg/instancegroups - fix static check 2019-12-22 20:56:27 -08:00
Ciprian Hacman deadeaed1e dnsprovider/pkg/dnsprovider - fix static check 2019-12-23 06:23:38 +02:00
Peter Rifel e7e9e62bcc Remove packages from staticcheck failure list that are no longer failing 2019-12-22 15:12:15 -06:00
Peter Rifel ef8f07c451 Fix verify-staticcheck prow job
The new job was missing the generated files from go-bindata.

I noticed some of the prow jobs use make and others call hack/ scripts directly.

I think it'd be better to use make so we can more easily add dependencies like this, therefor I'd like to propose that we merge this, update the jobs to call make targets, then remove the make command I added to hack/verify-staticcheck.sh

By fixing the existing job as well as the make target, we can unblock other PRs and not get another swarm of failure notifications when the job gets updated to use make.
2019-12-22 15:03:29 -06:00
Ciprian Hacman defcbe8151 protokube/pkg - fix static check 2019-12-20 20:17:19 +02:00
Kubernetes Prow Robot 6856358cd0
Merge pull request #8118 from tanjunchen/fix-staticcheck-001
upup/pkg/fi/ upup/pkg/kutil : simplify code and remove code
2019-12-20 07:41:33 -08:00
Ciprian Hacman fa665943ac nodeup/pkg/model - fix static check 2019-12-18 22:07:31 +02:00
tanjunchen d5fef40863 upup/pkg/fi/cloudup/ upup/pkg/fi/nodeup/ hack/.staticcheck_failures : simplify code and remove code 2019-12-18 09:47:58 +08:00
Kubernetes Prow Robot 252a733415
Merge pull request #8121 from tanjunchen/fix-staiccheck-003
util/pkg/ upup/tools/ :  simplify code and remove unused  code
2019-12-17 11:23:57 -08:00
Kubernetes Prow Robot 40c2762367
Merge pull request #8128 from mikesplain/add_inf1
Add inf1 isntances
2019-12-17 08:13:59 -08:00
tanjunchen e4302e3630 util/pkg/: simplify code and remove unused code 2019-12-17 09:44:18 +08:00
tanjunchen 52537053cc simplify code and remove unused code 2019-12-17 00:28:35 +08:00
mikesplain 77f9cb155e
Add inf1 isntances 2019-12-16 09:20:14 -05:00
Justin Santa Barbara e479ecf682 dev: ignore kops-controller in hack/update-expected.sh
hack/update-expected.sh should ignore KOPSCONTROLLER_IMAGE when
regenerating the golden test outputs, just as it ignores the local
DNSCONTROLLER_IMAGE override.
2019-12-14 10:53:25 -05:00
Peter Rifel 8e9f7e63be Install vendored goimports prior to running it 2019-11-26 19:33:58 -06:00
Kubernetes Prow Robot 7022a4f1c1
Merge pull request #7998 from justinsb/goimports-gomod
Run goimports from locked version in go.mod
2019-11-25 08:25:40 -08:00