Kubernetes Prow Robot
2a613f1331
Merge pull request #9165 from johngmyers/retry-initial
...
Try validating multiple times before updating instancegroup
2020-05-29 12:07:33 -07:00
John Gardiner Myers
091893fd20
Simplify rolling update internal methods
2020-05-29 10:52:03 -07:00
John Gardiner Myers
dd884a6a64
fix missing space
...
Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
2020-05-29 10:35:15 -07:00
John Gardiner Myers
7756be7fbc
Try validating multiple times before updating instancegroup
2020-05-22 20:26:02 -07:00
John Gardiner Myers
af90ecdddf
Reduce test flakiness
2020-05-22 19:33:01 -07:00
John Gardiner Myers
df7e0b18b6
Ignore already-deleted nodes during rolling update
2020-04-26 21:41:54 -07:00
Justin Santa Barbara
ffb6cd61aa
Rolling-update validation harmonization
...
This is a follow-on to #8868 ; I believe the intent of that was to
expose the option to do more (or fewer) retries.
We previously had a single retry to prevent flapping; this basically
unifies the previous behaviour with the idea of making it
configurable.
* validate-count=0 effectively turns off validation.
* validate-count=1 will do a single validation, without flapping
detection.
* validate-count>=2 will require N succesful validations in a row,
waiting ValidateSuccessDuration in between.
A nice side-effect of this is that the tests now explicitly specify
ValidateCount=1 instead of setting ValidateSuccessDuration=0, which
had the side effect of doing the equivalent to ValidateCount=1.
2020-04-17 01:40:02 -04:00
Justin Santa Barbara
31bb16d4d1
Add context.Context to most signatures
...
The client-go signature for most methods adds a context.Context
object, and also makes Options mandatory. Feed through a
context.Context through many of our methods (but use context.TODO to
stop it getting totally out of hand!)
2020-04-11 14:44:17 -04:00
Jesse Haka
11eaacd53e
validationtimes -> validationcount
2020-04-08 13:55:29 +03:00
Jesse Haka
e1e79790ef
validate cluster n times in rolling update
2020-04-08 13:55:24 +03:00
John Gardiner Myers
ea3b8d7710
make gomod
2020-04-05 10:22:51 -07:00
John Gardiner Myers
6844eef4ca
Switch to the k/k implementation of drain.Helper
2020-04-05 10:22:49 -07:00
Peter Rifel
a999b3ea61
fix OWNERS labels format
...
These need to be lists
2020-03-10 22:47:50 -05:00
Kubernetes Prow Robot
8ecc5edb73
Merge pull request #8272 from johngmyers/need-update-annotation
...
Support the kops.k8s.io/needs-update annotation on nodes
2020-03-10 09:01:35 -07:00
Kubernetes Prow Robot
db435ee7cd
Merge pull request #8717 from rifelpet/owners-labels
...
Add labels to OWNERS files
2020-03-10 08:23:51 -07:00
Peter Rifel
237a125f2c
Add labels to OWNERS files
...
This will automatically label PRs that touch these directories.
This makes it easier to query GitHub for PRs that affect certain areas of the code.
I mostly used existing labels but created some new ones as well.
2020-03-10 08:35:58 -05:00
John Gardiner Myers
33e23166e4
Support the kops.k8s.io/needs-update annotation on nodes
2020-03-09 22:43:09 -07:00
John Gardiner Myers
03eb8246c7
Refactor/simplify rolling update
2020-03-09 11:05:58 -07:00
John Gardiner Myers
e104cdb982
Default maxSurge to 1 on AWS
2020-03-04 19:41:51 -08:00
John Gardiner Myers
99100dc4a0
Fix flaky test
2020-03-03 20:54:22 -08:00
John Gardiner Myers
ed73726195
Address review comments
2020-02-28 21:05:43 -08:00
John Gardiner Myers
38b7219b14
Remove code made unnecessary by apimachinery validation
2020-01-27 20:45:17 -08:00
John Gardiner Myers
ebfcf5d909
Implement recovery from previous failed surge rolling updates
2020-01-27 20:45:16 -08:00
John Gardiner Myers
cee662d521
Implement MaxSurge happy path
2020-01-27 20:45:16 -08:00
John Gardiner Myers
4ddc58ca5e
Add MaxSurge to resolveSettings
2020-01-27 20:45:16 -08:00
John Gardiner Myers
640f5f5b74
Terminate AWS instances through EC2 instead of Autoscaling
2020-01-27 20:15:10 -08:00
John Gardiner Myers
d56ad41334
Address review comments
2020-01-26 14:18:51 -08:00
John Gardiner Myers
5f72d12132
Reduce test flakiness
2020-01-12 21:27:55 -08:00
John Gardiner Myers
10d6416b8e
Allow MaxConcurrency for masters and bastions
2020-01-11 18:50:35 -08:00
John Gardiner Myers
0c3651c9c8
Implement MaxUnavailable
2020-01-05 12:09:55 -08:00
John Gardiner Myers
0952374027
Extract maybeValidate
2020-01-05 12:09:55 -08:00
John Gardiner Myers
91f4920537
Extract drainTerminateAndWait()
2020-01-05 12:09:55 -08:00
John Gardiner Myers
adaf903b90
Create resolveSettings
2020-01-05 12:09:54 -08:00
Kubernetes Prow Robot
121d9f461f
Merge pull request #7909 from johngmyers/remove-drain-feature-flag
...
Remove DrainAndValidateRollingUpdate feature flag
2020-01-05 11:15:40 -08:00
Kubernetes Prow Robot
a22af4fa80
Merge pull request #8239 from johngmyers/simplify-rolling
...
Simplify code for rolling updates of nodes
2020-01-04 13:13:40 -08:00
John Gardiner Myers
01dd793604
Specify number of NotReady instances in makeGroup() parameter
2020-01-04 10:47:08 -08:00
John Gardiner Myers
39f849271b
Fold setUpCloud() into getGroups()
2020-01-04 09:08:00 -08:00
John Gardiner Myers
612e4ae484
Extract creation of the CloudInstanceGroup
2020-01-04 09:08:00 -08:00
John Gardiner Myers
cba59afac4
Change taint key per review comment
2020-01-03 10:07:21 -08:00
John Gardiner Myers
cd499f6f09
Remove unused code
2019-12-31 14:33:05 -08:00
John Gardiner Myers
0cbd76ecfb
Simplify code for rolling updates of nodes
2019-12-31 10:25:55 -08:00
John Gardiner Myers
97ad2c3b54
Taint nodes needing update
2019-12-30 16:06:00 -08:00
John Gardiner Myers
5189cc1ef6
Add a third instance to each nodes group in rolling update tests
2019-12-30 13:48:37 -08:00
John Gardiner Myers
92581ab4a1
Create nodes for instances in rolling update tests
2019-12-30 13:48:37 -08:00
John Gardiner Myers
77769855af
Return groups from getTestSetup()
2019-12-30 13:48:34 -08:00
John Gardiner Myers
1d3d5c1d2f
pkg/instancegroups - fix static check
2019-12-22 20:56:27 -08:00
Justin Santa Barbara
84835ce0ba
Update pkg/instancegroups/rollingupdate_test.go
...
Co-Authored-By: John Gardiner Myers <jgmyers@proofpoint.com>
2019-12-17 21:25:18 -05:00
Peter Rifel
a24d9b6455
remove more trailing whitespace
2019-12-17 13:03:16 -06:00
Peter Rifel
85a1d23c18
remove trailing whitespace that was breaking gofmt
2019-12-17 12:49:20 -06:00
Justin Santa Barbara
8373c9fc4d
tests: increase timeout in rolling update tests
...
We never know when e.g. a GC is going to delay us, so we need a lot
more padding on these timeouts.
2019-12-17 09:59:21 -05:00