Commit Graph

413 Commits

Author SHA1 Message Date
Peter Rifel 7694fce7cd
Simplify boolean expression 2025-08-22 20:36:06 -05:00
Peter Rifel 701f01a26b
Use switch/case statement 2025-08-22 20:36:02 -05:00
AkiraFukushima b674f78c8e
Re-enable additionalSecurityGroups for bastion LB 2025-06-08 22:07:36 +09:00
justinsb 7dc29d29fd Do not include WarmPool in json for AutoscalingGroup task
This avoids a circular dependency.

I previously considered making the field private,
but this is roughly equivalent and less disruptive.

Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
2025-03-27 08:03:37 -04:00
cuiyourong 0cfcb4ef5e chore: fix some function names in comment
Signed-off-by: cuiyourong <cuiyourong@gmail.com>
2024-12-07 00:40:04 +08:00
Kubernetes Prow Robot 417cb3fcbc
Merge pull request #16931 from spotinst/spotinst/feature/add_aggressiveScaleDown
Spotinst: add aggressive scale down feature
2024-11-10 16:54:44 +00:00
justinsb b4306a390c tests: set AllInstanceGroups alongside InstanceGroups 2024-11-09 14:57:24 -05:00
Ciprian Hacman 1683894999 Allow updating the cluster one instance group at a time
Co-Authored-By: Ciprian Hacman <ciprianhacman@gmail.com>
2024-11-09 11:34:28 -05:00
yehielnetapp e9f0fc0aad actual change to add feature aggressiveScaleDown 2024-11-04 10:18:58 +02:00
justinsb 28c4cff7d4 refactor: remove unused keystore parameter
This keystore field was not used.  Refactor for clarity/simplicity.
2024-09-17 07:52:07 -04:00
yehiel etah 5d4d867086
spotinst: Bump k8s cluster controller to v2 (#16717)
* update controller v2, inform user on conflict with aws nodeTerminationHandler and Ocean

* add BuildPrune to addon,tested

* add note to release 1.31
2024-08-09 15:25:15 -07:00
Peter Rifel dc1aa0d3b4
Migrate IAM EC2 Service generation to aws-sdk-go-v2 2024-04-18 20:37:11 -04:00
Peter Rifel dd3d64943f
Migrate remaining EC2 resource types to aws-sdk-go-v2 2024-04-13 16:01:39 -04:00
Peter Rifel f0c0c29121
Migrate EC2 Networking resource types to aws-sdk-go-v2 2024-04-13 16:01:39 -04:00
Peter Rifel d4d39eb0fe
Migrate autoscaling to aws-sdk-go-v2 2024-03-31 23:04:06 -05:00
Peter Rifel 0dcbf23df2
Migrate aws-sdk-go/aws to aws-sdk-go-v2/aws 2024-03-31 16:56:31 -05:00
Peter Rifel 60bfbbc418
Remove unused error 2024-03-31 08:54:59 -05:00
Peter Rifel c4be1082fc
Use lower case package import alias 2024-03-31 08:54:44 -05:00
Peter Rifel 2626a354c5
Migrate ELB to aws-sdk-go-v2 2024-03-31 07:28:28 -05:00
Peter Rifel 7b8bcc46d9
Migrate elbv2 to aws-sdk-go-v2 2024-03-30 13:53:40 -05:00
Peter Rifel 8882bcbafb
Migrate IAM to aws-sdk-go-v2 2024-03-30 10:46:57 -05:00
Peter Rifel 8191e78838
Update EventBridge to aws-sdk-go-v2 2024-03-29 07:05:36 -05:00
Peter Rifel 0290a7e8d7
Migrate some packages to aws-sdk-go-v2 2024-03-23 19:42:28 -05:00
justinsb 4423b79959 aws: expose port 8443 when using NLB with a custom certificate
We dropped the security group rules for this when moving to NLB
security groups; add them back.

Issue #16024
2024-03-12 21:41:47 -04:00
justinsb 2a9343a168 Generate revisions of NLB objects, and introduce cleanup phase
This lets us safely make changes to otherwise immutable fields, in
particular for adding security groups to NLBs created without them.

We detect the older versions, and create deletion tasks to remove
them.  These tasks can be deferred, and we expect them to be
deferred to a "prune" phase that runs after cluster apply.

Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
2024-02-17 11:41:15 -05:00
Peter Rifel 70da572ed8
Use pkg/model/iam for building SQS queue policy 2024-02-14 17:39:45 -06:00
Peter Rifel b5264488cb
Rename stringorslice package to stringorset 2024-02-12 22:42:13 -06:00
justinsb bd8cce06ae refactor: Drop TargetGroups from NetworkLoadBalancer task
They are not needed, they were only used for dependency ordering (and
we now have that dependency on the split out listener task)
2024-02-04 18:09:17 -05:00
justinsb c35c754eff Refactor: Split out NLB Listener into its own task
This allows us to use more of our task machinery, including dependency
analysis.  The intent is that we'll be able to support multiple
LoadBalancers and TargetGroups.
2024-02-04 15:52:25 -05:00
justinsb 086af6458e refactor: wait for load balancer readiness using a private field
This approach is more explicit than looking at the names of the target
groups, and using a private field is simpler.
2024-01-29 09:34:56 -05:00
Kubernetes Prow Robot b84ab1e0eb
Merge pull request #16289 from justinsb/nlb_should_set_scheme
Tweak: Set Scheme on NLB tasks for public load balancers
2024-01-28 21:13:35 -08:00
justinsb 0b8d3a52cb Tweak: Set Scheme on NLB tasks for public load balancers
This avoids a spurious diff.
2024-01-28 16:19:37 -05:00
justinsb 169c96ba11 refactor: NetworkLoadBalancer Name should match Name tag
It was actually the terraform name, and didn't match the tag.

This change should have no externally-visible effect.
2024-01-28 16:19:02 -05:00
justinsb 50776a7e92 Refactor ForAPIServer
We instead return a list of the services we are supporting.

We can in future split out internal and external apiserver services.
2024-01-12 15:53:41 -05:00
yehielnetapp af19ad5664 add feature base 2023-11-12 14:19:37 +02:00
yehielnetapp 00fc4e78e8 add Label Resource Tag Specification Volumes 2023-11-12 14:19:15 +02:00
Ciprian Hacman 6dd31d9680 aws: Attach security group to NLBs for kops-controller 2023-10-08 09:16:35 +03:00
Kubernetes Prow Robot d2b789da07
Merge pull request #15993 from johngmyers/nlb-sg
aws: Attach security groups to NLBs
2023-10-07 10:57:01 +02:00
John Gardiner Myers 9f40d59545 Improve removal of orphaned security group rules 2023-10-06 22:33:31 -07:00
John Gardiner Myers 2fbc7cf979 aws: Attach security groups to NLBs 2023-10-06 22:33:31 -07:00
Ciprian Hacman f26874c37e aws: Don't add dependency on additional CIDR for shared VPC 2023-10-03 07:24:12 +03:00
justinsb f5c2f2bcba Fix warmpool to expose dependencies for dependency analysis
We should populate the AutoscalingGroup field, so that it can be used
by dependency analysis.
2023-08-31 13:08:08 -04:00
Ciprian Hacman 68ce4c800e aws: Add dependency on additional network cidrs for subnets 2023-08-31 11:15:10 +03:00
Ciprian Hacman 60b0fee1e0 aws: Add instance group tag to subnets only with Karpenter 2023-08-05 07:50:24 +03:00
Ciprian Hacman 36b119d599 aws: Allow using the same instance ID as egress for multiple subnets 2023-07-13 09:12:26 +03:00
Ciprian Hacman cbddb4a9fd Remove duplicate Cluster field from tests 2023-06-20 12:19:04 +03:00
Kubernetes Prow Robot c5ad898ef9
Merge pull request #15424 from spotinst/feature/add_spreadNodesBy
Spotinst: add feature spread nodes by count/vcpu to markets
2023-05-24 05:15:04 -07:00
justinsb ca67b1ca1e Refactor: rename IsGossip -> UsesLegacyGossip
We want to be able to use "dns=none" (without peer-to-peer gossip)
even for clusters that have the k8s.local extension.  These were
previously called "gossip clusters", but really that is an
implementation; what actually matters to users is that they don't rely
on writing records into a DNS zone (such as Route53).
2023-05-22 21:50:16 -04:00
yehielnetapp faf4da0014 add cluster orientation cluster config 2023-05-18 16:15:34 +03:00
yehielnetapp 497898328f add feature spread nodes by to cluster 2023-05-17 12:56:44 +03:00