Commit Graph

42 Commits

Author SHA1 Message Date
Sean Johnson 737a7a2cb8 5700: Add command line flag for disabling Subnet ELB tags 2018-10-10 12:48:06 +11:00
Justin Santa Barbara 1c3949bdfe Don't assume that we only have one subnet per AZ
I made a mistaken assumption in
dde2100a19 that we only had one subnet
per AZ, but as demonstrated in #5587 this was not the case.

What I was trying to achieve was not to include the cluster name, so
for the case of subnets this commit just uses the subnet name from the
cluster spec, which should be unique and stable.  That is hopefully at
least as meaningful.

Thankfully we hadn't released a version with the erroneous naming.

Fix #5587
2018-08-13 13:15:03 -04:00
k8s-ci-robot a57a6de4a8
Merge pull request #5139 from justinsb/fix_subnet_egress_indexing
Fix issue where we assumed that private zone were in order
2018-06-09 09:27:01 -07:00
Rodrigo Menezes 4a131f2a50 Implement AdditionalCIDR configuration on non-shared VPCs 2018-06-05 01:12:06 -07:00
Justin Santa Barbara 26b47d85c1 Fix egress dependency ordering bug
We assuming that the zone index was the subnet index, which isn't
generally true (but usually is, by luck)
2018-05-10 13:30:22 -04:00
Justin Santa Barbara cd6808d48e Don't tag shared instances at all
We don't need to (and we can add it later if we do)

Also clean up the Name tag
2018-05-10 12:03:04 -04:00
Aurel Canciu cc8371cb31
Add ability to use ec2 nat instance as egress 2018-05-09 23:04:54 +03:00
Justin Santa Barbara 6e208e2563 Map AdditionalCIDRs from spec
They weren't currently mapped from the cluster spec.
2018-03-25 23:49:34 -04:00
k8s-ci-robot e65b9e3a2a
Merge pull request #4781 from justinsb/elasticip_tags
Tag ElasticIP when owned
2018-03-24 22:56:10 -07:00
Justin Santa Barbara 4d10cc82e9 Always tag ElasticIP
Currently we were only tagging it if shared, but tagging for owned
objects has fewer downsides.
2018-03-24 23:57:12 -04:00
Justin Santa Barbara ba4b83716c Tag InternetGateways with consistent tags 2018-03-24 21:28:41 -04:00
k8s-ci-robot c42ed7a9da
Merge pull request #4710 from justinsb/dont_tag_shared_vpcs
Don't tag shared VPCs
2018-03-19 12:57:59 -07:00
Justin Santa Barbara 7f855b28c7 Don't tag shared VPCs
Fix #4265
2018-03-18 17:21:07 -04:00
Justin Santa Barbara 6ff56e2f05 Fix shared network objects
RouteTables should be created (and owned) only for non-shared subnets.
2018-03-18 17:09:30 -04:00
Justin Santa Barbara 785cc81b94 Make Egress test a prefix test
Should be equivalent, but a little more correct.
2018-03-15 20:11:54 -04:00
Justin Santa Barbara 110c1a2aa7 Find RouteTable by cluster & role tag
Once we dropped the Name tag,we have no way to find RouteTables
otherwise.
2018-03-15 20:11:54 -04:00
Mike Splain 7bd39bd9e7 Tag nat gateways 2018-03-08 13:09:59 -05:00
k8s-ci-robot 3b78618327
Merge pull request #4302 from sethpollack/eip
Add option for using existing EIP's
2018-02-27 22:27:46 -08:00
chrislovecnm f758919f21 Adding additional tags to various AWS components
This PR adds the base tags to DHCP Options, IGW, and Route Tables.
These components are not tagged correctly, and this can cause issues
with deletion. Name tags are not added to shared resources, as we allow
shared resources to have maintained names.  A owned/shared tags with the
syntax  "kubernetes.io/cluster/$CLUSTERNAME" = "owned" is added to the
resources as well.  We are maintaining the Name tag value for private
route tables, as these resources do not use the standard value.
2018-02-23 14:02:50 -07:00
Seth Pollack 3ae8ac1329 add option for BYOEIP 2018-02-16 12:08:05 -05:00
Kashif Saadat 5850b434b4 Add SubnetType Tag to Subnets 2018-01-08 10:53:58 +00:00
Justin Santa Barbara a7f82a6380 Fix shared subnet/vpc tags
* Stop setting the Name tag on a shared subnet/vpc

* Stop setting the legacy KubernetesCluster tag on a shared subnet/vpc
that is new enough (>=1.6); we rely on the shared tags instead

* Set tags on shared subnets; i.e. we _do_ set the shared tag on a
shared subnet; that is important for ELBs

* Set tags on shared VPCs; i.e. we _do_ set the shared tag on a shared
VPC; that is not used but consistent with subnets.

* Add tests for shared subnet
2017-10-23 11:30:25 -04:00
Eric Hole 742278be01 First pass 2017-10-22 11:47:35 -07:00
chrislovecnm f00ee27dbe adding missing lifecycle to route table task 2017-10-12 11:55:50 -06:00
Justin Santa Barbara 3dfe48e5ae Wiring up lifecycle 2017-07-15 22:03:54 -04:00
Justin Santa Barbara 383c2bf5ed Use explicit tag management in network tasks
This lets us use the new shared cluster tags, for shared networking
objects - in particular subnets.

We continue to add the existing tags also, for compatability. When we
add direct management of shared networks, we will likely address that.
2017-05-01 22:55:27 -04:00
Justin Santa Barbara cb4641fea3 Code updates 2017-03-16 02:40:50 -04:00
Justin Santa Barbara ba5434caf0 Relax DNS requirements on shared VPCs
Don't require EnableDNSHostnames on a shared VPC in >= 1.5.0

Create a feature flag for tolerating EnableDNSSupport=false.

Issue #786
2017-01-29 00:09:09 -05:00
Justin Santa Barbara 3185d115cb Don't create route table at all if all subnets are shared
We don't link it up anyway, so we shouldn't try to create it
2017-01-24 11:13:05 -05:00
Justin Santa Barbara 686e4efa3b Egress follow up
* Round trip to v1alpha1
* Enable test
2017-01-20 00:40:41 -05:00
Eric Hole 1e3d94392c Major redo/squash of the work to get egress added to the API and hooked up.
One commit from the always incredible @kris-nova was incorporated here, it was to
check for tags in `kutil/delete_cluster.go`. She was a major driver and instrumental in getting
this to where we aere now!
2017-01-19 16:57:42 -05:00
Kris Nova d41c655d9f Adding notes from call 2017-01-17 09:35:38 -07:00
Eric Hole bcaf929256 Rebased the new EIP/NGW code and integrated with 1282 code. Working CI. 2017-01-08 13:20:32 -05:00
Eric Hole 0f84494dbd Merge branch 'master' into kris-and-eric-1282 2017-01-08 11:10:13 -05:00
Eric Hole 3de7bfb93f First pass at Shared NGW docs. 2017-01-08 09:35:56 -05:00
Eric Hole cab1251161 New API fields ngwId and ngwEip. 2017-01-08 09:35:20 -05:00
Justin Santa Barbara 8cdd8bb7da Discover existing ElasticIP & NatGateway without tagging
This should allow for round-tripping with terraform (which can't
practically do remote-resource tagging)
2017-01-08 01:52:15 -05:00
Kris Nova 1b769b48c8 Adding notes from our meeting 2017-01-04 10:01:51 -07:00
Justin Santa Barbara 50296f1a30 Fix file headers 2016-12-19 00:23:20 -05:00
Justin Santa Barbara a03ea54365 Rename SubnetName -> Name
No schema impact
2016-12-19 00:01:38 -05:00
Justin Santa Barbara 4475d68c2e Remove dead code 2016-12-18 21:56:57 -05:00
Justin Santa Barbara fed68310fa Schema v1alpha2
* Zones are now subnets
* Utility subnet is no longer part of Zone
* Bastion InstanceGroup type added instead
* Etcd clusters defined in terms of InstanceGroups, not zones
* AdminAccess split into SSHAccess & APIAccess
* Dropped unused Multizone flag
2016-12-18 21:56:57 -05:00