Commit Graph

6 Commits

Author SHA1 Message Date
Peter Rifel c187cefec2 Move utility functions into common.sh 2020-02-15 20:03:26 -06:00
Ciprian Hacman 4c4400c5f3 Add code simplifications for staticheck 2019-12-30 17:40:24 +02:00
tanjunchen cc0f7022f0 /hack: improve shell script in hack 2019-12-25 17:16:31 +08:00
Peter Rifel c6dbe9d686 Remove make command from verify-staticcheck.sh
This script should now be called using `make verify-staticcheck` which will handle the go-bindata dependency.
2019-12-23 09:25:42 -06:00
Peter Rifel ef8f07c451 Fix verify-staticcheck prow job
The new job was missing the generated files from go-bindata.

I noticed some of the prow jobs use make and others call hack/ scripts directly.

I think it'd be better to use make so we can more easily add dependencies like this, therefor I'd like to propose that we merge this, update the jobs to call make targets, then remove the make command I added to hack/verify-staticcheck.sh

By fixing the existing job as well as the make target, we can unblock other PRs and not get another swarm of failure notifications when the job gets updated to use make.
2019-12-22 15:03:29 -06:00
Peter Rifel 974a1c6b3c Add verify-staticcheck script mostly copied from kubernetes/hack/verify-staticcheck.sh 2019-09-27 11:58:33 -07:00