Commit Graph

141 Commits

Author SHA1 Message Date
Bharath Vedartham 7067f5f47a instancegroups: Ignore validation errors in unrelated instance groups
When unrelated instance groups produce validation errors, the instance group
being updated produces a failure and is forced to wait for rolling update to continue.

This can be avoided as failures in different node instance groups usually don't affect
the instance group being affected in any way.
2020-10-31 19:17:24 +05:30
Ciprian Hacman e0332177b3 Skip failing test 2020-10-15 07:46:47 +03:00
Srikanth Rao 4d251fe900
[Digital Ocean] Implement Delete Instance logic for rolling update (#10000)
* Add delete Instance implementation for DO

* Add warning for DeleteInstance usage

* Use reconcile option for rolling update

* Update pkg/instancegroups/instancegroups.go

Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>

Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
2020-10-13 10:06:27 -07:00
Ole Markus With aa66c4f6d8 Add rolling upgrade to openstack 2020-10-01 20:07:44 +02:00
Ole Markus With a39beb20c8 Rolling update test for OS 2020-10-01 20:07:44 +02:00
Ole Markus With 63f13322d5 Don't pass ctx and cluster everywhere 2020-09-23 08:30:24 +02:00
Ole Markus With 0ec71686b9 Refactor cloudinstancegroupmember in a more independent cloud instance representation
Apply suggestions from code review

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
2020-08-30 21:37:03 +02:00
Ole Markus With ff6c04938d Add kops delete instance command
Add support for deleting instance by k8s node name

Add yes flag
2020-08-28 08:43:30 +02:00
Peter Rifel 4d9f0128a3
Upgrade to klog2
This splits up the kubernetes 1.19 PR to make it easier to keep up to date until we get it sorted out.
2020-08-16 20:56:48 -05:00
Ciprian Hacman 5a9cc3d216 Fix int to string conversions 2020-07-26 09:09:52 +03:00
Kubernetes Prow Robot 219147e2f4
Merge pull request #9348 from johngmyers/rollingupdate-disable
Create separate field for disabling rolling updates
2020-07-02 09:08:47 -07:00
John Gardiner Myers 494209884a Rolling update instance groups in consistent order 2020-06-20 10:58:06 -07:00
John Gardiner Myers cc2b647d06 Create separate field for disabling rolling updates 2020-06-19 22:19:26 -07:00
ZouYu 2fc52ec6be fix some go-lint warning
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-06-09 08:52:50 +08:00
Kubernetes Prow Robot 2a613f1331
Merge pull request #9165 from johngmyers/retry-initial
Try validating multiple times before updating instancegroup
2020-05-29 12:07:33 -07:00
John Gardiner Myers 091893fd20 Simplify rolling update internal methods 2020-05-29 10:52:03 -07:00
John Gardiner Myers dd884a6a64
fix missing space
Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
2020-05-29 10:35:15 -07:00
John Gardiner Myers 7756be7fbc Try validating multiple times before updating instancegroup 2020-05-22 20:26:02 -07:00
John Gardiner Myers af90ecdddf Reduce test flakiness 2020-05-22 19:33:01 -07:00
John Gardiner Myers df7e0b18b6 Ignore already-deleted nodes during rolling update 2020-04-26 21:41:54 -07:00
Justin Santa Barbara ffb6cd61aa Rolling-update validation harmonization
This is a follow-on to #8868; I believe the intent of that was to
expose the option to do more (or fewer) retries.

We previously had a single retry to prevent flapping; this basically
unifies the previous behaviour with the idea of making it
configurable.

* validate-count=0 effectively turns off validation.

* validate-count=1 will do a single validation, without flapping
  detection.

* validate-count>=2 will require N succesful validations in a row,
waiting ValidateSuccessDuration in between.

A nice side-effect of this is that the tests now explicitly specify
ValidateCount=1 instead of setting ValidateSuccessDuration=0, which
had the side effect of doing the equivalent to ValidateCount=1.
2020-04-17 01:40:02 -04:00
Justin Santa Barbara 31bb16d4d1 Add context.Context to most signatures
The client-go signature for most methods adds a context.Context
object, and also makes Options mandatory.  Feed through a
context.Context through many of our methods (but use context.TODO to
stop it getting totally out of hand!)
2020-04-11 14:44:17 -04:00
Jesse Haka 11eaacd53e validationtimes -> validationcount 2020-04-08 13:55:29 +03:00
Jesse Haka e1e79790ef validate cluster n times in rolling update 2020-04-08 13:55:24 +03:00
John Gardiner Myers ea3b8d7710 make gomod 2020-04-05 10:22:51 -07:00
John Gardiner Myers 6844eef4ca Switch to the k/k implementation of drain.Helper 2020-04-05 10:22:49 -07:00
Peter Rifel a999b3ea61 fix OWNERS labels format
These need to be lists
2020-03-10 22:47:50 -05:00
Kubernetes Prow Robot 8ecc5edb73
Merge pull request #8272 from johngmyers/need-update-annotation
Support the kops.k8s.io/needs-update annotation on nodes
2020-03-10 09:01:35 -07:00
Kubernetes Prow Robot db435ee7cd
Merge pull request #8717 from rifelpet/owners-labels
Add labels to OWNERS files
2020-03-10 08:23:51 -07:00
Peter Rifel 237a125f2c Add labels to OWNERS files
This will automatically label PRs that touch these directories.

This makes it easier to query GitHub for PRs that affect certain areas of the code.

I mostly used existing labels but created some new ones as well.
2020-03-10 08:35:58 -05:00
John Gardiner Myers 33e23166e4 Support the kops.k8s.io/needs-update annotation on nodes 2020-03-09 22:43:09 -07:00
John Gardiner Myers 03eb8246c7 Refactor/simplify rolling update 2020-03-09 11:05:58 -07:00
John Gardiner Myers e104cdb982 Default maxSurge to 1 on AWS 2020-03-04 19:41:51 -08:00
John Gardiner Myers 99100dc4a0 Fix flaky test 2020-03-03 20:54:22 -08:00
John Gardiner Myers ed73726195 Address review comments 2020-02-28 21:05:43 -08:00
John Gardiner Myers 38b7219b14 Remove code made unnecessary by apimachinery validation 2020-01-27 20:45:17 -08:00
John Gardiner Myers ebfcf5d909 Implement recovery from previous failed surge rolling updates 2020-01-27 20:45:16 -08:00
John Gardiner Myers cee662d521 Implement MaxSurge happy path 2020-01-27 20:45:16 -08:00
John Gardiner Myers 4ddc58ca5e Add MaxSurge to resolveSettings 2020-01-27 20:45:16 -08:00
John Gardiner Myers 640f5f5b74 Terminate AWS instances through EC2 instead of Autoscaling 2020-01-27 20:15:10 -08:00
John Gardiner Myers d56ad41334 Address review comments 2020-01-26 14:18:51 -08:00
John Gardiner Myers 5f72d12132 Reduce test flakiness 2020-01-12 21:27:55 -08:00
John Gardiner Myers 10d6416b8e Allow MaxConcurrency for masters and bastions 2020-01-11 18:50:35 -08:00
John Gardiner Myers 0c3651c9c8 Implement MaxUnavailable 2020-01-05 12:09:55 -08:00
John Gardiner Myers 0952374027 Extract maybeValidate 2020-01-05 12:09:55 -08:00
John Gardiner Myers 91f4920537 Extract drainTerminateAndWait() 2020-01-05 12:09:55 -08:00
John Gardiner Myers adaf903b90 Create resolveSettings 2020-01-05 12:09:54 -08:00
Kubernetes Prow Robot 121d9f461f
Merge pull request #7909 from johngmyers/remove-drain-feature-flag
Remove DrainAndValidateRollingUpdate feature flag
2020-01-05 11:15:40 -08:00
Kubernetes Prow Robot a22af4fa80
Merge pull request #8239 from johngmyers/simplify-rolling
Simplify code for rolling updates of nodes
2020-01-04 13:13:40 -08:00
John Gardiner Myers 01dd793604 Specify number of NotReady instances in makeGroup() parameter 2020-01-04 10:47:08 -08:00