Commit Graph

81 Commits

Author SHA1 Message Date
John Gardiner Myers 1d3d5c1d2f pkg/instancegroups - fix static check 2019-12-22 20:56:27 -08:00
Justin Santa Barbara 84835ce0ba
Update pkg/instancegroups/rollingupdate_test.go
Co-Authored-By: John Gardiner Myers <jgmyers@proofpoint.com>
2019-12-17 21:25:18 -05:00
Peter Rifel a24d9b6455
remove more trailing whitespace 2019-12-17 13:03:16 -06:00
Peter Rifel 85a1d23c18
remove trailing whitespace that was breaking gofmt 2019-12-17 12:49:20 -06:00
Justin Santa Barbara 8373c9fc4d tests: increase timeout in rolling update tests
We never know when e.g. a GC is going to delay us, so we need a lot
more padding on these timeouts.
2019-12-17 09:59:21 -05:00
John Gardiner Myers 2850826a52 Improve logging of cluster revalidation 2019-12-13 13:48:47 -08:00
John Gardiner Myers 19e165759b Add unit test for flapping validation 2019-12-13 13:45:21 -08:00
Jesse Haka 44183aef7f validate cluster twice 2019-12-12 08:48:15 +02:00
John Gardiner Myers 1239c05e71 Validate after updating bastion 2019-12-09 18:45:51 -08:00
John Gardiner Myers 2e36124f77 Expose ValidateTickDuration for use by unit tests 2019-12-09 18:43:20 -08:00
Kashif Saadat fcf6f0098c Canal Typha spec and apimachinery 2019-12-06 15:36:48 +00:00
John Gardiner Myers 38b19e53b4 Add a second master to rolling update tests 2019-11-19 16:55:39 -08:00
John Gardiner Myers 8121a84089 Improve rolling update test coverage 2019-11-19 16:55:39 -08:00
John Gardiner Myers cfca6fae10 extract RollingUpdateCluster initialization in rollingupdate tests 2019-11-19 16:55:39 -08:00
John Gardiner Myers d82c834fe3 extract common test setup in rollingupdate tests 2019-11-19 16:55:39 -08:00
John Gardiner Myers 7e8c77a8bf extract CloudInstanceGroup setup in rollingupdate tests 2019-11-19 16:55:36 -08:00
John Gardiner Myers 3d6d6734e5 Make rollingupdate test assertions succinct 2019-11-19 16:45:55 -08:00
Peter Rifel 3dc06afa12 Fix goimports errors
It turns out we werent running verify-goimports in our CI jobs.

While we work to get that enabled, we can at least unblock the releases by doing a one-time fix of the failing goimports
2019-11-19 05:05:02 -08:00
John Gardiner Myers b63cc36f88 Update bazel 2019-11-07 22:59:51 -08:00
Justin Santa Barbara 5a0b199119
Merge branch 'master' into fix-roll-validation 2019-11-07 20:54:10 -05:00
John Gardiner Myers 5b8bed77fa Don't update first node in instancegroup if cluster fails validation 2019-11-04 16:26:39 -08:00
John Gardiner Myers 63e0c5e726 Add tests for cluster validation during rolling update 2019-11-04 16:26:39 -08:00
feifei.zhang@huawei.com 4b49412105 fix golint failures 2019-10-31 20:22:37 +08:00
yuxiaobo 0bd700781e Correct word misspelling 2019-09-29 22:23:07 +08:00
Justin SB 97f552778f
Add env vars, update tests 2019-09-25 12:48:13 -04:00
Justin SB 728e582360
Fill out kops controller functionality
k8s 1.16 requires that we move label setting away from the kubelet, to
a central controller.  kops-controller is that controller.
2019-09-25 12:04:34 -04:00
mikesplain 9e55b8230a Update copyright notices
Also cleans some white spaces
2019-09-09 14:47:51 -04:00
Kubernetes Prow Robot a7ed5ae0fc
Merge pull request #7510 from justinsb/set_delete_local_data
DeleteLocalData on drain
2019-09-03 08:46:29 -07:00
Justin SB 8b02cf14ca
DeleteLocalData on drain
This restores the kops behaviour before the refactor, where pods using
emptyDir would not block the rolling update.
2019-09-03 07:07:44 -07:00
Justin SB 96aa37d03d
Remove unused ClientGetter from Drain code
This is no longer needed now we are using the k8s drain code.
2019-09-03 07:04:37 -07:00
Kubernetes Prow Robot a957428446
Merge pull request #7470 from justinsb/update_to_k115
Update to kubernetes 1.15
2019-08-27 10:24:43 -07:00
Justin SB b1f8f84306
Code changes for 1.15 2019-08-25 16:00:39 -04:00
Jesse Haka b581e7a305 print all failures 2019-08-23 16:06:37 +03:00
Justin SB 76d03b3f71
Generated files: glog -> klog 2019-05-06 12:56:03 -04:00
Justin SB 3e33ac7682
Change code from glog to klog
We don't call klog.InitFlags yet, because that will cause a flag
redefinition error until we get everyone to stop using glog.  That
will happen when we update to k8s 1.13.
2019-05-06 12:54:51 -04:00
Justin SB 78ebe93f9f
Update kubernetes dependencies to 1.13.5
Notable changes:

* openapi-gen moved to k8s.io/kube-openapi/cmd/openapi-gen
* templates moved to k8s.io/kubernetes/pkg/kubectl/util/templates
2019-05-06 09:58:37 -04:00
Derek Lemon -T (delemon - AEROTEK INC at Cisco) 4f0169bb79 codegen 2019-01-16 09:30:40 -07:00
Rodrigo Menezes 2b9243ff8c Getting things ready for when we are ready for 1.12 2018-12-04 18:50:17 -08:00
mikeweiwei 027d324aaf If don't use formatted output,fix logging calls 2018-10-10 19:19:09 +08:00
Bheesham Persaud 65e9a86b39 Fix minor typo. 2018-09-29 02:18:40 -04:00
Justin Santa Barbara 62e8e17077 Code fixes for k8s 1.11 API changes 2018-09-28 20:14:45 -04:00
Justin Santa Barbara e982087e3e Delete nodes from k8s api during rolling-update
This prevents a race where if the new node comes back with the same
name, it will still be cordoned.  This seems to be more likely on GCE.
2018-09-22 16:06:07 -04:00
Mikulas Dite 525c0a9bc8 fix rolling-update prompt when nodeName is unset
Updated to use same logic as DeleteInstance does: print at least the host id
as that is always available and only include node name if set.
2018-08-16 16:12:17 +02:00
Mikulas Dite eab3a7824e fix cloudonly rolling-update ignores interactive 2018-08-16 16:12:17 +02:00
Justin Santa Barbara 3a1ce236d1 Simplify logic around master rolling-update
We were using a waitgroup, but we weren't actually running in parallel.
2018-07-21 23:04:22 -04:00
Deniz Zoeteman 2a69901d52 Add message to error for stopping rolling update after failure 2018-07-17 18:56:31 +02:00
Deniz Zoeteman b06e3efa4d Stop with rolling update if bastions or masters failed to update 2018-07-16 16:56:47 +02:00
Deniz Zoeteman 84796eac0b Fail cluster validation for rolling-update if a failure occurs 2018-07-14 21:41:10 +02:00
Eric Herot 2090479da5 Let people know that stopping an instance can sometimes take a while 2018-06-13 18:21:24 -04:00
Eric Herot 0e47086ff5 Communicate that we're going to wait for stabilization after draining
The wait for this is very long (90s) by default, which is long enough that many users may assume things are hanging if we don't say what they're waiting for.
2018-06-13 18:18:23 -04:00