Commit Graph

21 Commits

Author SHA1 Message Date
Ole Markus With a7f631e7c9 Apply suggestions from code review
Co-Authored-By: Peter Rifel <rifelpet@users.noreply.github.com>
2020-04-16 08:42:59 +02:00
Ole Markus With 869ab75dea Use etcd-manager for the cilium etcd cluster 2020-04-16 08:42:59 +02:00
Peter Rifel fa2d64c3a3 Update expected outputs of terraform tests 2020-04-05 21:24:49 -05:00
Peter Rifel ee86488d98 Don't set terraform's user_data if it is an empty string
Bastion hosts have no user_data by default.
This is not valid in terraform, based on the error messages reported here [0]

The Terraform provider code says user_data is optional for both LaunchConfigurations and LaunchTemplates [1] [2]

This change prevents the user_data property from being added to aws_launch_configuration and aws_launch_template resources unless the string is not empty.

[0] https://travis-ci.org/github/kubernetes/kops/jobs/662472020
[1] 04d24f80f3/aws/resource_aws_launch_configuration.go (L74-L76)
[2] 04d24f80f3/aws/resource_aws_launch_template.go (L510-L512)
2020-03-31 09:33:16 -05:00
Ciprian Hacman 661bd6dfbd Add "owned" tag for all instance groups related resources 2020-03-02 10:39:50 +02:00
Nicolas Vanheuverzwijn eaa025effd run hack/update-expected.sh: we now consistenly output an empty user-data for bastion node 2020-01-13 15:28:20 -05:00
Justin SB 1580d4c82b
Update tests to use k8s >= 1.14
Where tests are using a version of k8s that is now really deprecated,
replace it with k8s 1.14.0.
2019-09-14 13:58:50 -04:00
Justin SB 21cb8ece06
Label AWS ASGs with kops.k8s.io/instancegroup
We will use this to map an AWS instance to the instance group.
2019-09-02 09:26:23 -07:00
Austin Moore 4485b115f4
Default CrossZoneLoadBalancing to false if not set 2019-07-26 12:21:43 -04:00
mikesplain d6c02d3d72 Fix tests 2019-03-29 13:29:11 -04:00
David Archer 36d2282d6b AWS: Enable ICMP Type 3 Code 4 for API server ELBs 2019-01-12 07:20:17 -05:00
Justin Santa Barbara 1c3949bdfe Don't assume that we only have one subnet per AZ
I made a mistaken assumption in
dde2100a19 that we only had one subnet
per AZ, but as demonstrated in #5587 this was not the case.

What I was trying to achieve was not to include the cluster name, so
for the case of subnets this commit just uses the subnet name from the
cluster spec, which should be unique and stable.  That is hopefully at
least as meaningful.

Thankfully we hadn't released a version with the erroneous naming.

Fix #5587
2018-08-13 13:15:03 -04:00
Christian Kampka 00cd85d73e Add autoscaling group ids to terraform module output 2018-07-20 13:15:03 +02:00
Christian Kampka 978f66266c Generate locals for terraform target 2018-07-13 22:28:27 +02:00
Justin Santa Barbara e24aa79aa9 Updated terraform expected test output 2018-06-04 10:52:08 -07:00
k8s-ci-robot 5cda02ca2b
Merge pull request #4695 from vendrov/instnace_monitroing_support
Add support for instance monitoring
2018-03-25 14:17:01 -07:00
k8s-ci-robot 63225eb674
Merge pull request #4784 from justinsb/always_tag_volumes
Make sure volumes are tagged
2018-03-24 23:32:00 -07:00
Justin Santa Barbara 0ce7dbf4bd Update tests for new volume tags 2018-03-25 00:08:24 -04:00
Justin Santa Barbara 0e22bf4ab5 Update tests for new security group tags 2018-03-24 22:19:59 -04:00
devops d734f35126 Add support for instance monitoring
Add API backward comptability

Add api generated files

documenting detailed-monitoring

instance-group json typo

Update test expected result
to support enable_monitroing

Add instance-monitroing support to CF

Improve doc, test and rename InstanceMonitoring

Rename instnace-monitoring to fit the YAML kops form

typo detailedInstanceMonitoring
2018-03-21 23:06:38 +02:00
Justin Santa Barbara 6ff56e2f05 Fix shared network objects
RouteTables should be created (and owned) only for non-shared subnets.
2018-03-18 17:09:30 -04:00