Commit Graph

264 Commits

Author SHA1 Message Date
chrislovecnm f758919f21 Adding additional tags to various AWS components
This PR adds the base tags to DHCP Options, IGW, and Route Tables.
These components are not tagged correctly, and this can cause issues
with deletion. Name tags are not added to shared resources, as we allow
shared resources to have maintained names.  A owned/shared tags with the
syntax  "kubernetes.io/cluster/$CLUSTERNAME" = "owned" is added to the
resources as well.  We are maintaining the Name tag value for private
route tables, as these resources do not use the standard value.
2018-02-23 14:02:50 -07:00
Justin Santa Barbara b68f58d746 Change NewAssetBuilder to take a kops.Cluseter 2018-02-22 21:42:40 -08:00
k8s-ci-robot 87fbb349c6
Merge pull request #4469 from justinsb/update_metrics
Support updating autoscaling metrics
2018-02-20 00:54:38 -08:00
Justin Santa Barbara 6e562e0742 Support updating autoscaling metrics 2018-02-20 00:53:24 -05:00
chrislovecnm e6b9a15be5 adding new generated tasks 2018-02-19 13:27:07 -07:00
Kenji Kaneda aacbde4aac upup: Make RenderTerraform handle an error from AddOutputVariableArray 2018-02-08 00:27:27 -08:00
k8s-ci-robot e299ff29d7
Merge pull request #4342 from johanneswuerbach/enable-asg-metrics
Enable metrics for AutoScalingGroups
2018-01-26 04:39:30 -08:00
Johannes Würbach 02855fc13f
Enable metrics for AutoScalingGroups
Those metrics simplify monitoring the created ASGs and are free [0].

Enable them by default.

[0] https://aws.amazon.com/about-aws/whats-new/2016/08/free-auto-scaling-group-metrics-with-graphs/
2018-01-25 20:06:10 +01:00
Justin Santa Barbara 9919254205 AWS LaunchConfiguration error handling fix
We would loop forever on an unexpected error.
2018-01-25 08:35:15 -05:00
Jeff Grafton dcb7c96b84 run make bazel-gazelle 2018-01-19 14:32:50 -08:00
Kashif Saadat e315c350be Implement ability to update Load Balancer subnets 2018-01-17 11:57:29 +00:00
chrislovecnm 4dd3bb1dea Updating bazel BUILD files with new go_rules version 2017-12-29 15:03:14 -07:00
chrislovecnm 7057aaf1bb Enabling the file assets
File assets and the SHA files are uploaded to the new location. Files
when are users uses s3 are upload public read only. The copyfile task
uses only the existing SHA value.

This PR include major refactoring of the use of URLs.  Strings are no
longer categnated, but converted into a URL struct and path.Join is
utlilized.

A new values.go file is included so that we can start refactoring more
code out of the "fi" package.

A
2017-12-17 15:26:57 -07:00
Justin Santa Barbara a8a83f3ce9 Update gazelle 2017-12-14 01:31:28 -05:00
Kubernetes Submit Queue 7bd0a6a703
Merge pull request #3898 from rdrgmnzs/additional_cidr
Automatic merge from submit-queue.

Add additionalNetworkCIDRs to support VPCs with multiple CIDRs in AWS

Add additionalNetworkCIDRs to support VPCs with multiple CIDRs in AWS.

@justinsb I cannot find anywhere that does a check on an existing VPC to see if the networkCIDR matches what is on the VPC defined, I was looking for that so I can add a similar check for this. Am I missing something or is there really no check like that?
2017-12-13 18:25:41 -08:00
Peter Rifel 3da1bdc069 Don't report an InternetGateway rename when using shared IGWs
Adds test to confirm fixed behavior
2017-12-06 16:36:35 -08:00
Rodrigo Menezes f908dcb3bf Check and docs 2017-11-26 20:37:16 -08:00
chrislovecnm 609e268a1d gazelle updates with new bazel version 2017-11-05 17:41:53 -07:00
chrislovecnm 1e418c3e13 more goimport updates 2017-11-04 10:03:02 -06:00
chrislovecnm 4fd4bb8d0e subnet test not correct, not sure now 2017-11-01 13:48:12 -06:00
chrislovecnm 8d1ee1fa16 updating files for goimports 2017-11-01 12:51:43 -06:00
Kubernetes Submit Queue 08c34b6eb4
Merge pull request #3184 from justinsb/test_does_not_change_tags
Automatic merge from submit-queue.

Fix shared subnet/vpc tags
2017-11-01 08:23:29 -07:00
Justin Santa Barbara b2bcba4a6d GCE: Use object-level permissions for files in GCS
This lets us configure cross-project permissions while ourselves needing
minimal permissions, but also gives us a nice hook for future lockdown
of object-level permissions.
2017-10-29 19:17:00 -04:00
Justin Santa Barbara 9cf22aeeef Sort Tags consistently to avoid test flakes 2017-10-23 11:39:18 -04:00
Justin Santa Barbara a7f82a6380 Fix shared subnet/vpc tags
* Stop setting the Name tag on a shared subnet/vpc

* Stop setting the legacy KubernetesCluster tag on a shared subnet/vpc
that is new enough (>=1.6); we rely on the shared tags instead

* Set tags on shared subnets; i.e. we _do_ set the shared tag on a
shared subnet; that is important for ELBs

* Set tags on shared VPCs; i.e. we _do_ set the shared tag on a shared
VPC; that is not used but consistent with subnets.

* Add tests for shared subnet
2017-10-23 11:30:25 -04:00
Justin Santa Barbara e063af8d5a Sort terraform literals in ELB task
Fixes #3578
2017-10-11 00:01:11 -04:00
Justin Santa Barbara 0143be7c4f autogen: BUILD and BUILD.bazel 2017-10-02 14:27:21 -04:00
Patrick Harböck 8db87d20cd Check actual EbsOptimized status during cluster update 2017-08-30 00:30:00 +02:00
Kubernetes Submit Queue 0eabaa863f Merge pull request #3207 from KashifSaadat/delete-old-cloud-labels
Automatic merge from submit-queue

Delete old tags when cloudLabels / labels / taints are removed

If you remove custom cloudLabels/labels/taints from the cluster configuration, kops does not correctly update the AWS resources to delete the tags. This seems to be because it only calls the AWS API method `CreateOrUpdateTags`, which won't remove tags that aren't in the supplied list.

The current behaviour is that every `kops update cluster` will show a tag difference but never successfully apply the changes (remove the extra tags).

This PR will perform a diff of the current and expected tags, and call the `DeleteTags` API if there are any tags to delete.
2017-08-21 10:53:14 -07:00
Kashif Saadat b79f310d6b Set lifecycle on ElasticIP and NAT Gateway tasks to avoid spurious changes 2017-08-21 08:43:59 +01:00
Kubernetes Submit Queue 9c86800207 Merge pull request #3085 from chrislovecnm/file-asset-tasks
Automatic merge from submit-queue

starting work on file assets builder

I refactored to the dockerassets pkg to assetstasks, in order to not add yet another package.  Added file copy task, that I have tested with s3 locally, but not certain how to add memfs tests.

Fixes: https://github.com/kubernetes/kops/issues/3086
2017-08-20 08:21:06 -07:00
Kashif Saadat 1574b19798 Correctly delete cloud labels that are no longer present in the expected resources (cloudLabels, labels, taints). 2017-08-19 09:19:02 +01:00
Kubernetes Submit Queue a3fdefa74c Merge pull request #3041 from justinsb/it_shared_vpc_and_subnet
Automatic merge from submit-queue

Add integration tests for shared subnet & VPC
2017-08-18 15:55:53 -07:00
chrislovecnm ee17e6567c starting work on file assets builder 2017-08-18 13:04:12 -06:00
Kashif Saadat 34486b027c Correctly set lifecycle on DNSName, LoadBalancer and LoadBalancerAttachment resources 2017-08-17 10:42:38 +01:00
Ionut Craciunescu 07397ec2f0 ran make gofmt 2017-08-01 00:34:39 +01:00
Ionut Craciunescu 66d377f5c4 comment update 2017-08-01 00:28:59 +01:00
Ionut Craciunescu 4d27d5d93c small docs fixes 2017-08-01 00:28:38 +01:00
Ionut Craciunescu 847bf0c2e1 updates to support aws disks with provisioned iops 2017-08-01 00:28:21 +01:00
Justin Santa Barbara 64f0920c8b Add integration tests for shared subnet & VPC 2017-07-24 10:37:07 -04:00
Justin Santa Barbara 3dfe48e5ae Wiring up lifecycle 2017-07-15 22:03:54 -04:00
Justin Santa Barbara 3e1ce4f950 Add Lifecycle 2017-07-15 22:01:03 -04:00
Lars Lehtonen 6cf856d972
Fix swallowed errors in upup subdirectory. 2017-07-15 11:43:24 -07:00
Justin Santa Barbara 1965a4be49 Updates to fix unit tests 2017-07-08 18:46:01 -04:00
Austin Moore 6ec64704e2 Remove unnecessary json tag on field 2017-06-30 12:05:59 -04:00
Austin Moore f4c7c61fae Add field to enable EBS Volume Optimization 2017-06-27 16:15:54 -04:00
Chris Love 1f33b7dad7 Merge pull request #2701 from justinsb/more_info_on_iam_failure
Add more logging on IAM failure
2017-06-20 13:46:53 -06:00
Justin Santa Barbara 48b26d0f93 Add more logging on IAM failure
I hit an odd IAM failure yesterday, and this information would have been
helpful.  It only proved a negative - it turned out to be an AWS problem
that was solved by deleting and recreating the IAM roles - but still
makes diagnosis much easier.
2017-06-20 00:42:17 -04:00
Justin Santa Barbara 9d40b0e6ca Support internal (gossip) names for AWS also 2017-06-19 14:16:35 -04:00
Justin Santa Barbara 57bae22e31 Fix to avoid spurious updates 2017-05-16 11:28:52 -04:00