Commit Graph

380 Commits

Author SHA1 Message Date
justinsb 2a9343a168 Generate revisions of NLB objects, and introduce cleanup phase
This lets us safely make changes to otherwise immutable fields, in
particular for adding security groups to NLBs created without them.

We detect the older versions, and create deletion tasks to remove
them.  These tasks can be deferred, and we expect them to be
deferred to a "prune" phase that runs after cluster apply.

Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
2024-02-17 11:41:15 -05:00
Kubernetes Prow Robot 8f71e68d68
Merge pull request #16339 from justinsb/refactor_targetgroups
target group: refactor discovery into awsup
2024-02-14 14:33:00 -08:00
justinsb eb27e30153 target group: refactor discovery into awsup
This sets us up to support multiple generations of target groups,
needed if we want to support adding SecurityGroups to the NLB.
2024-02-14 15:48:50 -05:00
justinsb d50f1968a9 deletion: tolerate concurrent SQS queue deletion
Ignore the not-found error.
2024-02-10 14:29:45 -05:00
Ciprian Hacman 1bbd3e446f azure: Migrate resources to new SDK version 2024-02-09 05:14:38 +02:00
justinsb 314e2b954b Refactor: Move NLB listing function into awsup
As pruning becomes more a part of tasks, there is more overlap between
`kops update cluster` and `kops delete cluster`.
2024-01-30 04:43:48 +02:00
justinsb 2fb39dedc8 toolbox dump: output correct type for target groups
We were previously outputing them with the load-balancer target value.
2024-01-27 13:22:38 -05:00
Kubernetes Prow Robot e5c4fe80df
Merge pull request #16266 from borg-land/dump-patch
Fix dumping logs for GCE scale tests
2024-01-26 20:49:50 +01:00
justinsb 6871aa7148 Refactor: Plumb context through GCE firewallRule methods
Helps with more coherent tracing/logging.
2024-01-26 10:51:34 -05:00
upodroid 4717450b1c fix dumpling logs for GCE scale tests 2024-01-20 13:33:04 +00:00
Ciprian Hacman fd86a0cb9d aws: Ignore InvalidRouteTableID.NotFound errors during cluster deletion 2024-01-15 06:04:30 +02:00
Ciprian Hacman d71879f023 aws: Terminate ASG instances in batches of 100 instances 2024-01-13 11:01:30 +02:00
Ciprian Hacman 005b693943 Revert "aws: Skip deleting ASG instances without volumes" 2024-01-12 18:07:10 +02:00
Ciprian Hacman 03c109b74b Make cluster deletion configurable 2024-01-07 07:15:25 +02:00
Ciprian Hacman 793086a01a aws: Skip deleting ASG instances without volumes 2024-01-06 09:31:23 +02:00
justinsb f79d2da6f6 Thread context through some slower AWS tasks
There are still too many context.TODOs here for this to join all the
way up, but we should be able to better understand the slowest tasks.
2023-11-09 08:17:10 -05:00
justinsb cffd473eb0 dump: include AWS route table objects 2023-11-06 07:50:35 -05:00
justinsb a6b963b127 dump: actually dump the gateway objects
I had forgotten to populate the object itself, so it was not appearing
in the raw dump.
2023-10-29 08:13:43 -04:00
justinsb 094b57aa8e dump: include the various gateways on AWS
I think we were leaking egress-only-internet-gateways, it would be
helpful to see their status in the dump.
2023-10-28 16:23:38 -04:00
Mia-Cross e12f3dc07b
scaleway: terraform support (#15892)
* tasks dependencies

* FindAddresses should proceed even if LBID is empty

* refacto instance: handle several instances in IG + volumeSize in model

* refacto lb_backend: set servers' IPs in backend task rather than instance

* dns changes for tf support

* render Scaleway s3 objects + add zone to outputs

* add terraform support to documentation

* new instance unique name should be given according to actual instances names

* avoid untimely changes in tf + tag instance IPs to avoid orphaned IPs at cluster deletion

* update integration tests

* review comments

* add IPs to the resources to be deleted with the cluster

* add task + model for DNS record
2023-09-29 04:22:42 -07:00
Ciprian Hacman 1aecb5304d aws: Filter ENI list by VPC 2023-09-23 05:25:56 +03:00
upodroid 352566cf42 handle 404s properly from service accounts API 2023-09-11 18:43:59 +01:00
Peter Rifel 54c99b5ea6
Filter for unattached ENIs, matching the client-side filtering we do afterwards
Signed-off-by: Peter Rifel <pgrifel@gmail.com>
2023-09-06 21:38:34 -05:00
Peter Rifel 7ec30b4a98
Paginate DescribeNetworkInterfaces calls
This should help with VPCs containing large numbers of ENIs

Signed-off-by: Peter Rifel <pgrifel@gmail.com>
2023-09-06 21:38:25 -05:00
justinsb d9377e4e56 gce: don't logspam when next-route-hop is starting
Observed this when a machine was first starting up.
2023-08-19 13:08:15 -04:00
Ciprian Hacman 8a2f74ce46 aws: Ignore volumes set to delete on instance termination 2023-08-14 18:47:38 +03:00
Ciprian Hacman d382b0e44f azure: Add support for NAT gateway 2023-08-03 07:12:51 +03:00
Kubernetes Prow Robot 2d0f2387b0
Merge pull request #15721 from rifelpet/eb
Rename eventbridge rule in toolbox dump output
2023-07-30 08:46:00 -07:00
Peter Rifel e0c3b8cd36
Rename eventbridge rule in toolbox dump output
`eventbridge` itself is too generic given there are many resource types within the eventbridge service
2023-07-30 09:25:40 -05:00
Ciprian Hacman 10fa740e3d azure: Add support for application security groups 2023-07-30 14:40:14 +03:00
justinsb 3cce79d4e4 gce: Refactor resource labeling
Create a more strongly-typed label object and use it when labeling
cluster resources.
2023-07-28 23:48:41 -04:00
Ciprian Hacman 5be7a26211 azure: Use k8s.io/utils/set.Set[string] 2023-07-17 05:36:12 +03:00
Ciprian Hacman 704daec524 azure: Move ID parsing from `azuretasks` to `azure` utils 2023-07-11 12:55:48 +03:00
Ciprian Hacman 344d5b36c8 azure: Add mode dependency logic to deletion 2023-07-11 12:24:10 +03:00
Ciprian Hacman 4fe84705a5 azure: Add support for network security groups 2023-07-01 10:06:25 +03:00
Leïla MARABESE 62e3495b1a scaleway dns provider + tests 2023-06-19 11:40:08 +02:00
John Gardiner Myers 1e7576c9c5 Upgrade external-dns to v0.13.5 2023-05-30 17:47:59 -07:00
Jesse Haka e7d27bbf15 openstack designate changes 2023-05-17 20:24:01 +03:00
justinsb 1ad3f6012c hetzner: add dependency logic to deletion
This avoids warnings about deleting e.g. the volume while it is still
attached to a server.

Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
2023-02-13 08:55:12 -05:00
Kubernetes Prow Robot 24a83acb66
Merge pull request #15128 from justinsb/do_no_empty_ips
digitalocean: don't print empty IP addresses
2023-02-11 17:49:31 -08:00
justinsb c7ed41ca70 digitalocean: don't print empty IP addresses
Now we have some IPv6 support, we were printing an empty address when
machines did not have an IPv6 address.
2023-02-11 13:25:43 -05:00
justinsb 312ee7fefc hetzner: support toolbox dump of instances
Makes for easier debugging.
2023-02-11 10:55:54 -05:00
Leïla MARABESE 0fca23addd list and delete load-balancers 2023-01-26 17:12:46 +01:00
Kubernetes Prow Robot 0f5fc06cec
Merge pull request #14771 from johngmyers/sqs-rebalance
Don't drain on rebalance recommendations in SQS mode unless configured
2022-12-17 07:15:42 -08:00
Leïla MARABESE ef8648e12c scaleway: list and delete resources 2022-12-15 14:29:29 +01:00
John Gardiner Myers 55b46073b7 Don't drain on rebalance recommendations in SQS mode unless configured 2022-12-11 18:21:43 -08:00
Ciprian Hacman 141f6065f9 Don't pass region to ListResources 2022-12-05 09:40:38 +02:00
Ciprian Hacman f7d434ee2c Refactor ListResources to not require passing the Cluster object 2022-12-05 09:10:58 +02:00
Kubernetes Prow Robot 2e231fcbd9
Merge pull request #14704 from hakman/owners_update
Update OWNERS files
2022-12-02 10:01:53 -08:00
Ciprian Hacman 4868c2bfaf aws: Skip Route53 cleanup for clusters without DNS 2022-12-02 10:57:37 +02:00