Commit Graph

70 Commits

Author SHA1 Message Date
John Gardiner Myers eb94877ee9 Revert move to explicit dependencies
The change to explicit dependencies lost the dependencies
that were previously found by reflection.
2020-07-20 22:10:46 -07:00
John Gardiner Myers 87446f8894 Make all users of userdata declare it as a dependency 2020-06-26 10:31:52 -07:00
Peter Rifel 964d402eb5
Store terraform launchtemplate userdata in plaintext rather than b64
This makes it easier to grok the userdata contents
2020-06-16 16:53:49 -05:00
Peter Rifel 04a5ead08e Add cty field tags to Terraform structs 2020-04-05 21:18:02 -05:00
Peter Rifel ee86488d98 Don't set terraform's user_data if it is an empty string
Bastion hosts have no user_data by default.
This is not valid in terraform, based on the error messages reported here [0]

The Terraform provider code says user_data is optional for both LaunchConfigurations and LaunchTemplates [1] [2]

This change prevents the user_data property from being added to aws_launch_configuration and aws_launch_template resources unless the string is not empty.

[0] https://travis-ci.org/github/kubernetes/kops/jobs/662472020
[1] 04d24f80f3/aws/resource_aws_launch_configuration.go (L74-L76)
[2] 04d24f80f3/aws/resource_aws_launch_template.go (L510-L512)
2020-03-31 09:33:16 -05:00
Austin Moore 4a88f7b5a5
Add ability to specify no ssh key by setting sshKeyName to empty
Add tests for no ssh key functionality

Add docs for setting no ssh key

Disable sshKey rendering for cloudformation if nosshkey is set

Fix broken test

make goimports

Fix

Formatting fix

Update kubernetes version for tests

Update expected test output

Fix imports in mesh.pb.go

Run hack/update-expected.sh

Change digital ocean logic to handle *string for SSHKeyName

Fix expected output

Missed a few
2020-01-15 15:24:32 -05:00
Gabriel Tiossi ad2b315c4e feat(awstasks): Support EBS DeleteOnTermination
Change BDM behavior when finding Launch Configuration and generating
Cloudformation/Terraform
2019-12-03 04:08:03 -03:00
yuxiaobo 3b4cd437ed Correct spelling mistakes
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-11-13 17:28:28 +08:00
mikesplain 9e55b8230a Update copyright notices
Also cleans some white spaces
2019-09-09 14:47:51 -04:00
Justin SB 3e33ac7682
Change code from glog to klog
We don't call klog.InitFlags yet, because that will cause a flag
redefinition error until we get everyone to stop using glog.  That
will happen when we update to k8s 1.13.
2019-05-06 12:54:51 -04:00
Mathieu b7c3da2595 Carry Provisioned IOPS to Terraform and CloudFormation templates 2019-04-13 15:03:10 +10:00
Rohith 770cde669f - fixing up the root volume detection, similar to what we did on additional volumes 2019-02-04 14:27:37 +00:00
Rohith 74af751dc6 - fixing up the conflicts post the additional volumes merge 2019-02-04 14:15:16 +00:00
Rohith e2574f3938 - splitting out the code per target
- adding some unit testing for the terraform render
- adding the terraform render, updating the autoscaling and creating the launchtemplate
2019-02-04 12:00:04 +00:00
Rohith 684caa54e3 - fixing up the vetting errors found by the tests 2019-02-04 11:59:42 +00:00
Rohith 39db0816df - updating the aws tasks to include a launch template resource
- updating the autoscaling group tasks to provision mixed instance policies and templates
2019-02-04 11:54:57 +00:00
Rohith a21ec01f3b - fixing the issue related to incorrect root device detection 2019-01-21 18:13:41 +00:00
Rohith bf69871a8b - fixing up the root device discovery 2019-01-18 22:45:05 +00:00
Rohith eff427937a - adding the additional volumes to cloudformation render 2019-01-18 22:45:05 +00:00
Rohith fb54dee6a5 - adding the additional volumes to terrform implementation 2019-01-18 22:45:05 +00:00
Rohith 5e262932ae - fixing up various linting issues and formatting 2019-01-18 22:45:05 +00:00
Rohith 5bfed5c63f - adding the additional volumes to the launchconfiguration 2019-01-18 22:45:05 +00:00
Justin Santa Barbara 1af610a6c4 Use fast-retry and cleanup task options for tests
The launch configuration test exposed that our integration tests don't
retry for very long, and wait a long time in between retries.

Create a RunTasksOptions type to hold the parameters, in particular
max task time, and the amount of time we wait when all tasks have
failed.
2018-06-18 00:04:23 -04:00
Justin Santa Barbara a9eb6fed2e AWS: Delete old LaunchConfigurations
We delete old AWS LaunchConfigurations when we see that we have more
than 3.  We add a feature flag KeepLaunchConfigurations to disable this
functionality, for backwards compatability.

Fixes #329
2018-06-17 23:24:53 -04:00
devops d734f35126 Add support for instance monitoring
Add API backward comptability

Add api generated files

documenting detailed-monitoring

instance-group json typo

Update test expected result
to support enable_monitroing

Add instance-monitroing support to CF

Improve doc, test and rename InstanceMonitoring

Rename instnace-monitoring to fit the YAML kops form

typo detailedInstanceMonitoring
2018-03-21 23:06:38 +02:00
Justin Santa Barbara ab7439b360 More mocks - sufficient for privatecalico to roundtrip 2018-03-11 23:12:22 -04:00
Justin Santa Barbara 9919254205 AWS LaunchConfiguration error handling fix
We would loop forever on an unexpected error.
2018-01-25 08:35:15 -05:00
chrislovecnm 1e418c3e13 more goimport updates 2017-11-04 10:03:02 -06:00
Patrick Harböck 8db87d20cd Check actual EbsOptimized status during cluster update 2017-08-30 00:30:00 +02:00
Ionut Craciunescu 07397ec2f0 ran make gofmt 2017-08-01 00:34:39 +01:00
Ionut Craciunescu 66d377f5c4 comment update 2017-08-01 00:28:59 +01:00
Ionut Craciunescu 847bf0c2e1 updates to support aws disks with provisioned iops 2017-08-01 00:28:21 +01:00
Justin Santa Barbara 3dfe48e5ae Wiring up lifecycle 2017-07-15 22:03:54 -04:00
Justin Santa Barbara 3e1ce4f950 Add Lifecycle 2017-07-15 22:01:03 -04:00
Austin Moore 6ec64704e2 Remove unnecessary json tag on field 2017-06-30 12:05:59 -04:00
Austin Moore f4c7c61fae Add field to enable EBS Volume Optimization 2017-06-27 16:15:54 -04:00
Justin Santa Barbara 48b26d0f93 Add more logging on IAM failure
I hit an odd IAM failure yesterday, and this information would have been
helpful.  It only proved a negative - it turned out to be an AWS problem
that was solved by deleting and recreating the IAM roles - but still
makes diagnosis much easier.
2017-06-20 00:42:17 -04:00
Justin Santa Barbara 725266f834 Add missed error handling from Autoscaling list
Issue #2304
2017-04-07 23:48:05 -04:00
Daniel Cohen bcdf32cebc Added a few small fixes for instance tenancy 2017-03-31 14:20:23 -04:00
Daniel Cohen aa1205036d Specify instance tenancy on AWS
Allow tenancy to default to empty

Don't allow dedicated clusters to launch unsupported instances
2017-03-21 14:13:17 -04:00
Justin Santa Barbara cb4641fea3 Code updates 2017-03-16 02:40:50 -04:00
Justin Santa Barbara 51a1cddafc Output ephemeral devices in terraform in consistent order 2017-02-23 01:09:30 -05:00
Eric Hole f146ac309c Merge pull request #1925 from justinsb/fix_1793
Additional ShouldCreate method to prevent spurious changes
2017-02-22 22:17:05 -05:00
Justin Santa Barbara 7d68f744f6 Initial support for cloudformation output 2017-02-17 10:59:16 -05:00
Justin Santa Barbara 5bba483a61 Additional ShouldCreate method to prevent spurious changes
Fix #1793
2017-02-16 01:53:32 -05:00
Phil Kates 3e0bc7db4c
Fix terraform render for addtl security groups
The update in #1444 didn't add the security groups to terraform meaning
if you did a `kops --target terraform` you only got the standard
security group.
2017-02-10 15:57:30 -08:00
Chris Love feb82cfa55 Merge pull request #1716 from justinsb/launchconfig_async_warning
Wait in launchconfiguration task for IAM profile to be ready
2017-01-31 00:15:01 -07:00
Justin Santa Barbara 17ab0bfb1a Wait in launchconfiguration task for IAM profile to be ready
The error message continues to worry users.  Trade off a bit of speed
for comfort with a friendlier error.
2017-01-30 23:36:08 -05:00
Thomas Peitz 4f30a40f0a Fix launchconfiguration.go with gofmt 2017-01-30 18:58:48 +01:00
Thomas Peitz 96f71b8fab Allow additional NodeSecurityGroupIDs, MasterSecurityGroupIDs 2017-01-30 18:58:48 +01:00