Peter Rifel
01b0fc544c
Remove hack/machine_types script
2020-06-09 10:12:58 -05:00
Kubernetes Prow Robot
9e4bf1699a
Merge pull request #9216 from hakman/prepare-multi-arch
...
Prepare Kops for multi-architecture support
2020-06-04 21:35:43 -07:00
Ole Markus With
b62f6aa894
Move networking in nodeup to dedicated subpackage
2020-06-04 17:32:41 +02:00
Ciprian Hacman
654a0d2d8a
Detect supported architecture during node setup
2020-06-03 17:23:59 +03:00
Kubernetes Prow Robot
7b067983df
Merge pull request #9177 from olemarkus/remove-vsphere
...
Remove vsphere cloud provider
2020-06-01 06:19:54 -07:00
Ciprian Hacman
d41fd1ea07
Add packages hashes verification for containerd and Docker
2020-06-01 08:27:18 +03:00
Justin SB
68b826328d
Update set-version script to bump tag in Makefile
...
I had forgotten to automatically bump the
KUBE_APISERVER_HEALTHCHECK_TAG in the Makefile.
Also add pushing the image to the release procedure.
2020-05-31 12:45:36 -04:00
Ole Markus With
7342525872
Remove vsphere from kops files
2020-05-30 13:36:55 +02:00
Ole Markus With
89fba09caa
Remove vsphere vendor stuff and related build files
2020-05-30 13:34:39 +02:00
John Gardiner Myers
8a6d29cd40
Remove support for reading legacy-format keypairs
2020-05-20 13:28:13 -07:00
John Gardiner Myers
e0c32a3fae
Remove dead code
2020-05-09 22:39:19 -07:00
Justin SB
75fd939a62
kube-apiserver: healthcheck via sidecar container
...
kube-apiserver doesn't expose the healthcheck via a dedicated
endpoint, instead relying on anonyomous-access being enabled. That
has previously forced us to enable the unauthenticated endpoint on
127.0.0.1:8080.
Instead we now run a small sidecar container, which
proxies /healthz and /readyz requests (only) adding appropriate
authentication using a client certificate.
This will also enable better load balancer checks in future, as these
have previously been hampered by the custom CA certificate.
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
2020-05-07 08:06:52 -04:00
John Gardiner Myers
935d757a7c
Use KOPS_RSA_PRIVATE_KEY_SIZE for more keys
2020-04-26 20:17:02 -07:00
Peter Rifel
2f098b3ac3
Make verify-terraform script blocking now that it passes
2020-04-08 22:16:57 -05:00
Rodrigo Menezes
95a391c56a
add verify-bindata.sh & separate bindata check and update make commands.
2020-04-08 15:50:51 -07:00
Kubernetes Prow Robot
ef10d5444e
Merge pull request #8825 from rifelpet/hcl2-native
...
Add Terraform 0.12 support
2020-04-07 09:01:44 -07:00
Kubernetes Prow Robot
a06cebc915
Merge pull request #8847 from rifelpet/machine-types
...
Switch to using ec2.DescribeInstanceTypes for building the MachineTypes list
2020-04-06 06:43:46 -07:00
Peter Rifel
4e6e00bec1
Add Terraform 0.12 rendering support and feature flag
2020-04-05 21:18:03 -05:00
Peter Rifel
1b29afb45d
Switch to using ec2.DescribeInstanceTypes for building the MachineType list
2020-04-05 21:16:49 -05:00
John Gardiner Myers
6844eef4ca
Switch to the k/k implementation of drain.Helper
2020-04-05 10:22:49 -07:00
Peter Rifel
4d24c4d1e6
Remove unused ECU and Burstable fields from AWSMachineTypeInfo
...
I tracked these fields back to a 2016 commit that added the entire struct but they still werent used even back then.
2020-04-03 22:19:05 -05:00
Peter Rifel
a0e1672cdc
add terraform testing
2020-03-31 14:50:45 -05:00
John Gardiner Myers
b645dac752
Remove support for v1alpha1 and before
2020-03-24 19:49:15 -07:00
Ciprian Hacman
55aeafb9c3
Fix node-authorizer/pkg/server staticcheck failure
2020-02-28 09:38:42 +02:00
Justin SB
666f5dfde7
Update release process
...
* We need to publish kops-controller image
* Including experimental hack/set-version script that should help with rolling versions
2020-02-27 09:34:26 -05:00
Matt Ouille
f025ff0e70
Add External Policies (AWS managed policy attachments)
2020-02-16 21:54:12 -08:00
Kubernetes Prow Robot
c5d8b142bc
Merge pull request #8575 from johngmyers/utc
...
Use UTC when calculating copyright year
2020-02-16 16:23:28 -08:00
John Gardiner Myers
78e9f5abe0
Use UTC when calculating copyright year
2020-02-16 11:27:26 -08:00
Peter Rifel
49d31b8366
Import common.sh and use KOPS_ROOT when applicable
2020-02-15 20:04:12 -06:00
Peter Rifel
c187cefec2
Move utility functions into common.sh
2020-02-15 20:03:26 -06:00
Peter Rifel
b1638fc259
Remove unused scripts
...
We have long since migrated from Godeps to go mod, and we dont have a gh-pages branch anymore since we use netlify for the docs site.
2020-02-15 20:01:10 -06:00
Justin SB
0cb35638f2
Stop logging to /var/log/kops-controller.log
...
Writing to a hostPath from a non-root container requires file
ownership changes, which is difficult to roll out today. See
discussion in #8454
We were primarily using the logfile for e2e diagnostics, so we're
going to look into collecting the information via other means instead.
We also haven't yet shipped this logfile in a released version (though
we have shipped it in beta releases)
2020-02-04 06:41:25 -05:00
Kim Bao Long
3c094cb471
Fix typo in comment
...
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-31 07:54:37 +07:00
Roberto Rodriguez Alcala
b9945594fd
Updates based on feedback
2020-01-23 20:31:18 -08:00
Kubernetes Prow Robot
0e1f5ba2aa
Merge pull request #8328 from rifelpet/shellcheck
...
Add shellcheck verification
2020-01-17 04:46:55 -08:00
tanjunchen
15b4643aee
upup/pkg/fi/cloudup/awstasks/ staticcheck
2020-01-14 10:02:16 +08:00
Peter Rifel
f6c647230a
Add shellcheck verification
...
Copied from the k/k repo with some of the utility functions inlined, just like verify-staticcheck.sh.
Once merged I'll add another prow job for it.
2020-01-12 18:47:21 -06:00
Kubernetes Prow Robot
179957d09f
Merge pull request #7824 from rifelpet/kops-server-cleanup
...
Remove traces of kops-server
2020-01-11 23:13:36 -08:00
Justin SB
cf5c53c87d
Add tests for manifest normalization
...
(The tests are split out for easier cherry-picking, should we choose to)
2020-01-11 22:41:18 -05:00
Kubernetes Prow Robot
556175910b
Merge pull request #8193 from Aresforchina/fix-staticheckout-pkg-resource02
...
upup/pkg/fi-fix staticcheck
2020-01-11 12:15:36 -08:00
Aresforchina
f312f7c974
upup/pkg/fi-fix staticcheck
2020-01-07 15:50:30 +08:00
Justin Santa Barbara
fc21f4255f
Replace kubernetes mount code with utils
...
This will remove one of the main dependencies on the
kubernetes/kubernetes repo.
2020-01-04 17:34:31 -05:00
Kubernetes Prow Robot
388a3cb23d
Merge pull request #8232 from hakman/staticcheck-simplify
...
Add code simplifications for staticheck
2019-12-30 10:53:39 -08:00
Ciprian Hacman
4c4400c5f3
Add code simplifications for staticheck
2019-12-30 17:40:24 +02:00
Kubernetes Prow Robot
e34c12a8f7
Merge pull request #8223 from johngmyers/openstack-staticcheck
...
Fix pkg/resources/openstack staticcheck failure
2019-12-29 21:21:39 -08:00
John Gardiner Myers
4ef035faa2
Fix pkg/resources/openstack staticcheck failure
2019-12-29 15:57:14 -08:00
John Gardiner Myers
00abe3af7e
Fix node-authorizer/pkg/authorizers/aws staticcheck failure
2019-12-29 15:54:50 -08:00
John Gardiner Myers
e4082aaf4c
Fix cloudmock/aws/mockelbv2 staticcheck failures
2019-12-28 21:25:29 -08:00
Kubernetes Prow Robot
e7ad6a9601
Merge pull request #8143 from tanjunchen/fix-shell-sh001
...
/hack: improve shell script in hack
2019-12-27 18:41:39 -08:00
Kubernetes Prow Robot
c1f5c7acd6
Merge pull request #8202 from johngmyers/kops-staticcheck
...
Fix cmd/kops staticcheck failures
2019-12-27 09:30:31 -08:00
Kubernetes Prow Robot
0377b58a08
Merge pull request #8203 from johngmyers/codegen-staticcheck
...
Fix upup/tools/generators/pkg/codegen staticcheck failures
2019-12-27 08:45:39 -08:00
Peter Rifel
32d1d6cf65
Remove traces of kops-server
2019-12-26 13:20:32 -06:00
ares
1e6675f9e9
Merge branch 'master' into fix-staticcheck-pkg-resources-digitalocean
2019-12-26 13:05:01 +08:00
John Gardiner Myers
3f35e26c9b
Fix upup/tools/generators/pkg/codegen staticcheck failures
2019-12-25 16:15:40 -08:00
John Gardiner Myers
d127b9b1a1
Fix cmd/kops staticcheck failures
2019-12-25 14:59:27 -08:00
Kubernetes Prow Robot
22ddc3b423
Merge pull request #8191 from Aresforchina/fix-staticcheck-pkg-resources01
...
fix staticcheck failures in pkg/resources
2019-12-25 12:03:38 -08:00
tanjunchen
cc0f7022f0
/hack: improve shell script in hack
2019-12-25 17:16:31 +08:00
Kubernetes Prow Robot
5cb2d3605c
Merge pull request #8149 from hakman/staticcheck-dnsprovider
...
dnsprovider/pkg/dnsprovider - fix static check
2019-12-24 06:55:29 -08:00
Aresforchina
8ebcea0024
fix staticcheck failures in pkg/resources
2019-12-24 17:12:53 +08:00
Kubernetes Prow Robot
dffc8975d6
pkg/resources/aws:simplify code and remove code
2019-12-24 10:56:57 +08:00
Kubernetes Prow Robot
61d556f9e9
Merge pull request #8188 from Aresforchina/fix-pkg-resources-aws
...
pkg/resources/aws:simplify code and remove code
2019-12-23 16:19:29 -08:00
Kubernetes Prow Robot
6fd4762290
Merge pull request #8186 from johngmyers/instancegroup-staticcheck
...
pkg/instancegroups - fix static check
2019-12-23 15:25:29 -08:00
Peter Rifel
c6dbe9d686
Remove make command from verify-staticcheck.sh
...
This script should now be called using `make verify-staticcheck` which will handle the go-bindata dependency.
2019-12-23 09:25:42 -06:00
Aresforchina
8f86a1b201
pkg/resources-aws:simplify code and remove code
2019-12-23 19:00:17 +08:00
Kubernetes Prow Robot
5f588f0a50
Merge pull request #8165 from hakman/staticcheck-protokube
...
protokube/pkg - fix static check
2019-12-23 02:49:32 -08:00
John Gardiner Myers
1d3d5c1d2f
pkg/instancegroups - fix static check
2019-12-22 20:56:27 -08:00
Ciprian Hacman
deadeaed1e
dnsprovider/pkg/dnsprovider - fix static check
2019-12-23 06:23:38 +02:00
Peter Rifel
e7e9e62bcc
Remove packages from staticcheck failure list that are no longer failing
2019-12-22 15:12:15 -06:00
Peter Rifel
ef8f07c451
Fix verify-staticcheck prow job
...
The new job was missing the generated files from go-bindata.
I noticed some of the prow jobs use make and others call hack/ scripts directly.
I think it'd be better to use make so we can more easily add dependencies like this, therefor I'd like to propose that we merge this, update the jobs to call make targets, then remove the make command I added to hack/verify-staticcheck.sh
By fixing the existing job as well as the make target, we can unblock other PRs and not get another swarm of failure notifications when the job gets updated to use make.
2019-12-22 15:03:29 -06:00
Ciprian Hacman
defcbe8151
protokube/pkg - fix static check
2019-12-20 20:17:19 +02:00
Kubernetes Prow Robot
6856358cd0
Merge pull request #8118 from tanjunchen/fix-staticcheck-001
...
upup/pkg/fi/ upup/pkg/kutil : simplify code and remove code
2019-12-20 07:41:33 -08:00
Ciprian Hacman
fa665943ac
nodeup/pkg/model - fix static check
2019-12-18 22:07:31 +02:00
tanjunchen
d5fef40863
upup/pkg/fi/cloudup/ upup/pkg/fi/nodeup/ hack/.staticcheck_failures : simplify code and remove code
2019-12-18 09:47:58 +08:00
Kubernetes Prow Robot
252a733415
Merge pull request #8121 from tanjunchen/fix-staiccheck-003
...
util/pkg/ upup/tools/ : simplify code and remove unused code
2019-12-17 11:23:57 -08:00
Kubernetes Prow Robot
40c2762367
Merge pull request #8128 from mikesplain/add_inf1
...
Add inf1 isntances
2019-12-17 08:13:59 -08:00
tanjunchen
e4302e3630
util/pkg/: simplify code and remove unused code
2019-12-17 09:44:18 +08:00
tanjunchen
52537053cc
simplify code and remove unused code
2019-12-17 00:28:35 +08:00
mikesplain
77f9cb155e
Add inf1 isntances
2019-12-16 09:20:14 -05:00
Justin Santa Barbara
e479ecf682
dev: ignore kops-controller in hack/update-expected.sh
...
hack/update-expected.sh should ignore KOPSCONTROLLER_IMAGE when
regenerating the golden test outputs, just as it ignores the local
DNSCONTROLLER_IMAGE override.
2019-12-14 10:53:25 -05:00
Peter Rifel
8e9f7e63be
Install vendored goimports prior to running it
2019-11-26 19:33:58 -06:00
Kubernetes Prow Robot
7022a4f1c1
Merge pull request #7998 from justinsb/goimports-gomod
...
Run goimports from locked version in go.mod
2019-11-25 08:25:40 -08:00
Srikanth
0cc3bc0e37
Update packages
2019-11-24 12:56:46 +05:30
Justin Santa Barbara
3239f44ba8
Run goimports from locked version in go.mod
...
This avoids relying on the version that happens to be installed.
2019-11-24 01:00:30 -05:00
mikesplain
e897124c50
Add new instance types
2019-11-18 09:44:52 -08:00
mikesplain
663ef95171
Update for NA storage
2019-11-18 09:43:07 -08:00
Srikanth
9d0b63b482
Fix build issue with verify-packages
2019-10-29 11:48:25 +05:30
Kubernetes Prow Robot
18cfa5f5b2
Merge pull request #7593 from mikesplain/docs_site_map
...
Docs cleanup / mkdocs migration
2019-10-25 08:31:40 -07:00
Kubernetes Prow Robot
c4245be7b7
Merge pull request #7802 from bittopaz/alicloud
...
Alicloud: add OSS as upload dest
2019-10-19 15:27:43 -07:00
Xiaoyu Zhong
a719e04a6d
Alicloud: add OSS as upload dest
2019-10-16 21:43:26 +08:00
Guangming Wang
40dca69298
fix string trim func in main
...
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-10-16 21:37:28 +08:00
Justin SB
b6862103bb
Change default port for memberlist from 3997
...
We had a port collision on 3997; change the default memberlist ports
to avoid the collision (we haven't shipped a release with this in it).
Also create a go file so that we can use constants to keep track of
our port numbers, rather than magic values.
2019-10-14 07:26:27 -04:00
Justin SB
d3bad10aa9
Move kops-controller to use a yaml configuration file
...
This is more in keeping with componentconfig, and lets us add more
options easily in future.
2019-10-13 07:27:52 -07:00
Kubernetes Prow Robot
0c66a304c3
Merge pull request #7754 from tanjunchen/fix-up-gosimple-error
...
fix-up gosimple check error
2019-10-12 11:18:44 -07:00
Kubernetes Prow Robot
ff1d94c7cb
Merge pull request #7692 from zetaab/kops_ctrl_openstack
...
Kops controller support for OpenStack
2019-10-11 09:13:41 -07:00
Thomas Jackson
6b53d4a199
Update hack packages
2019-10-10 13:09:22 -07:00
tanjunchen
43bf6bdab6
fix-up gosimple check error
2019-10-07 11:59:57 +08:00
Jesse Haka
ed8dbc41d0
kops controller support for openstack
2019-09-28 10:06:39 +03:00
Peter Rifel
466ca95243
Dont assign unused values to variables
2019-09-27 12:51:19 -07:00
Peter Rifel
413580f13f
aws sdk - replace deprecated session.New with session.NewSession
2019-09-27 12:51:19 -07:00
Peter Rifel
974a1c6b3c
Add verify-staticcheck script mostly copied from kubernetes/hack/verify-staticcheck.sh
2019-09-27 11:58:33 -07:00
Justin SB
cdaa7a3a48
Fix boilerplate: headers & packages
2019-09-25 12:48:14 -04:00
mikesplain
c420249120
Add g4dn
2019-09-23 13:23:03 -04:00
mikesplain
1c4c541938
Fix machine types for new nvme string formatting
2019-09-23 13:22:30 -04:00
mikesplain
45a8e5a3b8
First pass
2019-09-19 20:56:29 -04:00
Justin SB
39d642ee97
hack/update-expected.sh: mask development env vars
...
There are a few env vars which are frequently set in development, but
should not be reflected in the tests. Clear them before generated the
expected output.
2019-09-14 11:45:27 -04:00
mikesplain
9e55b8230a
Update copyright notices
...
Also cleans some white spaces
2019-09-09 14:47:51 -04:00
mikesplain
2c95884c25
Update and add back some sizes
2019-09-03 15:15:35 -04:00
Justin SB
3fbc906cbc
Create env-var helper function
...
Refactor to start to centralize the env-var configuration for system
components, also start to add test coverage so we can be sure we
haven't broken things!
2019-09-02 10:26:09 -07:00
Justin SB
810c65eb46
Copy well-known users from apiserver
...
This should eliminate the dependency on k8s.io/apiserver
2019-08-31 08:50:09 -07:00
Justin SB
e48cf36353
Create verify-gomod script
...
Wrapper around go mod tidy
Currently doesn't delete from go.sum, which is untidy but expected
behaviour.
2019-08-30 21:17:17 -07:00
Justin SB
40928493b5
Update apimachinery
...
Also fix hack/make-apimachinery.sh script problem with files that are
not marked writeable.
2019-08-26 21:35:06 -07:00
Justin SB
08c6f0c807
Update packages
2019-08-25 16:00:41 -04:00
Justin SB
5d7d7aa647
hack/update-expected: regenerate gobindata
...
Otherwise we don't always pick up the latest changes to manifests.
2019-07-23 07:49:46 -07:00
Justin SB
512378b335
Rationalize golden-output comparison
...
Create a single helper function: AssertMatchesFile
Also a few output files that weren't consistent.
2019-07-21 23:08:48 -04:00
Justin SB
30d8dd8692
Create hack/update-expected.sh to update test output
...
This should streamline things a little!
2019-07-19 10:48:37 -04:00
Kubernetes Prow Robot
5340fc2799
Merge pull request #6811 from xichengliudui/delete-function-script-keyword
...
Delete the function keyword to prevent shellcheck from failing
2019-07-18 20:09:10 -07:00
Kubernetes Prow Robot
21b5e3b3f4
Merge pull request #7195 from rekcah78/add_new_m5_r5_instances
...
update instances list with make update-machine-types
2019-07-09 09:32:02 -07:00
Kashif Saadat
0a32417375
Add verify-goimports to tests and fix the script so it fails correctly
2019-07-03 16:32:45 +01:00
Christophe GASMI
2cc94d53ab
update instances list with make update-machine-types
2019-06-28 01:29:14 +02:00
Kubernetes Prow Robot
00edef84b3
Merge pull request #7166 from rekcah78/add_new_c5_instances
...
add c5.12xlarge, c5.24xlarge, c5.metal, i3en.metal
2019-06-20 11:31:09 -07:00
Christophe GASMI
00353c736f
update instances list with make update-machine-types
2019-06-20 20:31:30 +09:00
Austin Moore
67d9f5f190
Move getProxyEnvVars into a util package
2019-06-05 15:59:19 -04:00
Justin SB
02b67a69a9
Add script to verify CRD generation
...
Issue #6892
2019-05-16 03:25:45 -07:00
Mike Splain
28dc1dd7de
Add i3en
2019-05-09 12:46:15 -04:00
mikesplain
3d3dc5781d
Fix machine types with klog
2019-05-07 09:02:31 -04:00
Justin SB
76d03b3f71
Generated files: glog -> klog
2019-05-06 12:56:03 -04:00
Justin SB
3e33ac7682
Change code from glog to klog
...
We don't call klog.InitFlags yet, because that will cause a flag
redefinition error until we get everyone to stop using glog. That
will happen when we update to k8s 1.13.
2019-05-06 12:54:51 -04:00
Kubernetes Prow Robot
78f5b2c06a
Merge pull request #6837 from mikesplain/add_t3a_family
...
Add t3a family
2019-04-26 12:16:09 -07:00
mikesplain
835ccf2973
Remove sets to expose error
2019-04-26 12:46:19 -04:00
mikesplain
148bbd9c7a
Add t3a family
2019-04-26 11:06:44 -04:00
Justin SB
bf4c4a1a95
Source gofmt from bazel go
...
Using the approach from k8s.io/repo-infra. This avoids problems where
we are testing with a different version of go than we are building
with.
2019-04-21 16:41:11 -04:00
xichengliudui
2aab2d15cd
Delete the function keyword to prevent shellcheck from failing
2019-04-20 07:04:24 -04:00
mikesplain
db6c0eb02c
Update instances types
...
adds m5ad's and r5ad's
2019-04-03 11:22:50 -04:00
LilyFaFa
12d54b6a1f
support gossip for AliCloud
2019-03-15 15:26:12 +08:00
Gennady Trafimenkov
b8b7840c0f
Update list of packages
2019-03-03 16:16:08 +03:00
Justin SB
148a370f39
update-machine-types: more metal instance types
...
m5, m5d, r5, r5d, z1d metal types
2019-02-28 15:48:33 -05:00
Eric Greer
31a4c40131
merge conflict resolution
2019-02-21 15:20:05 -08:00
Eric Greer
8362b1260e
etcd memory requests can now be specified
2019-02-21 15:14:51 -08:00
Kubernetes Prow Robot
1564a67461
Merge pull request #6277 from gambol99/mix_instances_policy
...
AWS Mixed Instances Policy / Fleet
2019-02-20 10:30:33 -08:00
Rohith
098b4486f5
- fixing up the spelling mistake and the package update
2019-02-04 11:59:43 +00:00
mikesplain
a331b107b6
Fix machine types and cleanup makefile
2019-01-31 17:44:18 -05:00
Kubernetes Prow Robot
70484c009a
Merge pull request #6232 from justinsb/ask_kops_for_its_version
...
kops version: Add --short flag, use it to get version in scripts
2019-01-27 13:50:37 -08:00
Justin SB
b40c9034bd
kops version: Add --short flag, use it to get version in scripts
...
We upload to a location that includes the version, but we need to
specify the version in KOPS_BASE_URL. We expose an option to make
`kops version` more amenable to this scripting.
2019-01-22 22:27:33 -05:00
Derek Lemon -T (delemon - AEROTEK INC at Cisco)
6022679e6b
Openstack package updates
2019-01-19 14:07:10 -07:00
Derek Lemon -T (delemon - AEROTEK INC at Cisco)
103268710c
update packages
2019-01-15 16:29:02 -07:00
Justin SB
533a57a096
Recognize 2019 as a year
...
Happy new year!
2019-01-02 18:30:54 -05:00
Justin SB
a3a48e9078
Create dev-upload tasks, for a faster upload during dev builds
2018-12-20 11:37:30 -05:00
Justin Santa Barbara
b78e4312ec
machine-types: remove duplicate dedup
...
PR #6058 addded dedup in a better way than I had previously done, so
remove my more complicated and now superfluous second dedup.
2018-11-27 23:10:35 -05:00
k8s-ci-robot
f57d836345
Merge pull request #6117 from justinsb/add_a1_and_c5n
...
Add a1 and c5n instance types
2018-11-27 09:56:27 -08:00
Justin Santa Barbara
a29d223bc1
machine-type generator: Warn if instance type not in ENI map
...
And we write these warnings to the output, so that we can see them in
PR review.
2018-11-27 07:33:47 -05:00