kops/cmd/kops/toolbox_instance-selector_t...

208 lines
7.4 KiB
Go

/*
Copyright 2019 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package main
import (
"reflect"
"regexp"
"testing"
"github.com/aws/amazon-ec2-instance-selector/v2/pkg/cli"
"k8s.io/kops/pkg/apis/kops"
)
func TestGetFilters(t *testing.T) {
commandline := cli.New("test", "test", "test", "test", nil)
commandline.Flags = map[string]interface{}{
flexible: true,
allowList: regexp.MustCompile(".*"),
denyList: regexp.MustCompile("t3.nano"),
}
filters := getFilters(&commandline, "us-east-2", []string{"us-east-2a"})
if !*filters.Flexible {
t.Fatalf("Flexible should be true")
}
if filters.AllowList == nil || filters.DenyList == nil {
t.Fatalf("allowList and denyList should not be nil")
}
}
func TestGetInstanceSelectorOpts(t *testing.T) {
count := int32(1)
outputStr := "json"
commandline := cli.New("test", "test", "test", "test", nil)
commandline.Flags = map[string]interface{}{
instanceGroupCount: count,
nodeCountMax: count,
nodeCountMin: count,
nodeVolumeSize: &count,
nodeSecurityGroups: []string{"sec1"},
output: outputStr,
dryRun: true,
clusterAutoscaler: true,
}
instanceSelectorOpts := &InstanceSelectorOptions{}
setInstanceSelectorOpts(instanceSelectorOpts, &commandline)
if instanceSelectorOpts.NodeCountMax != count || instanceSelectorOpts.NodeCountMin != count ||
*instanceSelectorOpts.NodeVolumeSize != count || len(instanceSelectorOpts.NodeSecurityGroups) != int(count) ||
instanceSelectorOpts.InstanceGroupCount != int(count) {
t.Fatalf("node count max/min, volume size, and count of secrurity groups should return %d", count)
}
if instanceSelectorOpts.Output != outputStr {
t.Fatalf("Output should be %s but got %s", outputStr, instanceSelectorOpts.Output)
}
if !instanceSelectorOpts.DryRun || !instanceSelectorOpts.ClusterAutoscaler {
t.Fatalf("dryRun and clusterAutoscaler should be true, got false instead")
}
}
func TestValidateAllPrivateOrPublicSubnets(t *testing.T) {
userSubnets := []string{"utility-us-east-2a", "utility-us-east-2b", "utility-us-east-2c"}
err := validateAllPrivateOrPublicSubnets(userSubnets)
if err != nil {
t.Fatalf("should have passed validation since all user subnets were utility- subnets")
}
userSubnets = []string{"us-east-2a", "us-east-2b", "us-east-2c"}
err = validateAllPrivateOrPublicSubnets(userSubnets)
if err != nil {
t.Fatalf("should have passed validation since all user subnets were private subnets")
}
userSubnets = []string{"utility-us-east-2a", "utility-us-east-2b", "us-east-2c"}
err = validateAllPrivateOrPublicSubnets(userSubnets)
if err == nil {
t.Fatalf("should have failed validation since one zone is not a utility- subnet")
}
}
func TestValidateUserSubnetsWithClusterSubnets(t *testing.T) {
clusterSubnets := []kops.ClusterSubnetSpec{
{
Name: "us-east-2a",
},
{
Name: "us-east-2b",
},
}
userSubnets := []string{"us-east-2a", "us-east-2b"}
err := validateUserSubnetsWithClusterSubnets(userSubnets, clusterSubnets)
if err != nil {
t.Fatalf("should have passed since userSubnets and clusterSubnets match")
}
clusterSubnets = []kops.ClusterSubnetSpec{
{
Name: "us-east-2a",
},
{
Name: "us-east-2b",
},
}
userSubnets = []string{"us-east-2a"}
err = validateUserSubnetsWithClusterSubnets(userSubnets, clusterSubnets)
if err != nil {
t.Fatalf("should have passed since userSubnets are a subset of clusterSubnets")
}
clusterSubnets = []kops.ClusterSubnetSpec{
{
Name: "us-east-2a",
},
{
Name: "us-east-2b",
},
}
userSubnets = []string{"us-east-2c"}
err = validateUserSubnetsWithClusterSubnets(userSubnets, clusterSubnets)
if err == nil {
t.Fatalf("should have failed since userSubnets are not a subset of clusterSubnets")
}
}
func TestCreateInstanceGroup(t *testing.T) {
zones := []string{"us-east-2a", "us-east-2b", "us-east-2c"}
actualIG := createInstanceGroup("testGroup", "clusterTest", zones)
if actualIG.Spec.Role != kops.InstanceGroupRoleNode {
t.Fatalf("instance group should have the \"%s\" role but got %s", kops.InstanceGroupRoleNode, actualIG.Spec.Role)
}
if !reflect.DeepEqual(actualIG.Spec.Subnets, zones) {
t.Fatalf("instance group should have all the zones passed in but got %s", actualIG.Spec.Subnets)
}
}
func TestDecorateWithInstanceGroupSpecs(t *testing.T) {
count := int32(1)
instanceGroupOpts := &InstanceSelectorOptions{
NodeCountMax: count,
NodeCountMin: count,
NodeVolumeSize: &count,
NodeSecurityGroups: []string{"sec-1", "sec-2"},
}
actualIG := decorateWithInstanceGroupSpecs(&kops.InstanceGroup{}, instanceGroupOpts)
if *actualIG.Spec.MaxSize != instanceGroupOpts.NodeCountMax {
t.Fatalf("expected instance group MaxSize to be %d but got %d", instanceGroupOpts.NodeCountMax, actualIG.Spec.MaxSize)
}
if *actualIG.Spec.MinSize != instanceGroupOpts.NodeCountMin {
t.Fatalf("expected instance group MinSize to be %d but got %d", instanceGroupOpts.NodeCountMin, actualIG.Spec.MinSize)
}
if *actualIG.Spec.RootVolumeSize != *instanceGroupOpts.NodeVolumeSize {
t.Fatalf("expected instance group RootVolumeSize to be %d but got %d", instanceGroupOpts.NodeVolumeSize, actualIG.Spec.RootVolumeSize)
}
if !reflect.DeepEqual(actualIG.Spec.AdditionalSecurityGroups, instanceGroupOpts.NodeSecurityGroups) {
t.Fatalf("expected instance group MaxSize to be %d but got %d", instanceGroupOpts.NodeCountMax, actualIG.Spec.MaxSize)
}
}
func TestDecorateWithMixedInstancesPolicy(t *testing.T) {
selectedInstanceTypes := []string{"m3.medium", "m4.medium", "m5.medium"}
usageClasses := []string{"spot", "on-demand"}
for _, usageClass := range usageClasses {
actualIG, err := decorateWithMixedInstancesPolicy(&kops.InstanceGroup{}, usageClass, selectedInstanceTypes)
if err != nil {
t.Fatalf("decorateWithMixedInstancesPolicy returned an error: %v", err)
}
if actualIG.Spec.MixedInstancesPolicy == nil {
t.Fatal("MixedInstancesPolicy should not be nil")
}
if !reflect.DeepEqual(actualIG.Spec.MixedInstancesPolicy.Instances, selectedInstanceTypes) {
t.Fatalf("Instances in MixedInstancePolicy should match selectedInstanceTypes: actual: %v expected: %v", actualIG.Spec.MixedInstancesPolicy, selectedInstanceTypes)
}
if usageClass == "spot" && *actualIG.Spec.MixedInstancesPolicy.SpotAllocationStrategy != "capacity-optimized" {
t.Fatal("Spot MixedInstancePolicy should use capacity-optimizmed allocation strategy")
}
}
}
func TestDecorateWithClusterAutoscalerLabels(t *testing.T) {
initialIG := kops.InstanceGroup{}
clusterName := "testClusterName"
actualIG := decorateWithClusterAutoscalerLabels(&initialIG, clusterName)
if _, ok := actualIG.Spec.CloudLabels["k8s.io/cluster-autoscaler/enabled"]; !ok {
t.Fatalf("enabled cloudLabel for cluster autoscaler should have been added to the instance group spec")
}
if _, ok := actualIG.Spec.CloudLabels["k8s.io/cluster-autoscaler/"+clusterName]; !ok {
t.Fatalf("cluster cloudLabel for cluster autoscaler should have been added to the instance group spec")
}
}