From b5dee128039b4131985fa47ca5a1bb7e66bfdf8b Mon Sep 17 00:00:00 2001 From: devppratik Date: Tue, 23 Jul 2024 15:56:30 +0530 Subject: [PATCH] Update Node Monitor Grace Period default duration to 50s Update description Improve flag comment Update Test case value to be 50s by default Update Description Run make update Minor description fix Kubernetes-commit: f8bf6b97b8f9842c6b8964bae2d47fbf31d3e08c --- config/v1alpha1/types.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/v1alpha1/types.go b/config/v1alpha1/types.go index fe2e46b..bb2ad0e 100644 --- a/config/v1alpha1/types.go +++ b/config/v1alpha1/types.go @@ -403,7 +403,8 @@ type NodeLifecycleControllerConfiguration struct { // nodeMontiorGracePeriod is the amount of time which we allow a running node to be // unresponsive before marking it unhealthy. Must be N times more than kubelet's // nodeStatusUpdateFrequency, where N means number of retries allowed for kubelet - // to post node status. + // to post node status. This value should also be greater than the sum of + // HTTP2_PING_TIMEOUT_SECONDS and HTTP2_READ_IDLE_TIMEOUT_SECONDS. NodeMonitorGracePeriod metav1.Duration // podEvictionTimeout is the grace period for deleting pods on failed nodes. PodEvictionTimeout metav1.Duration