From e4e0bf9b04687a5dcc7e2b051124fbb772dfcf7d Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 2 Dec 2024 14:43:58 +0100 Subject: [PATCH] remove import doc comments The "// import " comment has been superseded by Go modules. We don't have to remove them, but doing so has some advantages: - They are used inconsistently, which is confusing. - We can then also remove the (currently broken) hack/update-vanity-imports.sh. - Last but not least, it would be a first step towards avoiding the k8s.io domain. This commit was generated with sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/') Everything was included, except for package labels // import k8s.io/kubernetes/pkg/util/labels because that package is marked as "read-only". Kubernetes-commit: 8a908e0c0bd96a3455edf7e3b5f5af90564e65b0 --- config/v1alpha1/doc.go | 2 +- doc.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/v1alpha1/doc.go b/config/v1alpha1/doc.go index 1631186..9017efe 100644 --- a/config/v1alpha1/doc.go +++ b/config/v1alpha1/doc.go @@ -18,4 +18,4 @@ limitations under the License. // +k8s:openapi-gen=true // +groupName=kubecontrollermanager.config.k8s.io -package v1alpha1 // import "k8s.io/kube-controller-manager/config/v1alpha1" +package v1alpha1 diff --git a/doc.go b/doc.go index 872ff13..bb493da 100644 --- a/doc.go +++ b/doc.go @@ -14,4 +14,4 @@ See the License for the specific language governing permissions and limitations under the License. */ -package kubecontrollermanager // import "k8s.io/kube-controller-manager" +package kubecontrollermanager