kubernetes
/
kubectl
mirror of https://github.com/kubernetes/kubectl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #120397 from ty-dc/StaticCheck 

cleanup: omit comparison with bool constants

Kubernetes-commit: 441d4b54aec4eebbe55d9c3519691eb9833fa486
This commit is contained in:
Kubernetes Publisher 2023-10-24 05:25:52 +02:00
parent 2ccb201c19 67ef0ca456
commit 22cc602cb3
3 changed files with 23 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
go.mod
View File

@ -30,11 +30,11 @@ require (
github.com/stretchr/testify v1.8.3
golang.org/x/sys v0.13.0
gopkg.in/yaml.v2 v2.4.0
k8s.io/api v0.0.0-20231020231155-fe172d7dd4b6
k8s.io/apimachinery v0.0.0-20231020230052-c047e325a432
k8s.io/cli-runtime v0.0.0-20231021011325-9a91d944dd43
k8s.io/client-go v0.0.0-20231023155907-5f697abdfd94
k8s.io/component-base v0.0.0-20231020234408-94242dafba15
k8s.io/api v0.0.0-20231023194506-bfce70f1b5c8
k8s.io/apimachinery v0.0.0-20231024034334-1e138bd489ac
k8s.io/cli-runtime v0.0.0-20231024042735-7a5787c1f8c2
k8s.io/client-go v0.0.0-20231024035150-c92537416a96
k8s.io/component-base v0.0.0-20231024040035-12d4256eb135
k8s.io/component-helpers v0.0.0-20231020235215-606f6e27cff2
k8s.io/klog/v2 v2.100.1
k8s.io/kube-openapi v0.0.0-20231010175941-2dd684a91f00
@ -96,12 +96,12 @@ require (
)
replace (
k8s.io/api => k8s.io/api v0.0.0-20231020231155-fe172d7dd4b6
k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20231020230052-c047e325a432
k8s.io/cli-runtime => k8s.io/cli-runtime v0.0.0-20231021011325-9a91d944dd43
k8s.io/client-go => k8s.io/client-go v0.0.0-20231023155907-5f697abdfd94
k8s.io/code-generator => k8s.io/code-generator v0.0.0-20231020225210-8e641d9e6730
k8s.io/component-base => k8s.io/component-base v0.0.0-20231020234408-94242dafba15
k8s.io/api => k8s.io/api v0.0.0-20231023194506-bfce70f1b5c8
k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20231024034334-1e138bd489ac
k8s.io/cli-runtime => k8s.io/cli-runtime v0.0.0-20231024042735-7a5787c1f8c2
k8s.io/client-go => k8s.io/client-go v0.0.0-20231024035150-c92537416a96
k8s.io/code-generator => k8s.io/code-generator v0.0.0-20231024034032-0f8102fa0710
k8s.io/component-base => k8s.io/component-base v0.0.0-20231024040035-12d4256eb135
k8s.io/component-helpers => k8s.io/component-helpers v0.0.0-20231020235215-606f6e27cff2
k8s.io/metrics => k8s.io/metrics v0.0.0-20231021010548-6bb8d4fc3e8e
)

20
go.sum
View File

@ -276,16 +276,16 @@ gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4=
k8s.io/api v0.0.0-20231020231155-fe172d7dd4b6 h1:L4jlSzYt2s6+MTDB3gKmik1CNSx9Dpzf3wGnSFV1pqk=
k8s.io/api v0.0.0-20231020231155-fe172d7dd4b6/go.mod h1:mgYOiLIgrQcsuVxrBI6Pplk91r3sl5ZJ7eUx7UBMTkY=
k8s.io/apimachinery v0.0.0-20231020230052-c047e325a432 h1:TWovhSGZGPhiGaOsd06sIch/R3NwKrbnIj5leHo2OCM=
k8s.io/apimachinery v0.0.0-20231020230052-c047e325a432/go.mod h1:mdlGhJWO1mhVzQXm1Lx7D1BvvBIVKlRVy0vvl1LwGjg=
k8s.io/cli-runtime v0.0.0-20231021011325-9a91d944dd43 h1:Gs3xU8NjAqlG+W+IFOvPmZasus8PwQ7pD5sQxS266T4=
k8s.io/cli-runtime v0.0.0-20231021011325-9a91d944dd43/go.mod h1:rkrYJNIQEnwJ+023H9tUIPZZx/ERbbeTYxDMrIbfFEQ=
k8s.io/client-go v0.0.0-20231023155907-5f697abdfd94 h1:3jO/zae/VuKvY7xglmujccWFU14q4xXi6SaSI4lFmHY=
k8s.io/client-go v0.0.0-20231023155907-5f697abdfd94/go.mod h1:LFZk059vlWyzZqB6pGBXuSP+H+mOFxHf4n02BjGXX3Q=
k8s.io/component-base v0.0.0-20231020234408-94242dafba15 h1:oi+whrkIEd6TSCfOXoc0RFjO+lkWSt5xGhgyagyozmQ=
k8s.io/component-base v0.0.0-20231020234408-94242dafba15/go.mod h1:32aa9FDZNGiHgVEFc+k5LL5ro7nGw0JzVnei1nLC0uI=
k8s.io/api v0.0.0-20231023194506-bfce70f1b5c8 h1:U7xcM/WBTkLV+TjNciuW7l+oXM2OHd5/TmVnPKyrmpA=
k8s.io/api v0.0.0-20231023194506-bfce70f1b5c8/go.mod h1:mgYOiLIgrQcsuVxrBI6Pplk91r3sl5ZJ7eUx7UBMTkY=
k8s.io/apimachinery v0.0.0-20231024034334-1e138bd489ac h1:x3g6c1u7CtRoraBlRP2JThB3aHz7vw4FZFXRZsvoIoc=
k8s.io/apimachinery v0.0.0-20231024034334-1e138bd489ac/go.mod h1:mdlGhJWO1mhVzQXm1Lx7D1BvvBIVKlRVy0vvl1LwGjg=
k8s.io/cli-runtime v0.0.0-20231024042735-7a5787c1f8c2 h1:joPkHUx9n26GJj3rmQn/vebDK58bjWFCjQhw3jbTAz4=
k8s.io/cli-runtime v0.0.0-20231024042735-7a5787c1f8c2/go.mod h1:unBeO/pUYLN/9vAOaeXW8RLHPO99g8NPadjeFvvSI5U=
k8s.io/client-go v0.0.0-20231024035150-c92537416a96 h1:76J+c8hyhX3e9eteWOc08cGsJeH5ky0Jmh/naC0ll8g=
k8s.io/client-go v0.0.0-20231024035150-c92537416a96/go.mod h1:hML9Z37ARvWfQt+YEVEMZ3EVJBqM19lCsFXogGW6VX8=
k8s.io/component-base v0.0.0-20231024040035-12d4256eb135 h1:BxZJ2rg42EI0RbeNV5gb+8tdwYZ1iwxZJW4FmUMMdtc=
k8s.io/component-base v0.0.0-20231024040035-12d4256eb135/go.mod h1:ft9o5mWD7glAMtEqdxl4CmAKA9G6DFYRajW3TPrsQhs=
k8s.io/component-helpers v0.0.0-20231020235215-606f6e27cff2 h1:UU4HaZWw14RLLGdOqFR0aWe0zIHS+b8KOGXTSkii4ng=
k8s.io/component-helpers v0.0.0-20231020235215-606f6e27cff2/go.mod h1:8JUXbCGjLd/0eB5/RWXOTZkqb86webkxQM55LwVlWvg=
k8s.io/klog/v2 v2.100.1 h1:7WCHKK6K8fNhTqfBhISHQ97KrnJNFZMcQvKp7gP/tmg=

4
pkg/generate/generate_test.go
View File

@ -254,10 +254,10 @@ func TestGetBool(t *testing.T) {
for _, tt := range testCases {
t.Run(tt.name, func(t *testing.T) {
got, err := GetBool(tt.parameters, tt.key, tt.defaultValue)
if err != nil && tt.expectError == false {
if err != nil && !tt.expectError {
t.Errorf("%s: unexpected error: %v", tt.name, err)
}
if err == nil && tt.expectError == true {
if err == nil && tt.expectError {
t.Errorf("%s: expect error, got nil", tt.name)
}
if got != tt.expected {