From 2325bb8957ffdbdd151a0c86ccf73e77ec8c18bc Mon Sep 17 00:00:00 2001 From: Sunil Arora Date: Thu, 1 Feb 2018 10:21:24 -0800 Subject: [PATCH] fixed manifest loader test --- pkg/kinflate/util/manifestloader_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/kinflate/util/manifestloader_test.go b/pkg/kinflate/util/manifestloader_test.go index ebe869ad7..992a24004 100644 --- a/pkg/kinflate/util/manifestloader_test.go +++ b/pkg/kinflate/util/manifestloader_test.go @@ -32,12 +32,12 @@ func TestManifestLoader(t *testing.T) { loader := kutil.ManifestLoader{FS: fs.MakeFakeFS()} if err := loader.Write("my-manifest.yaml", manifest); err != nil { - t.Fatal("Couldn't write manifest file: ", err) + t.Fatalf("Couldn't write manifest file: ", err) } readManifest, err := loader.Read("my-manifest.yaml") if err != nil { - t.Fatal("Couldn't read manifest file: ", err) + t.Fatalf("Couldn't read manifest file: ", err) } if !reflect.DeepEqual(manifest, readManifest) { t.Fatal("Read manifest is different from written manifest") @@ -49,5 +49,7 @@ func TestManifestLoaderEmptyFile(t *testing.T) { NamePrefix: "prefix", } loader := kutil.ManifestLoader{} - t.Fatal(loader.Write("", manifest)) + if loader.Write("", manifest) == nil { + t.Fatalf("Write to empty filename should fail") + } }