From 6fca42a14a84df685a5432e200a43c52a6b21c0b Mon Sep 17 00:00:00 2001 From: Tim Allclair Date: Tue, 4 Feb 2020 10:36:05 -0800 Subject: [PATCH] Ensure testing credentials are labeled as such Kubernetes-commit: 9d3670f3586c98c02cdca93b7c98dd91fc0b87bd --- pkg/cmd/config/config_test.go | 6 +++--- pkg/generate/versioned/secret_for_docker_registry_test.go | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/cmd/config/config_test.go b/pkg/cmd/config/config_test.go index df9f1c3af..2c5baa94d 100644 --- a/pkg/cmd/config/config_test.go +++ b/pkg/cmd/config/config_test.go @@ -136,7 +136,7 @@ func TestSetNonExistentContext(t *testing.T) { func TestSetIntoExistingStruct(t *testing.T) { expectedConfig := newRedFederalCowHammerConfig() - expectedConfig.AuthInfos["red-user"].Password = "new-path-value" + expectedConfig.AuthInfos["red-user"].Password = "new-path-value" // Fake value for testing. test := configCommandTest{ args: []string{"set", "users.red-user.password", "new-path-value"}, startingConfig: newRedFederalCowHammerConfig(), @@ -391,7 +391,7 @@ func TestBasicClearsToken(t *testing.T) { authInfoWithBasic := clientcmdapi.NewAuthInfo() authInfoWithBasic.Username = "myuser" - authInfoWithBasic.Password = "mypass" + authInfoWithBasic.Password = "mypass" // Fake value for testing. startingConfig := newRedFederalCowHammerConfig() startingConfig.AuthInfos["another-user"] = authInfoWithToken @@ -411,7 +411,7 @@ func TestBasicClearsToken(t *testing.T) { func TestTokenClearsBasic(t *testing.T) { authInfoWithBasic := clientcmdapi.NewAuthInfo() authInfoWithBasic.Username = "myuser" - authInfoWithBasic.Password = "mypass" + authInfoWithBasic.Password = "mypass" // Fake value for testing. authInfoWithToken := clientcmdapi.NewAuthInfo() authInfoWithToken.Token = "token" diff --git a/pkg/generate/versioned/secret_for_docker_registry_test.go b/pkg/generate/versioned/secret_for_docker_registry_test.go index 304cf400b..97384a8fa 100644 --- a/pkg/generate/versioned/secret_for_docker_registry_test.go +++ b/pkg/generate/versioned/secret_for_docker_registry_test.go @@ -20,11 +20,12 @@ import ( "reflect" "testing" - "k8s.io/api/core/v1" + v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) func TestSecretForDockerRegistryGenerate(t *testing.T) { + // Fake values for testing. username, password, email, server := "test-user", "test-password", "test-user@example.org", "https://index.docker.io/v1/" secretData, err := handleDockerCfgJSONContent(username, password, email, server) if err != nil {