diff --git a/go.mod b/go.mod index 6ca3eb77..52b75829 100644 --- a/go.mod +++ b/go.mod @@ -33,8 +33,8 @@ require ( gopkg.in/yaml.v2 v2.4.0 k8s.io/api v0.0.0-20240918001733-e14a61a8c7c2 k8s.io/apimachinery v0.0.0-20240919081406-f7615f37d717 - k8s.io/cli-runtime v0.0.0-20240912050311-fc59256bf6ee - k8s.io/client-go v0.0.0-20240917205444-4f57ad32047b + k8s.io/cli-runtime v0.0.0-20240920165743-3ae12e0e160a + k8s.io/client-go v0.0.0-20240920162441-40a93af7883a k8s.io/component-base v0.0.0-20240918042634-49269eb05058 k8s.io/component-helpers v0.0.0-20240912040858-ed3b8292baf4 k8s.io/klog/v2 v2.130.1 @@ -97,3 +97,5 @@ require ( gopkg.in/yaml.v3 v3.0.1 // indirect sigs.k8s.io/kustomize/api v0.17.2 // indirect ) + +replace k8s.io/code-generator => k8s.io/code-generator v0.0.0-20240920005538-61df8a8f0355 diff --git a/go.sum b/go.sum index 64a2c07d..5ace99e1 100644 --- a/go.sum +++ b/go.sum @@ -282,10 +282,10 @@ k8s.io/api v0.0.0-20240918001733-e14a61a8c7c2 h1:Aoezaxq3CoE7uIcQal4PEUL9P+AQPDj k8s.io/api v0.0.0-20240918001733-e14a61a8c7c2/go.mod h1:peFini8XRw/7apbDOFTp0ZPE50xez1sCjfkRipDXJFQ= k8s.io/apimachinery v0.0.0-20240919081406-f7615f37d717 h1:V7v1okd1jE7GKWP5FcvNwFSM/QGNilNMVNii/uB08+8= k8s.io/apimachinery v0.0.0-20240919081406-f7615f37d717/go.mod h1:5rKPDwwN9qm//xASFCZ83nyYEanHxxhc7pZ8AC4lukY= -k8s.io/cli-runtime v0.0.0-20240912050311-fc59256bf6ee h1:8nArz2IHsrQeHdgwpMMsX9rd+s3QjLDrXjq6bvYlFhc= -k8s.io/cli-runtime v0.0.0-20240912050311-fc59256bf6ee/go.mod h1:NiEsWTsB9iz9y2PIqnD3t2Y2taJpwJXDKaJWLvqLpw0= -k8s.io/client-go v0.0.0-20240917205444-4f57ad32047b h1:qNJBkiH/PYHfreCjRi5e9yoCDlb2p4htEvMJeD8GK3Q= -k8s.io/client-go v0.0.0-20240917205444-4f57ad32047b/go.mod h1:SHqrcQOS6L0CtlGn8DlOEAVxhSHlLqbNwD15CEqWSKU= +k8s.io/cli-runtime v0.0.0-20240920165743-3ae12e0e160a h1:8JKkiJa+KAMwFu/C6ttIe4IE0vOfoPPjCe0xv4T+FA4= +k8s.io/cli-runtime v0.0.0-20240920165743-3ae12e0e160a/go.mod h1:1FrwyrH/wdnz8yTDK6A7VRx9G22+xymcTV0AFkBEc8o= +k8s.io/client-go v0.0.0-20240920162441-40a93af7883a h1:Np0dBBK1HdqJKipNYe4ZFlMw1gv0egfJJDLeXbaL55s= +k8s.io/client-go v0.0.0-20240920162441-40a93af7883a/go.mod h1:rydS34AEFNObhHYAXSdGIdElCTAZ4h6O7VH5Wkep79s= k8s.io/component-base v0.0.0-20240918042634-49269eb05058 h1:8soliJr5YLVB+pJtR12WtJFL1TWoFYBw5ANH3tp9j+s= k8s.io/component-base v0.0.0-20240918042634-49269eb05058/go.mod h1:0TUNldelE6cElcpnJjf1+LVBIZkcUsVXDbj1Xsqj+EI= k8s.io/component-helpers v0.0.0-20240912040858-ed3b8292baf4 h1:gZLro2oDSalbktd7+lgEV3WBQ6MBgOWVDAFS3RaLMJw= diff --git a/pkg/cmd/attach/attach.go b/pkg/cmd/attach/attach.go index b38760a1..73b3cea7 100644 --- a/pkg/cmd/attach/attach.go +++ b/pkg/cmd/attach/attach.go @@ -206,7 +206,7 @@ func (o *AttachOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []s o.GetPodTimeout, err = cmdutil.GetPodRunningTimeoutFlag(cmd) if err != nil { - return cmdutil.UsageErrorf(cmd, err.Error()) + return cmdutil.UsageErrorf(cmd, "%s", err.Error()) } o.Builder = f.NewBuilder diff --git a/pkg/cmd/cp/cp_test.go b/pkg/cmd/cp/cp_test.go index 734f9562..b0038d0f 100644 --- a/pkg/cmd/cp/cp_test.go +++ b/pkg/cmd/cp/cp_test.go @@ -988,6 +988,6 @@ func cmpFileData(t *testing.T, filePath, data string) { type testWriter testing.T func (t *testWriter) Write(p []byte) (n int, err error) { - t.Logf(string(p)) + t.Log(string(p)) return len(p), nil } diff --git a/pkg/cmd/create/create_service.go b/pkg/cmd/create/create_service.go index 54b164b3..6a28942e 100644 --- a/pkg/cmd/create/create_service.go +++ b/pkg/cmd/create/create_service.go @@ -18,6 +18,7 @@ package create import ( "context" + "errors" "fmt" "strconv" "strings" @@ -399,12 +400,12 @@ func parsePorts(portString string) (int32, intstr.IntOrString, error) { var targetPort intstr.IntOrString if portNum, err := strconv.Atoi(portStringSlice[1]); err != nil { if errs := validation.IsValidPortName(portStringSlice[1]); len(errs) != 0 { - return 0, intstr.FromInt32(0), fmt.Errorf(strings.Join(errs, ",")) + return 0, intstr.FromInt32(0), errors.New(strings.Join(errs, ",")) } targetPort = intstr.FromString(portStringSlice[1]) } else { if errs := validation.IsValidPortNum(portNum); len(errs) != 0 { - return 0, intstr.FromInt32(0), fmt.Errorf(strings.Join(errs, ",")) + return 0, intstr.FromInt32(0), errors.New(strings.Join(errs, ",")) } targetPort = intstr.FromInt32(int32(portNum)) } diff --git a/pkg/cmd/delete/delete.go b/pkg/cmd/delete/delete.go index 12df2ff4..2792ccd4 100644 --- a/pkg/cmd/delete/delete.go +++ b/pkg/cmd/delete/delete.go @@ -531,7 +531,7 @@ func (o *DeleteOptions) confirmation(infos []*resource.Info) bool { fmt.Fprintf(o.Out, "%s/%s\n", kindString, info.Name) } - fmt.Fprintf(o.Out, i18n.T("Do you want to continue?")+" (y/n): ") + fmt.Fprint(o.Out, i18n.T("Do you want to continue?")+" (y/n): ") var input string _, err := fmt.Fscan(o.In, &input) if err != nil { diff --git a/pkg/cmd/diff/diff.go b/pkg/cmd/diff/diff.go index 2afa6b17..b82e493c 100644 --- a/pkg/cmd/diff/diff.go +++ b/pkg/cmd/diff/diff.go @@ -161,7 +161,7 @@ func NewCmdDiff(f cmdutil.Factory, streams genericiooptions.IOStreams) *cobra.Co // command it means changes were found. // Thus, it should return status code greater than 1. cmd.SetFlagErrorFunc(func(command *cobra.Command, err error) error { - cmdutil.CheckDiffErr(cmdutil.UsageErrorf(cmd, err.Error())) + cmdutil.CheckDiffErr(cmdutil.UsageErrorf(cmd, "%s", err.Error())) return nil }) diff --git a/pkg/cmd/drain/drain.go b/pkg/cmd/drain/drain.go index 6999739c..a4b71a42 100644 --- a/pkg/cmd/drain/drain.go +++ b/pkg/cmd/drain/drain.go @@ -243,7 +243,7 @@ func (o *DrainCmdOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args [ var err error if len(args) == 0 && !cmd.Flags().Changed("selector") { - return cmdutil.UsageErrorf(cmd, fmt.Sprintf("USAGE: %s [flags]", cmd.Use)) + return cmdutil.UsageErrorf(cmd, "USAGE: %s [flags]", cmd.Use) } if len(args) > 0 && len(o.drainer.Selector) > 0 { return cmdutil.UsageErrorf(cmd, "error: cannot specify both a node name and a --selector option") diff --git a/pkg/cmd/exec/exec.go b/pkg/cmd/exec/exec.go index c008c5b4..f78c2bfc 100644 --- a/pkg/cmd/exec/exec.go +++ b/pkg/cmd/exec/exec.go @@ -216,7 +216,7 @@ func (p *ExecOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, argsIn []s p.GetPodTimeout, err = cmdutil.GetPodRunningTimeoutFlag(cmd) if err != nil { - return cmdutil.UsageErrorf(cmd, err.Error()) + return cmdutil.UsageErrorf(cmd, "%s", err.Error()) } p.Builder = f.NewBuilder diff --git a/pkg/cmd/get/customcolumn.go b/pkg/cmd/get/customcolumn.go index 38024cfa..b9943495 100644 --- a/pkg/cmd/get/customcolumn.go +++ b/pkg/cmd/get/customcolumn.go @@ -19,6 +19,7 @@ package get import ( "bufio" "bytes" + "errors" "fmt" "io" "reflect" @@ -161,7 +162,7 @@ func (s *CustomColumnsPrinter) PrintObj(obj runtime.Object, out io.Writer) error // we need an actual value in order to retrieve the package path for an object. // using reflect.Indirect indiscriminately is valid here, as all runtime.Objects are supposed to be pointers. if printers.InternalObjectPreventer.IsForbidden(reflect.Indirect(reflect.ValueOf(obj)).Type().PkgPath()) { - return fmt.Errorf(printers.InternalObjectPrinterErr) + return errors.New(printers.InternalObjectPrinterErr) } if _, found := out.(*tabwriter.Writer); !found { @@ -210,7 +211,7 @@ func (s *CustomColumnsPrinter) printOneObject(obj runtime.Object, parsers []*jso switch u := obj.(type) { case *metav1.WatchEvent: if printers.InternalObjectPreventer.IsForbidden(reflect.Indirect(reflect.ValueOf(u.Object.Object)).Type().PkgPath()) { - return fmt.Errorf(printers.InternalObjectPrinterErr) + return errors.New(printers.InternalObjectPrinterErr) } unstructuredObject, err := runtime.DefaultUnstructuredConverter.ToUnstructured(u.Object.Object) if err != nil { diff --git a/pkg/cmd/get/get.go b/pkg/cmd/get/get.go index a1bc13cb..4d0ff217 100644 --- a/pkg/cmd/get/get.go +++ b/pkg/cmd/get/get.go @@ -290,7 +290,7 @@ func (o *GetOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []stri usageString = fmt.Sprintf("%s\nUse \"%s explain \" for a detailed description of that resource (e.g. %[2]s explain pods).", usageString, fullCmdName) } - return cmdutil.UsageErrorf(cmd, usageString) + return cmdutil.UsageErrorf(cmd, "%s", usageString) } } diff --git a/pkg/cmd/portforward/portforward.go b/pkg/cmd/portforward/portforward.go index aa6ee3b9..4328560b 100644 --- a/pkg/cmd/portforward/portforward.go +++ b/pkg/cmd/portforward/portforward.go @@ -331,7 +331,7 @@ func (o *PortForwardOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, arg getPodTimeout, err := cmdutil.GetPodRunningTimeoutFlag(cmd) if err != nil { - return cmdutil.UsageErrorf(cmd, err.Error()) + return cmdutil.UsageErrorf(cmd, "%s", err.Error()) } resourceName := args[0] diff --git a/pkg/cmd/taint/taint.go b/pkg/cmd/taint/taint.go index bca70fe3..f185926e 100644 --- a/pkg/cmd/taint/taint.go +++ b/pkg/cmd/taint/taint.go @@ -183,7 +183,7 @@ func (o *TaintOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []st } if o.taintsToAdd, o.taintsToRemove, err = parseTaints(taintArgs); err != nil { - return cmdutil.UsageErrorf(cmd, err.Error()) + return cmdutil.UsageErrorf(cmd, "%s", err.Error()) } o.builder = f.NewBuilder(). WithScheme(scheme.Scheme, scheme.Scheme.PrioritizedVersionsAllGroups()...). diff --git a/pkg/cmd/util/helpers.go b/pkg/cmd/util/helpers.go index bd291a8c..11eaf61a 100644 --- a/pkg/cmd/util/helpers.go +++ b/pkg/cmd/util/helpers.go @@ -243,7 +243,7 @@ func statusCausesToAggrError(scs []metav1.StatusCause) utilerrors.Aggregate { // commands. func StandardErrorMessage(err error) (string, bool) { if debugErr, ok := err.(debugError); ok { - klog.V(4).Infof(debugErr.DebugError()) + klog.V(4).Info(debugErr.DebugError()) } status, isStatus := err.(apierrors.APIStatus) switch { diff --git a/pkg/describe/describe_test.go b/pkg/describe/describe_test.go index be0fd853..a73d29f1 100644 --- a/pkg/describe/describe_test.go +++ b/pkg/describe/describe_test.go @@ -3568,8 +3568,8 @@ Events: t.Errorf("unexpected error: %v", err) } if out != test.output { - t.Logf(out) - t.Logf(test.output) + t.Log(out) + t.Log(test.output) t.Errorf("expected: \n%q\n but got output: \n%q\n", test.output, out) } }) @@ -5222,7 +5222,7 @@ Parameters: t.Errorf("unexpected error: %v", err) } if out != expectedOut { - t.Logf(out) + t.Log(out) t.Errorf("expected : %q\n but got output:\n %q", test.output, out) } }) @@ -6401,7 +6401,7 @@ Events: ` + "\n", t.Errorf("unexpected error: %v", err) } if out != tc.output { - t.Logf(out) + t.Log(out) t.Errorf("expected :\n%s\nbut got output:\n%s", tc.output, out) } }) diff --git a/pkg/util/templates/help_flags_printer.go b/pkg/util/templates/help_flags_printer.go index fdfdf08e..b7e1bf00 100644 --- a/pkg/util/templates/help_flags_printer.go +++ b/pkg/util/templates/help_flags_printer.go @@ -62,7 +62,7 @@ func (p *HelpFlagPrinter) PrintHelpFlag(flag *flag.Flag) { } appendTabStr := strings.ReplaceAll(wrappedStr, "\n", "\n\t") - fmt.Fprintf(p.out, appendTabStr+"\n\n") + fmt.Fprint(p.out, appendTabStr+"\n\n") } // writeFlag will output the help flag based