enhance and fix log calls
Some of these changes are cosmetic (repeatedly calling klog.V instead of
reusing the result), others address real issues:
- Logging a message only above a certain verbosity threshold without
recording that verbosity level (if klog.V().Enabled() { klog.Info... }):
this matters when using a logging backend which records the verbosity
level.
- Passing a format string with parameters to a logging function that
doesn't do string formatting.
All of these locations where found by the enhanced logcheck tool from
https://github.com/kubernetes/klog/pull/297.
In some cases it reports false positives, but those can be suppressed with
source code comments.
Kubernetes-commit: edffc700a43e610f641907290a5152ca593bad79
This commit is contained in:
parent
ef04426c7b
commit
7c4cfc5d12
|
|
@ -93,6 +93,8 @@ func DefaultBehaviorOnFatal() {
|
||||||
// klog.Fatal is invoked for extended information. This is intended for maintainer
|
// klog.Fatal is invoked for extended information. This is intended for maintainer
|
||||||
// debugging and out of a reasonable range for users.
|
// debugging and out of a reasonable range for users.
|
||||||
func fatal(msg string, code int) {
|
func fatal(msg string, code int) {
|
||||||
|
// nolint:logcheck // Not using the result of klog.V(99) inside the if
|
||||||
|
// branch is okay, we just use it to determine how to terminate.
|
||||||
if klog.V(99).Enabled() {
|
if klog.V(99).Enabled() {
|
||||||
klog.FatalDepth(2, msg)
|
klog.FatalDepth(2, msg)
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue