kubernetes
/
kubectl
mirror of https://github.com/kubernetes/kubectl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update comments on Start/Stop of the processes 

[#153243856]
This commit is contained in:
Hannes Hörl 2017-11-29 11:49:17 +00:00 committed by Gareth Smith
parent ff9f027096
commit b7cfe0f868
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/framework/test/apiserver.go
View File

@ -26,7 +26,7 @@ type certDirManager interface {
Destroy() error Destroy() error
} }
// Start starts the apiserver, and returns a gexec.Session. To stop it again, call Terminate and Wait on that session. // Start starts the apiserver, waits for it to come up, and returns an error, if occoured.
func (s *APIServer) Start() error { func (s *APIServer) Start() error {
s.certDirManager = NewTempDirManager() s.certDirManager = NewTempDirManager()
s.stdOut = gbytes.NewBuffer() s.stdOut = gbytes.NewBuffer()
@ -68,7 +68,7 @@ func (s *APIServer) Start() error {
} }
} }
// Stop stops this process gracefully. // Stop stops this process gracefully, waits for its termination, and cleans up the cert directory.
func (s *APIServer) Stop() { func (s *APIServer) Stop() {
if s.session != nil { if s.session != nil {
s.session.Terminate().Wait(20 * time.Second) s.session.Terminate().Wait(20 * time.Second)

4
pkg/framework/test/etcd.go
View File

@ -26,7 +26,7 @@ type dataDirManager interface {
Destroy() error Destroy() error
} }
// Start starts the etcd, and returns a gexec.Session. To stop it again, call Terminate and Wait on that session. // Start starts the etcd, waits for it to come up, and returns an error, if occoured.
func (e *Etcd) Start() error { func (e *Etcd) Start() error {
e.dataDirManager = NewTempDirManager() e.dataDirManager = NewTempDirManager()
e.stdOut = gbytes.NewBuffer() e.stdOut = gbytes.NewBuffer()
@ -64,7 +64,7 @@ func (e *Etcd) Start() error {
} }
} }
// Stop stops this process gracefully. // Stop stops this process gracefully, waits for its termination, and cleans up the data directory.
func (e *Etcd) Stop() { func (e *Etcd) Stop() {
if e.session != nil { if e.session != nil {
e.session.Terminate().Wait(20 * time.Second) e.session.Terminate().Wait(20 * time.Second)