Make `pre-commit.sh` work with the test framework

Eventually we want our framework to work nicely with just `go test`. To
get there we need to
- inject KUBE_ASSETS_DIR
- make the framework work when run multiple times in parallel (port
  collitions, expose bound ports the the subject under test, ...)

We decided to make sure our tests are run in sequence (and not in
parallel to any other thing using etcd, for that matter) by making this
explicit in the `pre-commit.sh` - for now.

As soon as we are there, we can rollback the change to the
`pre-commit.sh` end have the test framework be tested the same as
everything else.

[#153248975]
This commit is contained in:
Hannes Hörl 2017-11-29 15:14:33 +00:00 committed by Gareth Smith
parent 849d4f9e39
commit ccb54d246a
2 changed files with 7 additions and 2 deletions

View File

@ -19,7 +19,12 @@ go vet -all ./...
rc=$((rc || $?)) rc=$((rc || $?))
echo "Running go test" echo "Running go test"
go test -v ./... go list ./... | grep -vF pkg/framework/test | xargs go test -v
rc=$((rc || $?))
echo "Running test framework tests"
./pkg/framework/test/scripts/download-binaries.sh \
&& ./pkg/framework/test/scripts/run-tests.sh
rc=$((rc || $?)) rc=$((rc || $?))
exit $rc exit $rc

View File

@ -46,7 +46,7 @@ func Execute() {
} }
} }
func init() { func init() {
cobra.OnInitialize(initConfig) cobra.OnInitialize(initConfig)
// Here you will define your flags and configuration settings. // Here you will define your flags and configuration settings.