kubernetes
/
kubectl
mirror of https://github.com/kubernetes/kubectl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kubectl: use embedded translations instead of generated bindata 

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>

Kubernetes-commit: eb75b34394964fbc325ca08a5d0b126c5ea16b6f
This commit is contained in:
Nabarun Pal 2021-03-04 10:26:41 +05:30 committed by Kubernetes Publisher
parent f52da0a0a3
commit e99a037812
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/util/i18n/i18n.go
View File

@ -19,17 +19,19 @@ package i18n
import (
"archive/zip"
"bytes"
"embed"
"errors"
"fmt"
"os"
"strings"
"k8s.io/kubectl/pkg/generated"
"github.com/chai2010/gettext-go/gettext"
"k8s.io/klog/v2"
)
//go:embed translations
var translations embed.FS
var knownTranslations = map[string][]string{
"kubectl": {
"default",
@ -112,7 +114,7 @@ func LoadTranslations(root string, getLanguageFn func() string) error {
if err != nil {
return err
}
data, err := generated.Asset(filename)
data, err := translations.ReadFile(filename)
if err != nil {
return err
}

4
pkg/util/i18n/translations/README.md
View File

@ -42,6 +42,10 @@ We use the English translation as the `msgid`.
## Regenerating the bindata file
> Note: Regeneration of bindata is no more necessary for Kubernetes 1.22+ as
> the translations are now embedded into the binary at compile time.
> See: https://github.com/kubernetes/kubernetes/pull/99829
With the `mo` files up to date, you can now convert the generated files
into code using `go-bindata` command which can be installed with: